Skip to content

Commit e03a515

Browse files
committed
fix: sonarqube - Copying recursively might inadvertently add sensitive data to the container. Make sure it is safe here.
1 parent ecef114 commit e03a515

2 files changed

Lines changed: 40 additions & 3 deletions

File tree

.dockerignore

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,36 @@ node_modules
22
.devcontainer
33
.github
44
.vscode
5-
playwright
5+
playwright
6+
7+
# Exclude sensitive files
8+
**/.env
9+
**/.env.*
10+
**/secrets/
11+
**/config/secrets.*
12+
**/*.key
13+
**/*.pem
14+
**/*.cert
15+
**/*.crt
16+
**/id_rsa
17+
**/id_dsa
18+
**/*.pub
19+
20+
# Exclude development files
21+
**/.git/
22+
**/.gitignore
23+
**/.dockerignore
24+
**/Dockerfile
25+
**/docker-compose.yml
26+
**/node_modules/
27+
**/npm-debug.log*
28+
**/yarn-debug.log*
29+
**/yarn-error.log*
30+
**/.DS_Store
31+
**/Thumbs.db
32+
33+
# Exclude build artifacts if needed
34+
**/dist/
35+
**/build/
36+
**/coverage/
37+
**/.nyc_output/

playwright/docker/Dockerfile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ RUN DOTNET_CLI_TELEMETRY_OPTOUT=1 \
3939
####################################
4040
# Builder stage for Node.js frontend
4141
####################################
42-
FROM node:20-bookworm-slim AS frontend-builder
42+
FROM node:22-bookworm-slim AS frontend-builder
4343

4444
# Install git for cloning
4545
RUN apt-get update && \
@@ -51,7 +51,12 @@ RUN apt-get update && \
5151
WORKDIR /opt
5252

5353
# Copy this repo source inside the container
54-
COPY . /opt/jellyfin-web
54+
COPY package*.json /opt/jellyfin-web/
55+
COPY webpack.*.js /opt/jellyfin-web/
56+
COPY tsconfig.json /opt/jellyfin-web/
57+
COPY *.config.* /opt/jellyfin-web/
58+
# nosonar - .dockerignore file excludes sensitive data
59+
COPY src/ /opt/jellyfin-web/src/
5560

5661
# Alternatively, clone a PR or a repo
5762
# RUN git clone https://github.com/jellyfin/jellyfin-web.git --depth 1

0 commit comments

Comments
 (0)