Skip to content

Add zoom control to slideshow#8226

Open
dkacperski97 wants to merge 2 commits into
jellyfin:masterfrom
dkacperski97:zoom-control
Open

Add zoom control to slideshow#8226
dkacperski97 wants to merge 2 commits into
jellyfin:masterfrom
dkacperski97:zoom-control

Conversation

@dkacperski97

@dkacperski97 dkacperski97 commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Added zoom control to slideshow view for precise zoom level adjustment using the mouse.
  • Updated swiper-zoom-fakeimg behaviour to hide during every zoom animation instead of only during the first one.
  • Moved getIcon to slideshowHelper so it can be shared between the slideshow and zoom control.
  • Split the bottom bar because, in my opinion, having the zoom bar in the center looked a bit weird.

Before:
obraz

After:
obraz

Code assistance

Copilot autocomplete

  • I have read and followed the contributing guidelines.
  • I have tested these changes.
  • I have verified that this is not duplicating changes in an existing PR.
  • I have provided a substantive review of another web PR.

@dkacperski97
dkacperski97 requested a review from a team as a code owner July 16, 2026 03:13
Chris4942
Chris4942 reviewed Jul 16, 2026
View reviewed changes

@Chris4942 Chris4942 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With substantive redesigns like this, they often want the changes to go through the design folks in #ui-ux on discord to make sure this vibes with the rest of the app.

I'm not a maintainer, so maybe this is fine, but it would probably better to run this by them.

Comment thread src/components/slideshow/slideshow.js Outdated
@Chris4942 Chris4942 mentioned this pull request Jul 16, 2026
Open
4 tasks
@dmitrylyzo

dmitrylyzo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The slider may cause problems with navigation on TV (try using "TV" display mode on PC).

@dkacperski97

dkacperski97 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

The slider may cause problems with navigation on TV (try using "TV" display mode on PC).

The top and bottom bars are not displayed on the TV:
https://github.com/dkacperski97/jellyfin-web/blob/4daa8aef5006bbc0838e91503342d4f8a7f44dbd/src/components/slideshow/slideshow.js#L160

@sonarqubecloud

sonarqubecloud Bot commented Jul 17, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Chris4942 Chris4942 Chris4942 left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkacperski97 @dmitrylyzo @Chris4942