Fix missing index check in Polyspace parser (#1495)

Author: uhafner

src/main/java/edu/hm/hafner/analysis/parser/PolyspaceParser.java

@@ -50,8 +50,9 @@ private Report parse(final Stream<String> lines) {
             while (lineIterator.hasNext()) {
                 var line = lineIterator.next();
 
-                var attributes = line.split("\\t", 15 + offset);
-                if (Strings.CI.containsAny(attributes[9], "Unreviewed", "To investigate", "To fix", "Other")) {
+                var limit = 15 + offset;
+                var attributes = line.split("\\t", limit);
+                if (attributes.length >= limit && Strings.CI.containsAny(attributes[9], "Unreviewed", "To investigate", "To fix", "Other")) {
                     builder.setFileName(attributes[8]);
                     builder.setCategory(attributes[2]);
                     builder.setDescription(attributes[1]);

src/test/java/edu/hm/hafner/analysis/parser/PolyspaceParserTest.java

@@ -57,39 +57,47 @@ protected void assertThatIssuesArePresent(final Report report, final SoftAsserti
     }
 
     @Test
-    void polyspaceCPTest() {
+    void shouldReadCPTestResults() {
         var warnings = parse("polyspace_cp.csv");
         assertThat(warnings).hasSize(4);
 
-        try (var softly = new SoftAssertions()) {
-            softly.assertThat(warnings.get(0)).hasLineStart(30)
+        assertThat(warnings.get(0)).hasLineStart(30)
                     .hasFileName("D:/workspace/math.c")
                     .hasCategory("Data flow")
                     .hasDescription("Run-time Check")
                     .hasMessage("Check: Unreachable code")
                     .hasModuleName("xinitialize()")
                     .hasColumnStart(4)
                     .hasSeverity(Severity.WARNING_HIGH);
-            softly.assertThat(warnings.get(1)).hasLineStart(34)
+        assertThat(warnings.get(1)).hasLineStart(34)
                     .hasFileName("D:/sample.h")
                     .hasCategory("Data flow")
                     .hasDescription("Run-time Check")
                     .hasModuleName("method_a()")
                     .hasColumnStart(4)
                     .hasSeverity(Severity.WARNING_NORMAL);
-            softly.assertThat(warnings.get(2)).hasLineStart(66)
+        assertThat(warnings.get(2)).hasLineStart(66)
                     .hasDescription("Run-time Check")
                     .hasModuleName("errorCheck()")
                     .hasColumnStart(4)
                     .hasSeverity(Severity.WARNING_HIGH);
-            softly.assertThat(warnings.get(3)).hasLineStart(217)
+        assertThat(warnings.get(3)).hasLineStart(217)
                     .hasDescription("MISRA C:2012")
                     .hasMessage("Check: 10.1 Operands shall not be of an inappropriate essential type. Category: Required")
                     .hasFileName("/file/SERVICE.c")
                     .hasModuleName("a_message()")
                     .hasColumnStart(27)
                     .hasCategory("10 The essential type model")
                     .hasSeverity(Severity.WARNING_NORMAL);
-        }
+    }
+
+    @Test
+    @org.junitpioneer.jupiter.Issue("https://github.com/jenkinsci/analysis-model/issues/1490")
+    void shouldHandleBrokenFiles() {
+        var warnings = parseStringContent("""
+                Header
+                broken\tinput\tfile
+                """);
+        assertThat(warnings).isEmpty();
     }
 }