test(sfcc): isolate filesystem-based integration fixtures in tmp directories

move valid-require-path and site-template fixture setup from repo paths to OS tmp folders
add shared temp directory helpers and consistent cleanup with recursive removal
keep assertions focused on cartridge existence and site template cartridge order behavior

Author: jenssimon

tests/sfcc-valid-require-path.test.ts

@@ -1,5 +1,6 @@
 import { Linter } from "eslint"
 import fs from "node:fs"
+import os from "node:os"
 import path from "node:path"
 import { expect, test } from "vite-plus/test"
 
@@ -10,6 +11,10 @@ function lint(code: string, filename = "cartridges/app_sfra/cartridge/controller
   return linter.verify(code, recommended, { filename })
 }
 
+function createTempTestRoot(): string {
+  return fs.mkdtempSync(path.join(os.tmpdir(), "sfcc-test-root-"))
+}
+
 test("allows dw requires", () => {
   const messages = lint(`
     const OrderMgr = require("dw/order/OrderMgr")
@@ -77,15 +82,17 @@ test("ignores dynamic requires", () => {
 })
 
 test("supports checkCartridgeExists option", () => {
-  const testSuffix = `${Date.now()}_${Math.floor(Math.random() * 1_000_000)}`
-  const existingCartridgeName = `app_storefront_${testSuffix}`
-  const ownCartridgeName = `app_sfra_${testSuffix}`
-  const cartridgesDir = path.join(process.cwd(), "cartridges")
-  const existingCartridge = path.join(cartridgesDir, existingCartridgeName)
-  const ownCartridge = path.join(cartridgesDir, ownCartridgeName)
+  const tempRoot = createTempTestRoot()
+  const tempCartridgesDir = path.join(tempRoot, "cartridges")
+  const ownCartridgeName = "app_sfra"
+  const existingCartridgeName = "app_storefront"
+  const existingCartridge = path.join(tempCartridgesDir, existingCartridgeName)
+  const ownCartridge = path.join(tempCartridgesDir, ownCartridgeName)
+  const filename = "cartridges/app_sfra/cartridge/controllers/Home.js"
 
   fs.mkdirSync(path.join(existingCartridge, "cartridge", "scripts"), { recursive: true })
   fs.mkdirSync(path.join(ownCartridge, "cartridge", "scripts"), { recursive: true })
+  fs.mkdirSync(path.dirname(filename), { recursive: true })
   fs.writeFileSync(
     path.join(existingCartridge, "cartridge", "scripts", "ok.js"),
     "module.exports = true",
@@ -95,51 +102,51 @@ test("supports checkCartridgeExists option", () => {
     "module.exports = true",
   )
 
-  const linter = new Linter()
-  const config = createRecommendedConfig({
-    cartridgesDir: "cartridges",
-    sfcc: {
-      checkCartridgeExists: true,
-    },
-  })
-
-  const messages = linter.verify(
-    `
-      const ok = require("${existingCartridgeName}/cartridge/scripts/ok")
-      const okStar = require("*/cartridge/scripts/ok")
-      const okTilde = require("~/cartridge/scripts/local")
-      const bad = require("missing_cartridge/cartridge/scripts/bad")
-      const badStar = require("*/cartridge/scripts/does-not-exist")
-      const badTilde = require("~/cartridge/scripts/does-not-exist")
-      module.exports = { ok, okStar, okTilde, bad, badStar, badTilde }
-    `,
-    config,
-    { filename: `cartridges/${ownCartridgeName}/cartridge/controllers/Home.js` },
-  )
+  try {
+    const linter = new Linter()
+    const config = createRecommendedConfig({
+      sfcc: {
+        checkCartridgeExists: true,
+        cartridgesDir: tempCartridgesDir,
+      },
+    })
 
-  fs.rmSync(existingCartridge, { recursive: true, force: true })
-  fs.rmSync(ownCartridge, { recursive: true, force: true })
+    const messages = linter.verify(
+      `
+        const ok = require("${existingCartridgeName}/cartridge/scripts/ok")
+        const okStar = require("*/cartridge/scripts/ok")
+        const bad = require("missing_cartridge/cartridge/scripts/bad")
+        const badStar = require("*/cartridge/scripts/does-not-exist")
+        module.exports = { ok, okStar, bad, badStar }
+      `,
+      config,
+      { filename },
+    )
 
-  const hits = messages.filter((m) => m.ruleId === "sfcc/valid-require-path")
-  expect(hits).toHaveLength(3)
-  expect(hits[0]?.message.includes("missing_cartridge")).toBe(true)
-  expect(hits.some((m) => m.message.includes("*/cartridge/scripts/does-not-exist"))).toBe(true)
-  expect(hits.some((m) => m.message.includes("~/cartridge/scripts/does-not-exist"))).toBe(true)
+    const hits = messages.filter((m) => m.ruleId === "sfcc/valid-require-path")
+    expect(hits).toHaveLength(2)
+    expect(hits[0]?.message.includes("missing_cartridge")).toBe(true)
+    expect(hits.some((m) => m.message.includes("*/cartridge/scripts/does-not-exist"))).toBe(true)
+  } finally {
+    fs.rmSync(tempRoot, { recursive: true, force: true })
+  }
 })
 
 test("supports cartridge order from site template", () => {
-  const testSuffix = `${Date.now()}_${Math.floor(Math.random() * 1_000_000)}`
-  const cartridgeName = `app_storefront_${testSuffix}`
-  const ownCartridgeName = `app_sfra_${testSuffix}`
-  const cartridgesDir = path.join(process.cwd(), "cartridges")
-  const targetCartridge = path.join(cartridgesDir, cartridgeName)
-  const ownCartridge = path.join(cartridgesDir, ownCartridgeName)
-  const siteTemplatePath = path.join(process.cwd(), `site_template_${testSuffix}`)
+  const tempRoot = createTempTestRoot()
+  const tempCartridgesDir = path.join(tempRoot, "cartridges")
+  const cartridgeName = "app_storefront"
+  const ownCartridgeName = "app_sfra"
+  const targetCartridge = path.join(tempCartridgesDir, cartridgeName)
+  const ownCartridge = path.join(tempCartridgesDir, ownCartridgeName)
+  const siteTemplatePath = path.join(tempRoot, "site_template")
   const site = "example"
   const siteTemplateXmlPath = path.join(siteTemplatePath, "sites", site, "site.xml")
+  const filename = "cartridges/app_sfra/cartridge/controllers/Home.js"
 
   fs.mkdirSync(path.join(targetCartridge, "cartridge", "scripts"), { recursive: true })
   fs.mkdirSync(path.join(ownCartridge, "cartridge", "scripts"), { recursive: true })
+  fs.mkdirSync(path.dirname(filename), { recursive: true })
   fs.mkdirSync(path.dirname(siteTemplateXmlPath), { recursive: true })
   fs.writeFileSync(
     path.join(targetCartridge, "cartridge", "scripts", "ok.js"),
@@ -153,9 +160,9 @@ test("supports cartridge order from site template", () => {
 
     const linter = new Linter()
     const config = createRecommendedConfig({
-      cartridgesDir: "cartridges",
       sfcc: {
         checkCartridgeExists: true,
+        cartridgesDir: tempCartridgesDir,
         siteTemplatePath,
         site,
       },
@@ -167,14 +174,12 @@ test("supports cartridge order from site template", () => {
         module.exports = { okStar }
       `,
       config,
-      { filename: `cartridges/${ownCartridgeName}/cartridge/controllers/Home.js` },
+      { filename },
     )
 
     expect(messages.some((m) => m.ruleId === "sfcc/valid-require-path")).toBe(false)
   } finally {
-    fs.rmSync(targetCartridge, { recursive: true, force: true })
-    fs.rmSync(ownCartridge, { recursive: true, force: true })
-    fs.rmSync(siteTemplatePath, { recursive: true, force: true })
+    fs.rmSync(tempRoot, { recursive: true, force: true })
   }
 })
 

tests/site-template-cartridge-path.test.ts

@@ -1,9 +1,14 @@
 import fs from "node:fs"
+import os from "node:os"
 import path from "node:path"
 import { expect, test } from "vite-plus/test"
 
 import { getSiteTemplateCartridgePath } from "../src/plugins/_utils/site-template-cartridge-path.js"
 
+function createTempTemplatePath(): string {
+  return fs.mkdtempSync(path.join(os.tmpdir(), "sfcc-site-template-"))
+}
+
 test("returns empty when siteTemplatePath is missing", () => {
   const result = getSiteTemplateCartridgePath(undefined, "example", process.cwd())
   expect(result).toEqual([])
@@ -15,8 +20,7 @@ test("returns empty when site is missing", () => {
 })
 
 test("reads custom-cartridges from conventional site template path", () => {
-  const testSuffix = `${Date.now()}_${Math.floor(Math.random() * 1_000_000)}`
-  const templatePath = path.join(process.cwd(), `site_template_${testSuffix}`)
+  const templatePath = createTempTemplatePath()
   const site = "example"
   const siteXmlPath = path.join(templatePath, "sites", site, "site.xml")
 
@@ -36,8 +40,7 @@ test("reads custom-cartridges from conventional site template path", () => {
 })
 
 test("returns empty when site.xml has no custom-cartridges", () => {
-  const testSuffix = `${Date.now()}_${Math.floor(Math.random() * 1_000_000)}`
-  const templatePath = path.join(process.cwd(), `site_template_${testSuffix}`)
+  const templatePath = createTempTemplatePath()
   const site = "example"
   const siteXmlPath = path.join(templatePath, "sites", site, "site.xml")