Updates all, skills and Readme.md

Author: jesperancinha

.claude/skills/angular/SKILL.md

@@ -0,0 +1,75 @@
+---
+name: angular
+description: Conventions for Angular applications 
+---
+
+## 1. In all setup files, the target should be esnext
+
+### Example in `tsconfig.json`:
+
+Replace:
+
+```json
+{
+  "compilerOptions": {
+    "target": "es5",
+    "lib": ["es5", "dom"],
+    "types": ["cypress", "node"]
+  },
+  "include": ["**/*.ts"]
+}
+```
+
+with
+
+```json
+{
+  "compilerOptions": {
+    "target": "esnext",
+    "lib": ["esnext", "dom"],
+    "types": ["cypress", "node"]
+  },
+  "include": ["**/*.ts"]
+}
+```
+
+## 2. Make sure that the code strictly follows all angular standards
+
+Please find the list of alle angular standards on the following page: https://angular.dev/style-guide.
+It is of the utmost importance that all configuration, HTML, TypeScript, JavaScript, and everything that consists of an angular project, to follow these standards.
+Changes should be made accordingly.
+Modernize the build tooling too
+
+## 3. Make sure that Angular projects are completely reactive with the usage of signals.
+
+With the inception of signals, reactive programming for the front-end has been made easy. Make sure that, whenever possible, that the code uses signals instead of the typical subscriber model.
+Find information on how to do this with good practices over at: https://angular.dev/guide/signals
+Refactor subscribe() to resource()/rxResource()
+
+## 4. Make sure to use new methods for deprecated classes
+
+The `RouterTestingModule` and the `HttpClientTestingModule` have been deprecated. Can you make sure to replace the TypeScript declarations accordingly?
+
+
+From `RouterTestingModule`.
+
+```text
+Use provideRouter or RouterModule/RouterModule.forRoot instead. This module was previously used to provide a helpful collection of test fakes, most notably those for Location and LocationStrategy. These are generally not required anymore, as MockPlatformLocation is provided in TestBed by default. However, you can use them directly with provideLocationMocks.
+```
+
+From `HttpClientTestingModule`.
+
+```text
+Add provideHttpClientTesting() to your providers instead.
+```
+
+Use both definitions to make the changes wherever possible.
+
+## 6. Update the build system, if necessary
+
+Follow the documentation on https://angular.dev/tools/cli/build-system-migration to  make a successful build migration
+
+## 7. Checklist
+
+[] All targets in `tsconfig.json` files should be set to `esnext`
+[] No target should remain with old target compiler option versions

.claude/skills/annotaions/SKILL.md .claude/skills/annotations/SKILL.md.claude/skills/annotaions/SKILL.md renamed to .claude/skills/annotations/SKILL.md

@@ -0,0 +1,48 @@
+---
+name: docker
+description: Conventions for docker
+---
+
+## 1. Update eclipse temurin image usages to the latest java version.
+
+### Example 1:
+
+If the latest java version is `25`and there is an image being used like:
+
+```dockerfile
+FROM eclipse-temurin:21-alpine
+```
+
+Then it should be updated to:
+
+```dockerfile
+FROM eclipse-temurin:25-alpine
+```
+
+### Example 2:
+
+This example is only valid for CircleCI configuration files located in `.circleci/config.yml`.
+Replace this:
+
+```yml
+    docker:
+      - image: eclipse-temurin:21-alpine
+```
+
+with:
+
+```yml
+    docker:
+      - image: eclipse-temurin:25-alpine
+```
+
+## 2. Do not use `docker-compose`
+
+The usage of `docker-compose` has been deprecated and in some cases it doesn't work anymore.
+Please replace `docker-compose` with `docker compose` everywhere, namely in `bash` scripts, `Makefile` and `Makefile.mk` files, `.md` files, all kinds of Markdown files, and other files you may find it.
+Leave all binary files untouched.
+
+## 3. Checklist
+
+[] No Dockerfile should use older Java version images
+[] No Testcontainers code should use older Java version images

.claude/skills/docker/SKILL.md

@@ -0,0 +1,13 @@
+---
+name: java language patterns
+description: Conventions for using Java
+---
+
+## 1. Use modern java conventions in the code and make necessary changes
+
+Make sure to make the code as strict as possible to follow code conventions.
+Please use these sources:
+
+1. https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html
+2. https://blog.jetbrains.com/idea/2024/02/java-best-practices/
+3. https://google.github.io/styleguide/javaguide.html

.claude/skills/java/SKILL.md

@@ -0,0 +1,8 @@
+---
+name: Java Enterprise Edition Frameworks
+description: Conventions for using in all JEE frameworks. These are common standards for CDI
+---
+
+## 1. Correct annotation usage for use-site targets
+
+Constructor params annotated with `@Claim` should be injected with use-site target `param` as `@param:Claim`

.claude/skills/jee/SKILL.md

@@ -0,0 +1,8 @@
+---
+name: java language patterns
+description: Conventions for using in all JVM languages
+---
+
+## 1. Remove all unused imports
+
+If you find unused imports, please remove them. This is a good practice to keep the code clean and maintainable.

.claude/skills/jvm/SKILL.md

@@ -15,3 +15,117 @@ It makes no sense to use this operator when the value is guaranteed to be non-nu
 ## 3. Avoid using `var` when possible
 
 In Kotlin, it is recommended to use `val` instead of `var` whenever possible. This helps to make the code more readable and maintainable, as it makes it clear that the value of a variable is not expected to change.
+
+## 4. Use Duration overload when possible
+
+### Example 1
+
+When using the `delay` function, it is recommended to use the overload that accepts a `Duration` parameter instead of a `Long` parameter. This makes the code more readable and easier to understand, as it clearly indicates the intended duration of the delay.
+
+replace this:
+
+```kotlin
+delay(100)
+```
+
+with this:
+
+```kotlin
+delay(100.milliseconds)
+```
+
+Add import: `import kotlin.time.Duration.Companion.milliseconds`
+
+## 5. Remove all code signatures
+
+Code does not need to be signed. The code signature used to have some value, but in current times, the commit already has a signature.
+Old code may contain signatures that look like this:
+
+```kotlin
+/**
+ * Created by joao on 28-4-16.
+ */
+```
+
+They should all be removed, as they are not needed and add no value to the code.
+
+## 6. When using Kotlin code make sure to use the kotlin extensions for parsing
+
+### Example 1
+
+When finding this:
+
+```kotlin
+    .getForEntity("/tulips", String::class.java)
+```
+replace with:
+```kotlin
+    .getForEntity<String>("/tulips")
+```
+
+## 7. Update the usage of `CSVParser` which is now deprecated
+
+This skill refers to the `CSVParser` from `org.apache.commons.csv.*`
+
+### Example 1
+
+Replace
+```kotlin
+val csvParser = CSVParser(reader, CSV_HEADER)
+```
+
+with
+
+```kotlin
+val csvParser = CSVParser.builder()
+    .setReader(reader)
+    .setFormat(CSV_HEADER).get()
+```
+
+### Example 2
+
+Replace this
+
+```kotlin
+private val CSV_HEADER = DEFAULT
+    .withHeader(
+        "id",
+        "description",
+        "year",
+        "value",
+        "currency",
+        "type",
+        "diameterMM",
+        "internalDiameterMM",
+        "heightMM",
+        "widthMM"
+    )
+```
+
+with:
+
+```kotlin
+private val CSV_HEADER = CSVFormat.DEFAULT.builder()
+    .setHeader(
+        "id",
+        "description",
+        "year",
+        "value",
+        "currency",
+        "type",
+        "diameterMM",
+        "internalDiameterMM",
+        "heightMM",
+        "widthMM"
+    ).get()
+```
+
+## 8. Checklist
+
+[ ] The code does not use the `!!` operator.
+[ ] The code does not use the safe call operator (`?.`) when the value is guaranteed to be non-null.
+[ ] The code uses `val` instead of `var` whenever possible.
+[ ] The code uses the `Duration` overload when using the `delay` function.
+[ ] The code does not contain any code signatures.
+[ ] The code uses the kotlin extensions for parsing when using Kotlin code.
+[ ] The code should not use the `CSVParser` constructuro directly

.claude/skills/kotlin/SKILL.md

@@ -0,0 +1,54 @@
+---
+name: Maven standards
+description: Conventions to use in Maven files, mostly the `pom.xml` files
+---
+
+## 1. Make sure dependencies that are supposed to be of scope `test`, remain test dependencies
+
+In most cases, test dependencies should be of scope `test`. If you find any dependencies that are supposed to be of scope `test` but are not, you should add the `<scope>test</scope>` element to them. This ensures that the dependencies are only included in the test classpath and not in the production classpath.
+For these cases, the following are the dependencies that supposed to be of scope `test`:
+
+```xml
+        <dependency>
+            <groupId>com.fasterxml.jackson.dataformat</groupId>
+            <artifactId>jackson-dataformat-xml</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>io.mockk</groupId>
+            <artifactId>mockk-jvm</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>com.ninja-squad</groupId>
+            <artifactId>springmockk</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>io.kotest</groupId>
+            <artifactId>kotest-assertions-core-jvm</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework.boot</groupId>
+            <artifactId>spring-boot-starter-test</artifactId>
+            <scope>test</scope>
+        </dependency>
+```
+
+In some cases, the test dependencies may be used for production code in test modules. Those cases are not always easy to determine.
+However, if you see that the module, where these dependencies are found to be used, is being used as a test dependency of other modules in the same project, then leave the dependency as is.
+
+## 2. Excessive declarations of the maven compiler
+
+As a common practice, the `maven-compiler-plugin` was declared in the parent module, but also in many submodules. 
+The repetition is unnecessary, but may still prevail.
+Please remove all `maven-compiler-plugin` declarations from all modules and submodules. 
+Keep only one at the top level.
+All the other `maven-compiler-plugin` declarations can be removed
+
+## 3. Excessive declarations of maven surefire and maven failsafe 
+
+As a common practice, the `maven-surefire-plugin` and the `maven-failsafe-plugin` were declared in the parent module, but also in many submodules.
+Please remove all `maven-surefire-plugin` and the `maven-failsafe-plugin` declarations from all modules and submodules.
+Keep them only at the top level.
+All the other `maven-surefire-plugin` and the `maven-failsafe-plugin` declarations can be removed

.claude/skills/maven/SKILL.md

@@ -20,3 +20,59 @@ junit.jupiter.execution.parallel.mode.classes.default = concurrent
 Only add this file, and if the file doesn't exist. Do not override existing files.
 
 Check if tests run successfully for every module where you add this file. If it fails, then remove the file.
+
+In case they fail, the following should be tried
+
+1. Add `@TestMethodOrder(OrderAnnotation::class)` to the test class
+2. Add `@Execution(SAME_THREAD)` to the test methods that are failing
+3. Add `@Order(1)` to the test methods that are failing. The number should be sequential for all failing tests
+
+## Example 1
+
+```kotlin
+
+@SpringBootTest(webEnvironment = RANDOM_PORT)
+@TestMethodOrder(OrderAnnotation::class)
+class NarwhalsShopControllerTest @Autowired constructor(
+    private val narwhalsWebShopDao: NarwhalsWebShopDao,
+    private val testRestTemplate: TestRestTemplate,
+) {
+    val xmlHeaders = HttpHeaders().apply {
+        add("Content-Type", APPLICATION_XML_VALUE)
+    }
+    val jsonHeaders = HttpHeaders().apply {
+        add("Content-Type", APPLICATION_JSON_VALUE)
+    }
+
+    @Test
+    fun `should load narwhals`() {
+    }
+
+    @Test
+    fun `should make full purchase when stocks are available`() {
+    }
+
+    @Test
+    @Execution(SAME_THREAD)
+    fun `should make multiple purchase request but only one succeeds when stocks are available`(): Unit = runBlocking {
+    }
+
+    @Test
+    @Execution(SAME_THREAD)
+    fun `should make partial purchase when stocks are not available`() {
+    }
+
+    @Test
+    fun `should make no purchase when stocks are not available and show predictions`() {
+    }
+
+    @Test
+    @Execution(SAME_THREAD)
+    @Order(1)
+    fun `should return not found failed when nothing is available`() {
+    }
+
+}
+```
+
+If it still fails. Only here revert the changes made to the test class and remove the `junit-platform.properties` file.