Merge remote-tracking branch 'origin/master' into update-java

Author: jesperancinha

.circleci/config.yml

@@ -7,7 +7,7 @@ jobs:
   build:
     docker:
       # specify the version you desire here
-      - image: eclipse-temurin:21-alpine
+      - image: eclipse-temurin:25-alpine
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images

.claude/skills/angular/SKILL.md

@@ -0,0 +1,88 @@
+---
+name: angular
+description: Conventions for Angular applications 
+---
+
+## 1. In all setup files, the target should be esnext
+
+### Example in `tsconfig.json`:
+
+Replace:
+
+```json
+{
+  "compilerOptions": {
+    "target": "es5",
+    "lib": ["es5", "dom"],
+    "types": ["cypress", "node"]
+  },
+  "include": ["**/*.ts"]
+}
+```
+
+with
+
+```json
+{
+  "compilerOptions": {
+    "target": "esnext",
+    "lib": ["esnext", "dom"],
+    "types": ["cypress", "node"]
+  },
+  "include": ["**/*.ts"]
+}
+```
+
+## 2. Make sure that the code strictly follows all angular standards
+
+Please find the list of alle angular standards on the following page: https://angular.dev/style-guide.
+It is of the utmost importance that all configuration, HTML, TypeScript, JavaScript, and everything that consists of an angular project, to follow these standards.
+Changes should be made accordingly.
+Modernize the build tooling too
+
+## 3. Make sure that Angular projects are completely reactive with the usage of signals.
+
+With the inception of signals, reactive programming for the front-end has been made easy. Make sure that, whenever possible, that the code uses signals instead of the typical subscriber model.
+Find information on how to do this with good practices over at: https://angular.dev/guide/signals
+Refactor subscribe() to resource()/rxResource()
+
+## 4. Make sure to use new methods for deprecated classes
+
+The `RouterTestingModule` and the `HttpClientTestingModule` have been deprecated. Can you make sure to replace the TypeScript declarations accordingly?
+
+
+From `RouterTestingModule`.
+
+```text
+Use provideRouter or RouterModule/RouterModule.forRoot instead. This module was previously used to provide a helpful collection of test fakes, most notably those for Location and LocationStrategy. These are generally not required anymore, as MockPlatformLocation is provided in TestBed by default. However, you can use them directly with provideLocationMocks.
+```
+
+From `HttpClientTestingModule`.
+
+```text
+Add provideHttpClientTesting() to your providers instead.
+```
+
+Use both definitions to make the changes wherever possible.
+
+## 6. Update the build system, if necessary
+
+Follow the documentation on https://angular.dev/tools/cli/build-system-migration to  make a successful build migration
+
+## 7. Use scss/css standards for scss files
+
+In old projects, very little attention was given to scss standards.
+Here we want to make sure that all scss is being applied according to the scss documents over at:
+
+1. https://sass-lang.com/documentation/syntax/
+2. https://sass-lang.com/documentation/
+
+When possible, make sure to optimize the use of scss for grids.
+Documentation can be found here:
+
+1. https://css-tricks.com/complete-guide-css-grid-layout/
+
+## 8. Checklist
+
+[] All targets in `tsconfig.json` files should be set to `esnext`
+[] No target should remain with old target compiler option versions

.claude/skills/annotations/SKILL.md

@@ -0,0 +1,66 @@
+---
+name: annotations
+description: Conventions for using annotations in all tests using Jupiter
+---
+
+## 1. Make sure to use `@param:Value` eveywhere @Value is declared for Kotlin classes and files only
+
+Remember to run tests after replacing all of them
+
+## 2. Make sure to use interpolation prefixes for the `@Value` annotation in Kotlin classes and files only
+
+### Example 1 (applying to params)
+
+Replace this:
+
+```kotlin
+class VirtualThreadsDemoApplication(
+    val taskService: TaskService,
+    @param:Value("\${org.jesperancinha.vtcc.tasks}") private val tasks: Int,
+)
+```
+
+with this:
+
+```kotlin
+class VirtualThreadsDemoApplication(
+    val taskService: TaskService,
+    @param:Value($$"${org.jesperancinha.vtcc.tasks}") private val tasks: Int,
+) 
+```
+
+### Example 2 (applying to fields, on lateinit vars
+
+Replace this:
+
+```kotlin
+class BankCompanyLauncherOtherPropertiesKotlinTest {
+    /**
+     * Properties and environment variables
+     */
+    @Value($$"${environment}")
+    private lateinit var environment: String
+}
+```
+
+with this:
+
+```kotlin
+class BankCompanyLauncherOtherPropertiesKotlinTest {
+    /**
+     * Properties and environment variables
+     */
+    @field:Value($$"${environment}")
+    private lateinit var environment: String
+}
+```
+
+The same should be applied to annotation `@Autowired`, but only for non-test classes and only in Kotlin files.
+The same should be applied to annotation `@JsonProperty`, `@JsonDeserialize`, `@JsonAlias`, `@LocalServerPort`, but only in Kotlin files.
+Do not add `@Autowired`, or any form of it with a different target to any parameter. `@Autowired` usage should be removed from production code instead.
+
+## 3. Checklist
+
+[] Make sure there is no more use of `@Value` annotation being used directly
+[] Make sure no `@param:Value` has been changed in a Java file
+[] Check that all `@param:Value` annotations are used correctly

.claude/skills/docker/SKILL.md

@@ -0,0 +1,48 @@
+---
+name: docker
+description: Conventions for docker
+---
+
+## 1. Update eclipse temurin image usages to the latest java version.
+
+### Example 1:
+
+If the latest java version is `25`and there is an image being used like:
+
+```dockerfile
+FROM eclipse-temurin:21-alpine
+```
+
+Then it should be updated to:
+
+```dockerfile
+FROM eclipse-temurin:25-alpine
+```
+
+### Example 2:
+
+This example is only valid for CircleCI configuration files located in `.circleci/config.yml`.
+Replace this:
+
+```yml
+    docker:
+      - image: eclipse-temurin:21-alpine
+```
+
+with:
+
+```yml
+    docker:
+      - image: eclipse-temurin:25-alpine
+```
+
+## 2. Do not use `docker-compose`
+
+The usage of `docker-compose` has been deprecated and in some cases it doesn't work anymore.
+Please replace `docker-compose` with `docker compose` everywhere, namely in `bash` scripts, `Makefile` and `Makefile.mk` files, `.md` files, all kinds of Markdown files, and other files you may find it.
+Leave all binary files untouched.
+
+## 3. Checklist
+
+[] No Dockerfile should use older Java version images
+[] No Testcontainers code should use older Java version images

.claude/skills/java/SKILL.md

@@ -0,0 +1,13 @@
+---
+name: java language patterns
+description: Conventions for using Java
+---
+
+## 1. Use modern java conventions in the code and make necessary changes
+
+Make sure to make the code as strict as possible to follow code conventions.
+Please use these sources:
+
+1. https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html
+2. https://blog.jetbrains.com/idea/2024/02/java-best-practices/
+3. https://google.github.io/styleguide/javaguide.html

.claude/skills/jee/SKILL.md

@@ -0,0 +1,8 @@
+---
+name: Java Enterprise Edition Frameworks
+description: Conventions for using in all JEE frameworks. These are common standards for CDI
+---
+
+## 1. Correct annotation usage for use-site targets
+
+Constructor params annotated with `@Claim` should be injected with use-site target `param` as `@param:Claim`

.claude/skills/jvm/SKILL.md

@@ -0,0 +1,8 @@
+---
+name: java language patterns
+description: Conventions for using in all JVM languages
+---
+
+## 1. Remove all unused imports
+
+If you find unused imports, please remove them. This is a good practice to keep the code clean and maintainable.

.claude/skills/kotlin/SKILL.md

@@ -0,0 +1,131 @@
+---
+name: kotlin patterns
+description: Conventions for using Kotlin
+---
+
+## 1. Remove usage of `!!` operator
+
+The `!!` operator should be avoided in Kotlin as it can lead to `NullPointerException` at runtime. Instead, use safe calls (`?.`) or the `let` scope function to handle nullable values more gracefully.
+
+## 2. Remove the safe call operator (`?.`) when possible
+
+Using the safe call operator (`?.`) is a good practice, but it should be used judiciously.
+It makes no sense to use this operator when the value is guaranteed to be non-null, as it can lead to unnecessary null checks and reduce code readability.
+
+## 3. Avoid using `var` when possible
+
+In Kotlin, it is recommended to use `val` instead of `var` whenever possible. This helps to make the code more readable and maintainable, as it makes it clear that the value of a variable is not expected to change.
+
+## 4. Use Duration overload when possible
+
+### Example 1
+
+When using the `delay` function, it is recommended to use the overload that accepts a `Duration` parameter instead of a `Long` parameter. This makes the code more readable and easier to understand, as it clearly indicates the intended duration of the delay.
+
+replace this:
+
+```kotlin
+delay(100)
+```
+
+with this:
+
+```kotlin
+delay(100.milliseconds)
+```
+
+Add import: `import kotlin.time.Duration.Companion.milliseconds`
+
+## 5. Remove all code signatures
+
+Code does not need to be signed. The code signature used to have some value, but in current times, the commit already has a signature.
+Old code may contain signatures that look like this:
+
+```kotlin
+/**
+ * Created by joao on 28-4-16.
+ */
+```
+
+They should all be removed, as they are not needed and add no value to the code.
+
+## 6. When using Kotlin code make sure to use the kotlin extensions for parsing
+
+### Example 1
+
+When finding this:
+
+```kotlin
+    .getForEntity("/tulips", String::class.java)
+```
+replace with:
+```kotlin
+    .getForEntity<String>("/tulips")
+```
+
+## 7. Update the usage of `CSVParser` which is now deprecated
+
+This skill refers to the `CSVParser` from `org.apache.commons.csv.*`
+
+### Example 1
+
+Replace
+```kotlin
+val csvParser = CSVParser(reader, CSV_HEADER)
+```
+
+with
+
+```kotlin
+val csvParser = CSVParser.builder()
+    .setReader(reader)
+    .setFormat(CSV_HEADER).get()
+```
+
+### Example 2
+
+Replace this
+
+```kotlin
+private val CSV_HEADER = DEFAULT
+    .withHeader(
+        "id",
+        "description",
+        "year",
+        "value",
+        "currency",
+        "type",
+        "diameterMM",
+        "internalDiameterMM",
+        "heightMM",
+        "widthMM"
+    )
+```
+
+with:
+
+```kotlin
+private val CSV_HEADER = CSVFormat.DEFAULT.builder()
+    .setHeader(
+        "id",
+        "description",
+        "year",
+        "value",
+        "currency",
+        "type",
+        "diameterMM",
+        "internalDiameterMM",
+        "heightMM",
+        "widthMM"
+    ).get()
+```
+
+## 8. Checklist
+
+[ ] The code does not use the `!!` operator.
+[ ] The code does not use the safe call operator (`?.`) when the value is guaranteed to be non-null.
+[ ] The code uses `val` instead of `var` whenever possible.
+[ ] The code uses the `Duration` overload when using the `delay` function.
+[ ] The code does not contain any code signatures.
+[ ] The code uses the kotlin extensions for parsing when using Kotlin code.
+[ ] The code should not use the `CSVParser` constructuro directly