Add condition field to custom command prompts by mrt181 · Pull Request #5364 · jesseduffield/lazygit

mrt181 · 2026-03-12T14:34:26Z

When building multi-step custom command forms, some prompts are only relevant depending on earlier answers. Without conditional logic, users must dismiss irrelevant prompts manually.

Prompts now accept a condition field with a template expression evaluated against prior form values. Skipped prompts default to an empty string.

PR Description

Please check if the PR fulfills these requirements

Cheatsheets are up-to-date (run go generate ./...)
Code has been formatted (see here)
Tests have been added/updated (see here for the integration test guide)
Text is internationalised (see here)
If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
Docs have been updated if necessary
You've read through your own file changes for silly mistakes etc

stefanhaller

Thanks, looks reasonable overall. A few things below.

pkg/gui/services/custom_commands/handler_creator.go

docs/Custom_Command_Keybindings.md

schema/config.json

codacy-production · 2026-04-02T09:59:53Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 22 duplication

Metric Results

Complexity 0

Duplication 22

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

When building multi-step custom command forms, some prompts are only relevant depending on earlier answers. Without conditional logic, users must dismiss irrelevant prompts manually. Prompts now accept a `condition` field with a template expression evaluated against prior form values. Skipped prompts default to an empty string. The template expression is a string pre- and suffixed with double curly braces - {{}}. Form keys can be reused, a guard ensures that skipped prompts do not reset already set form keys with an empty string. This allows the conditional flow to remind a user to set a key that was left empty because additional conditions want that key to be set. This removes the need to have additional if checks in the command that uses the form keys.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | minor | `v0.60.0` → `v0.61.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.61.0`](https://github.com/jesseduffield/lazygit/releases/tag/v0.61.0) [Compare Source](jesseduffield/lazygit@v0.60.0...v0.61.0)  The big one in this release is support for GitHub pull requests. They are shown as little GitHub icons next to each branch that has one, and you can open a MR in the browser by pressing shift-G. To enable this, all you need to do is install the [`gh`](https://cli.github.com/) tool if you haven't already, and log in using `gh auth login`. #### What's Changed ##### Features ✨ - Show pull requests against branches by [@jesseduffield](https://github.com/jesseduffield) in [#2781](jesseduffield/lazygit#2781) ##### Enhancements 🔥 - Add support for clicking on arrows in the file list to expand/collapse directories by [@blakemckeany](https://github.com/blakemckeany) in [#5365](jesseduffield/lazygit#5365) - Remove empty directories after discarding untracked files by [@stefanhaller](https://github.com/stefanhaller) in [#5408](jesseduffield/lazygit#5408) - Make file sort order and case sensitivity configurable, and default to mix files and folders by [@stefanhaller](https://github.com/stefanhaller) in [#5427](jesseduffield/lazygit#5427) - Allow customizing the window width/height thresholds for when to use portrait mode by [@stefanhaller](https://github.com/stefanhaller) in [#5452](jesseduffield/lazygit#5452) - Log hashes of local branches when deleting them by [@stefanhaller](https://github.com/stefanhaller) in [#5441](jesseduffield/lazygit#5441) - Add condition field to custom command prompts by [@mrt181](https://github.com/mrt181) in [#5364](jesseduffield/lazygit#5364) ##### Fixes 🔧 - Fix staging only some lines of a block of consecutive changes by [@stefanhaller](https://github.com/stefanhaller) in [#5396](jesseduffield/lazygit#5396) - Fix the expanded layout of the branches panel (half and full screen modes) by [@stefanhaller](https://github.com/stefanhaller) in [#5413](jesseduffield/lazygit#5413) - Fix searching commits or main view after switching repos by [@stefanhaller](https://github.com/stefanhaller) in [#5424](jesseduffield/lazygit#5424) - Scroll to top when showing subcommits by [@stefanhaller](https://github.com/stefanhaller) in [#5425](jesseduffield/lazygit#5425) - Fix patch commands when git config has color=always by [@matthijskooijman](https://github.com/matthijskooijman) in [#5405](jesseduffield/lazygit#5405) - Don't stage out-of-date submodules when asking user to auto-stage after resolving conflicts by [@stefanhaller](https://github.com/stefanhaller) in [#5440](jesseduffield/lazygit#5440) ##### Maintenance ⚙️ - Remove go-git dependency by [@stefanhaller](https://github.com/stefanhaller) in [#5420](jesseduffield/lazygit#5420) - Make Debian/Ubuntu install command architecture-independent by [@discapes](https://github.com/discapes) in [#5386](jesseduffield/lazygit#5386) - Bump github.com/buger/jsonparser from 1.1.1 to 1.1.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5423](jesseduffield/lazygit#5423) - fix: pin 7 unpinned action(s), extract 1 inline secret to env var by [@dagecko](https://github.com/dagecko) in [#5439](jesseduffield/lazygit#5439) - Fix dependabot config file by [@stefanhaller](https://github.com/stefanhaller) in [#5443](jesseduffield/lazygit#5443) - Bump actions/cache from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#5444](jesseduffield/lazygit#5444) - Bump actions/download-artifact from 7 to 8 by [@dependabot](https://github.com/dependabot)\[bot] in [#5445](jesseduffield/lazygit#5445) - Bump actions/upload-artifact from 6 to 7 by [@dependabot](https://github.com/dependabot)\[bot] in [#5446](jesseduffield/lazygit#5446) - Bump github.com/lucasb-eyer/go-colorful from 1.3.0 to 1.4.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5447](jesseduffield/lazygit#5447) - Bump github.com/spf13/afero from 1.9.5 to 1.15.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5448](jesseduffield/lazygit#5448) - Bump github.com/creack/pty from 1.1.11 to 1.1.24 by [@dependabot](https://github.com/dependabot)\[bot] in [#5449](jesseduffield/lazygit#5449) - Bump github.com/stretchr/testify from 1.10.0 to 1.11.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#5450](jesseduffield/lazygit#5450) - Bump github.com/sanity-io/litter from 1.5.2 to 1.5.8 by [@dependabot](https://github.com/dependabot)\[bot] in [#5451](jesseduffield/lazygit#5451) - Bump github.com/adrg/xdg from 0.4.0 to 0.5.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#5456](jesseduffield/lazygit#5456) - Bump github.com/spkg/bom from 0.0.0-20160624110644-59b7046e48ad to 1.0.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#5457](jesseduffield/lazygit#5457) - Bump github.com/integrii/flaggy from 1.4.0 to 1.8.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5458](jesseduffield/lazygit#5458) - Bump github.com/sahilm/fuzzy from 0.1.0 to 0.1.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#5459](jesseduffield/lazygit#5459) - Bump github.com/sasha-s/go-deadlock from 0.3.6 to 0.3.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#5460](jesseduffield/lazygit#5460) ##### Docs 📖 - Add a note about AI to CONTRIBUTING.md by [@stefanhaller](https://github.com/stefanhaller) in [#5404](jesseduffield/lazygit#5404) - Update redo keybinding in README.md by [@unikitty37](https://github.com/unikitty37) in [#5387](jesseduffield/lazygit#5387) - Fix grammar in the contributor guide by [@Rohan5commit](https://github.com/Rohan5commit) in [#5392](jesseduffield/lazygit#5392) ##### I18n 🌎 - Update translations from Crowdin by [@stefanhaller](https://github.com/stefanhaller) in [#5476](jesseduffield/lazygit#5476) ##### Performance Improvements 📊 - Improve performance of discarding many files by [@stefanhaller](https://github.com/stefanhaller) in [#5407](jesseduffield/lazygit#5407) #### New Contributors - [@blakemckeany](https://github.com/blakemckeany) made their first contribution in [#5365](jesseduffield/lazygit#5365) - [@discapes](https://github.com/discapes) made their first contribution in [#5386](jesseduffield/lazygit#5386) - [@unikitty37](https://github.com/unikitty37) made their first contribution in [#5387](jesseduffield/lazygit#5387) - [@Rohan5commit](https://github.com/Rohan5commit) made their first contribution in [#5392](jesseduffield/lazygit#5392) - [@matthijskooijman](https://github.com/matthijskooijman) made their first contribution in [#5405](jesseduffield/lazygit#5405) - [@dagecko](https://github.com/dagecko) made their first contribution in [#5439](jesseduffield/lazygit#5439) - [@mrt181](https://github.com/mrt181) made their first contribution in [#5364](jesseduffield/lazygit#5364) **Full Changelog**: <jesseduffield/lazygit@v0.60.0...v0.61.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

mrt181 force-pushed the add-conditional-prompts branch from cfd9c66 to e934c7c Compare March 12, 2026 14:37

mrt181 mentioned this pull request Mar 16, 2026

How to add a Conventional commit specification before committing #4414

Open

mrt181 force-pushed the add-conditional-prompts branch from e934c7c to 4040756 Compare March 16, 2026 14:31

mrt181 force-pushed the add-conditional-prompts branch 3 times, most recently from a51be39 to b117f12 Compare March 27, 2026 20:37

stefanhaller reviewed Mar 30, 2026

View reviewed changes

pkg/gui/services/custom_commands/handler_creator.go Show resolved Hide resolved

pkg/gui/services/custom_commands/handler_creator.go Outdated Show resolved Hide resolved

docs/Custom_Command_Keybindings.md Outdated Show resolved Hide resolved

schema/config.json Outdated Show resolved Hide resolved

mrt181 force-pushed the add-conditional-prompts branch from b117f12 to 0164659 Compare April 2, 2026 09:58

mrt181 force-pushed the add-conditional-prompts branch 2 times, most recently from e9bcf6d to 980ff0a Compare April 2, 2026 21:21

stefanhaller force-pushed the add-conditional-prompts branch from 980ff0a to 4cb6faf Compare April 6, 2026 17:14

stefanhaller added the enhancement New feature or request label Apr 6, 2026

stefanhaller enabled auto-merge April 6, 2026 17:16

stefanhaller merged commit 7f5250a into jesseduffield:master Apr 6, 2026
14 checks passed

BrewTestBot mentioned this pull request Apr 6, 2026

lazygit 0.61.0 Homebrew/homebrew-core#276329

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add condition field to custom command prompts#5364

Add condition field to custom command prompts#5364
stefanhaller merged 1 commit intojesseduffield:masterfrom
mrt181:add-conditional-prompts

mrt181 commented Mar 12, 2026

Uh oh!

stefanhaller left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codacy-production bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mrt181 commented Mar 12, 2026

PR Description

Please check if the PR fulfills these requirements

Uh oh!

stefanhaller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codacy-production bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codacy-production bot commented Apr 2, 2026 •

edited

Loading