fix: update secondaryType validation and add tests for convertFormulaSecondaryTypeToEvaluatorType

Refs: Resolves betterstack error b6ef8c57fe46e77538723abcec6d649e1812a7ac8f4686727753c8351e0e4eae

Author: paustint

libs/features/create-object-and-fields/src/CreateFieldsImportExport.tsx

@@ -104,7 +104,7 @@ export const CreateFieldsImportExport = ({ selectedOrg, rows, onImportRows, onLo
             if (field === 'deleteConstraint' && value) {
               value = ['SetNull', 'Cascade', 'Restrict'].includes(value) ? value : 'SetNull';
             }
-            if (field === 'secondaryType' && value) {
+            if (field === 'secondaryType') {
               value = ensureValidSecondaryType(value);
             }
             if (field === 'writeRequiresMasterRead' && value) {

libs/shared/ui-core/src/create-fields/__tests__/create-fields-utils.spec.ts

@@ -0,0 +1,27 @@
+import { describe, expect, test } from 'vitest';
+import { SalesforceFieldType } from '../create-fields-types';
+import { convertFormulaSecondaryTypeToEvaluatorType } from '../create-fields-utils';
+
+describe('create-fields-utils#convertFormulaSecondaryTypeToEvaluatorType', () => {
+  test.each([
+    ['Checkbox', 'boolean'],
+    ['Currency', 'number'],
+    ['Date', 'date'],
+    ['DateTime', 'datetime'],
+    ['Number', 'number'],
+    ['Percent', 'number'],
+    ['Time', 'time'],
+    ['Text', 'string'],
+  ])('maps secondary type %s to %s', (input, expected) => {
+    expect(convertFormulaSecondaryTypeToEvaluatorType(input as SalesforceFieldType)).toBe(expected);
+  });
+
+  // Imported fields can omit the secondaryType column, leaving the value undefined - it must not throw
+  test.each([undefined, null])('returns string for missing secondary type (%s)', (input) => {
+    expect(convertFormulaSecondaryTypeToEvaluatorType(input as unknown as SalesforceFieldType)).toBe('string');
+  });
+
+  test('returns string for an unknown secondary type', () => {
+    expect(convertFormulaSecondaryTypeToEvaluatorType('SomethingElse' as SalesforceFieldType)).toBe('string');
+  });
+});

libs/shared/ui-core/src/create-fields/create-fields-utils.tsx

@@ -76,7 +76,10 @@ export function ensureValidSecondaryType(type: string): string {
   return 'Text';
 }
 
-export function convertFormulaSecondaryTypeToEvaluatorType(type: SalesforceFieldType): FormulaReturnType {
+export function convertFormulaSecondaryTypeToEvaluatorType(type: Maybe<SalesforceFieldType>): FormulaReturnType {
+  if (!type) {
+    return 'string';
+  }
   return ({
     checkbox: 'boolean',
     currency: 'number',