Skip to content

Commit f7cd311

Browse files
committed
[core] Promote unexpected varying types to log::error.
When `wgpu_core` finds a binding with an unexpected type, log that with `error` severity, not `debug`. This was demoted to `debug` in be6898f, because, as the comment says: > every shader coming from `glslc` outputs an array of clip distances > and hits this path :( However, gfx-rs#8762 added a match case above this that handles clip distance arrays, so such output should no longer trigger any logging at all.
1 parent 7a65558 commit f7cd311

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

wgpu-core/src/validation.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1160,12 +1160,7 @@ impl Interface {
11601160
return;
11611161
}
11621162
ref other => {
1163-
//Note: technically this should be at least `log::error`, but
1164-
// the reality is - every shader coming from `glslc` outputs an array
1165-
// of clip distances and hits this path :(
1166-
// So we lower it to `log::debug` to be less annoying as
1167-
// there's nothing the user can do about it.
1168-
log::debug!("Unexpected varying type: {other:?}");
1163+
log::error!("Unexpected varying type: {other:?}");
11691164
return;
11701165
}
11711166
};

0 commit comments

Comments
 (0)