[tuya] Not all presumed dimmer channels are dimmer channels (openhab#20918)

* [tuya] Remove explicit handling of (presumed) dimmer channels

They will be "value" types anyway and can be handled as such.

Signed-off-by: Mike Jagdis <mjagdis@eris-associates.co.uk>

Author: mjagdis

bundles/org.openhab.binding.tuya/src/main/java/org/openhab/binding/tuya/internal/TuyaChannelTypeProvider.java

@@ -256,13 +256,7 @@ private ChannelType clone(ChannelTypeUID channelTypeUID, ChannelType orig) {
         StateDescriptionFragmentBuilder stateDescriptionFragmentBuilder = null;
         boolean advanced = false;
 
-        if (DIMMER_CHANNEL_CODES.contains(channelTypeId)) {
-            acceptedItemType = DIMMER;
-            category = "slider";
-            configurationRef = "channel-type:tuya:dimmer";
-            tags.add(schemaDp.readOnly ? "Status" : "Control");
-            tags.add("Brightness");
-        } else if ("bitmap".equals(schemaDp.type)) {
+        if ("bitmap".equals(schemaDp.type)) {
             acceptedItemType = NUMBER;
             category = "";
             configurationRef = "channel-type:tuya:bitmap";
@@ -305,7 +299,14 @@ private ChannelType clone(ChannelTypeUID channelTypeUID, ChannelType orig) {
             category = "";
             configurationRef = "channel-type:tuya:number";
 
-            if (!schemaDp.unit.isEmpty()) {
+            if ((schemaDp.unit.isEmpty() && DIMMER_CHANNEL_CODES.contains(channelTypeId)) //
+                    || (!schemaDp.readOnly && "%".equals(schemaDp.unit))) {
+                acceptedItemType = DIMMER;
+                category = "slider";
+                configurationRef = "channel-type:tuya:dimmer";
+                tags.add(schemaDp.readOnly ? "Status" : "Control");
+                tags.add("Brightness");
+            } else if (!schemaDp.unit.isEmpty()) {
                 Unit<?> unit = schemaDp.parsedUnit;
                 if (unit == null) {
                     unit = UnitUtils.parseUnit(schemaDp.unit);

bundles/org.openhab.binding.tuya/src/main/java/org/openhab/binding/tuya/internal/handler/TuyaDeviceHandler.java

@@ -23,7 +23,6 @@
 import static org.openhab.binding.tuya.internal.TuyaBindingConstants.CONFIG_PRODUCT_ID;
 import static org.openhab.binding.tuya.internal.TuyaBindingConstants.CONFIG_PROTOCOL;
 import static org.openhab.binding.tuya.internal.TuyaBindingConstants.CONFIG_RANGE;
-import static org.openhab.binding.tuya.internal.TuyaBindingConstants.DIMMER_CHANNEL_CODES;
 import static org.openhab.core.library.CoreItemFactory.COLOR;
 import static org.openhab.core.library.CoreItemFactory.DIMMER;
 import static org.openhab.core.library.CoreItemFactory.NUMBER;
@@ -645,10 +644,7 @@ private void addChannels() {
             Map<@Nullable String, @Nullable Object> configuration = new HashMap<>();
             configuration.put(CONFIG_DP, schemaDp.id);
 
-            if (DIMMER_CHANNEL_CODES.contains(channelId)) {
-                configuration.put(CONFIG_MIN, schemaDp.min);
-                configuration.put(CONFIG_MAX, schemaDp.max);
-            } else if ("enum".equals(schemaDp.type)) {
+            if ("enum".equals(schemaDp.type)) {
                 List<String> range = Objects.requireNonNullElse(schemaDp.range, List.of());
                 configuration.put(CONFIG_RANGE, String.join(",", range));
             } else if ("value".equals(schemaDp.type)) {