fix: bsd compatibility issues

- iconv //TRANSLIT is effectively GNU-only
- BSD sed reads \t literally

Author: joseluisq

functions/__gitnow_current_branch_list.fish

@@ -1,6 +1,9 @@
 # GitNow — Speed up your Git workflow. 🐠
 # https://github.com/joseluisq/gitnow
 
-function __gitnow_current_branch_list
-    command git branch --list --no-color | LC_ALL=C command sed -E "s/^(\*?[ \t]*)//g" 2>/dev/null
+function __gitnow_current_branch_list -d "Lists local branch names, one per line"
+    # Ask git for clean names instead of parsing `git branch` output: no
+    # `*` marker, no padding, no "(HEAD detached at ...)" line — and no
+    # sed, whose `\t` handling differs between GNU and BSD (macOS).
+    command git for-each-ref --format='%(refname:short)' refs/heads/ 2>/dev/null
 end

functions/__gitnow_slugify.fish

@@ -1,9 +1,24 @@
 # GitNow — Speed up your Git workflow. 🐠
 # https://github.com/joseluisq/gitnow
 
-# adapted from https://gist.github.com/oneohthree/f528c7ae1e701ad990e6
-function __gitnow_slugify
-    # Lowercase + ASCII transliteration; `/` and `.` are preserved since they
-    # are valid in git branch names (e.g. `fix/v1.2`).
-    string join ' ' -- $argv | command iconv -f UTF-8 -t ascii//TRANSLIT | string lower | string replace -ra '[^a-z0-9./-]+' '_' | string replace -ra '^[-_./]+|[-_./]+$' ''
+function __gitnow_slugify -d "Turns free text into a git-safe, lowercase branch slug"
+    # Pure Fish, no iconv: `iconv //TRANSLIT` is GNU-only in practice (macOS
+    # iconv rejects or drops accented characters). Transliterate the common
+    # Latin accents by hand, lowercase, then map anything else non-ASCII to
+    # `_`. `/` and `.` are preserved since they are valid in branch names.
+    set -l s (string join ' ' -- $argv)
+
+    set s (string replace -ra '[àáâäãåāÀÁÂÄÃÅĀ]' a -- $s)
+    set s (string replace -ra '[èéêëēÈÉÊËĒ]' e -- $s)
+    set s (string replace -ra '[ìíîïīÌÍÎÏĪ]' i -- $s)
+    set s (string replace -ra '[òóôöõøōÒÓÔÖÕØŌ]' o -- $s)
+    set s (string replace -ra '[ùúûüūÙÚÛÜŪ]' u -- $s)
+    set s (string replace -ra '[ýÿÝŸ]' y -- $s)
+    set s (string replace -ra '[ñÑ]' n -- $s)
+    set s (string replace -ra '[çÇ]' c -- $s)
+    set s (string replace -ra '[ß]' ss -- $s)
+    set s (string replace -ra '[æÆ]' ae -- $s)
+    set s (string replace -ra '[œŒ]' oe -- $s)
+
+    string lower -- $s | string replace -ra '[^a-z0-9./-]+' '_' | string replace -ra '^[-_./]+|[-_./]+$' ''
 end

tests/integration/commands.test.fish

@@ -95,6 +95,14 @@ it "keeps slash hierarchy and dots"
 branch "Feat/Login.Page" >/dev/null 2>&1
 expect (current_branch) --to-equal feat/login.page
 
+it "lists branch names verbatim (regression: BSD sed stripped leading t)"
+expect (__gitnow_current_branch_list) --to-contain master my_branch feat/login.page
+expect (__gitnow_current_branch_list) --not-to-match '^\*|^\s'
+branch tricky >/dev/null 2>&1
+expect (__gitnow_check_if_branch_exist tricky) --to-equal 1
+expect (__gitnow_check_if_branch_exist opic) --to-equal 0
+move master >/dev/null 2>&1
+
 describe "gitflow branches"
 
 it "feature creates a lowercase prefixed branch"

tests/unit/slugify.test.fish

@@ -13,6 +13,12 @@ expect "$(__gitnow_slugify "My FEATURE")" --to-equal my_feature
 
 it "transliterates unicode to ascii"
 expect "$(__gitnow_slugify "Ñandú Café")" --to-equal nandu_cafe
+expect "$(__gitnow_slugify "Ærøskøbing Straße Œuvre")" --to-equal aeroskobing_strasse_oeuvre
+expect "$(__gitnow_slugify "ÀÉÎÕÜ")" --to-equal aeiou
+
+it "maps other non-ascii characters to underscores"
+expect "$(__gitnow_slugify "日本 x")" --to-equal x
+expect "$(__gitnow_slugify "a→b")" --to-equal a_b
 
 it "preserves slash and dot (valid in git refs)"
 expect "$(__gitnow_slugify "Fix/v1.2")" --to-equal fix/v1.2