Skip to content

Commit d0d33b6

Browse files
jsollycursoragent
andauthored
Increase link underline offset to clear descenders (#58)
Bump always-on underlines from offset-2 to offset-4 so g/y/p no longer collide with the rule on citations and glossary terms. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent cf99f41 commit d0d33b6

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/components/app/ChapterView.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@
195195
<p class="italic text-foreground/95">"{piece.quote.text}"</p>
196196
<footer class="mt-2 not-italic">
197197
<a
198-
class="text-xs font-medium text-primary underline underline-offset-2 sm:text-sm"
198+
class="text-xs font-medium text-primary underline underline-offset-4 sm:text-sm"
199199
href={piece.quote.sourceUrl}
200200
target="_blank"
201201
rel="noopener noreferrer"
@@ -207,7 +207,7 @@
207207
{:else if piece.sourceUrl && piece.citation}
208208
<p class="mt-4 text-xs sm:text-sm">
209209
<a
210-
class="font-medium text-primary underline underline-offset-2"
210+
class="font-medium text-primary underline underline-offset-4"
211211
href={piece.sourceUrl}
212212
target="_blank"
213213
rel="noopener noreferrer"
@@ -232,7 +232,7 @@
232232
{#each chapter.furtherReading as link (link.url + link.label)}
233233
<li>
234234
<a
235-
class="font-medium text-primary underline underline-offset-2"
235+
class="font-medium text-primary underline underline-offset-4"
236236
href={link.url}
237237
target="_blank"
238238
rel="noopener noreferrer"

src/components/app/QuizView.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@
209209
href={q.sourceUrl}
210210
target="_blank"
211211
rel="noreferrer"
212-
class="inline-block text-xs font-medium text-primary underline underline-offset-2"
212+
class="inline-block text-xs font-medium text-primary underline underline-offset-4"
213213
>
214214
{q.citation} ↗
215215
</a>

src/components/app/TermRichText.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<TermDefinitionPopover
2323
{term}
2424
{currentChapterId}
25-
triggerClass="cursor-pointer rounded-sm text-primary underline decoration-dotted decoration-primary/70 underline-offset-2 outline-none hover:decoration-solid focus-visible:ring-2 focus-visible:ring-ring"
25+
triggerClass="cursor-pointer rounded-sm text-primary underline decoration-dotted decoration-primary/70 underline-offset-4 outline-none hover:decoration-solid focus-visible:ring-2 focus-visible:ring-ring"
2626
>
2727
{segment.text}
2828
</TermDefinitionPopover>

0 commit comments

Comments
 (0)