fix: banner win/loss detection

Author: Js41637

src/api/banner_helpers.rs

@@ -2,8 +2,8 @@ use std::{collections::HashMap, ops::Range};
 
 use chrono::{DateTime, Utc};
 
-// Standard-pool 5★ HSR characters and light cones. A pull whose item is in this list and whose
-// timestamp falls outside every rate-up banner is a Loss; everything else counts as a Win.
+// Standard-pool 5★ HSR characters and light cones. A pull outside every configured banner window
+// is a Loss only when the item is in this list; otherwise it is a Win.
 pub const HSR_STANDARD: &[i32] = &[
     1209, 1004, 1101, 1211, 1104, 1107, 1003, // characters
     23000, 23002, 23003, 23004, 23005, 23012, 23013, // light cones
@@ -20,9 +20,19 @@ pub fn is_win_fn<'a>(
     standard: &'a [i32],
 ) -> impl Fn(i32, DateTime<Utc>) -> bool + 'a {
     move |item_id, timestamp| {
-        banners
-            .get(&item_id)
-            .is_some_and(|v| v.iter().any(|r| r.contains(&timestamp)))
-            || !standard.contains(&item_id)
+        let matching_items: Vec<_> = banners
+            .iter()
+            .filter(|(_, ranges)| ranges.iter().any(|range| range.contains(&timestamp)))
+            .map(|(item_id, _)| *item_id)
+            .collect();
+
+        let is_standard = standard.contains(&item_id);
+        let is_win = if matching_items.is_empty() {
+            !is_standard
+        } else {
+            matching_items.contains(&item_id)
+        };
+
+        is_win
     }
 }