fix: improve mihomo error logging to not cause exceptions

Author: Js41637

src/mihomo.rs

@@ -7,7 +7,7 @@ use serde_json::Value;
 use sqlx::PgPool;
 use utoipa::ToSchema;
 
-use anyhow::Result;
+use anyhow::{bail, Context, Result};
 
 use crate::{database, Language};
 
@@ -50,6 +50,55 @@ fn load_cached(language: &Language, uid: i32) -> Result<Option<Mihomo>> {
     }
 }
 
+async fn fetch_json(url: &str, uid: i32, language: Language, label: &str) -> Result<Value> {
+    let response = reqwest::get(url)
+        .await
+        .with_context(|| format!("{label} request failed for uid {uid} language {language}"))?;
+
+    let status = response.status();
+    if !status.is_success() {
+        let body = response.text().await.unwrap_or_default();
+        warn!(
+            uid,
+            language = %language,
+            url = %url,
+            status = %status,
+            body = %body,
+            label,
+            "response was not successful"
+        );
+        bail!(
+            "{label} request returned non-success status {status} for uid {uid} language {language}"
+        );
+    }
+
+    let text = response
+        .text()
+        .await
+        .with_context(|| format!("mihomo {label} body read failed for uid {uid} language {language}"))?;
+
+    match serde_json::from_str(&text) {
+        Ok(json) => Ok(json),
+        Err(err) => {
+            warn!(
+                uid,
+                language = %language,
+                url = %url,
+                status = %status,
+                body = %text,
+                label,
+                error = %err,
+                "response decode failed"
+            );
+            Err(err).with_context(|| {
+                format!(
+                    "{label} json decode failed for uid {uid} language {language} status {status}"
+                )
+            })
+        }
+    }
+}
+
 pub async fn get(uid: i32, language: Language, pool: &PgPool) -> Result<Value> {
     let path = cache_path(&language, uid);
 
@@ -79,23 +128,41 @@ pub async fn get(uid: i32, language: Language, pool: &PgPool) -> Result<Value> {
 
 pub async fn update_and_get(uid: i32, language: Language, pool: &PgPool) -> Result<Value> {
     let now = Utc::now();
+    debug!(uid, language = %language, "mihomo update_and_get start");
 
     let url = format!(
         "https://api.mihomo.me/sr_info_parsed/{uid}?lang={}&version=v2",
         language.mihomo()
     );
+    debug!(uid, language = %language, url = %url, "fetching mihomo payload");
 
-    let mut json: Value = reqwest::get(&url).await?.json().await?;
+    let mut json: Value = match fetch_json(&url, uid, language, "localized").await {
+        Ok(json) => json,
+        Err(err) => {
+            warn!(uid, language = %language, url = %url, error = %err, "mihomo localized fetch failed");
+            return Err(err);
+        }
+    };
+    debug!(uid, language = %language, "fetched mihomo payload");
     if let Some(o) = json.as_object_mut() {
         o.insert("updated_at".to_string(), serde_json::to_value(now)?);
     }
 
     let (en_json, is_english) = if language == Language::En {
+        debug!(uid, language = %language, "using fetched payload as english payload");
         (json.clone(), true)
     } else {
         let en_url = format!("https://api.mihomo.me/sr_info_parsed/{uid}?lang=en&version=v2",);
+        debug!(uid, language = %language, url = %en_url, "fetching english mihomo payload");
 
-        let mut en_json: Value = reqwest::get(&en_url).await?.json().await?;
+        let mut en_json: Value = match fetch_json(&en_url, uid, language, "english").await {
+            Ok(json) => json,
+            Err(err) => {
+                warn!(uid, language = %language, url = %en_url, error = %err, "mihomo english fetch failed");
+                return Err(err);
+            }
+        };
+        debug!(uid, language = %language, "fetched english mihomo payload");
         if let Some(o) = en_json.as_object_mut() {
             o.insert("updated_at".to_string(), serde_json::to_value(now)?);
         }
@@ -108,6 +175,9 @@ pub async fn update_and_get(uid: i32, language: Language, pool: &PgPool) -> Resu
         let writer = brotli::CompressorWriter::new(file, 4096, 4, 22);
 
         serde_json::to_writer(writer, &json)?;
+        debug!(uid, language = %language, "cached mihomo payload");
+    } else {
+        debug!(uid, language = %language, "skipped caching localized mihomo payload");
     }
 
     if !is_english && serde_json::from_value::<Mihomo>(en_json.clone()).is_ok() {
@@ -116,6 +186,9 @@ pub async fn update_and_get(uid: i32, language: Language, pool: &PgPool) -> Resu
         let writer = brotli::CompressorWriter::new(file, 4096, 4, 22);
 
         serde_json::to_writer(writer, &en_json)?;
+        debug!(uid, language = %language, "cached english mihomo payload");
+    } else if !is_english {
+        debug!(uid, language = %language, "skipped caching english mihomo payload");
     }
 
     let mihomo: Mihomo = serde_json::from_value(en_json)?;
@@ -177,6 +250,7 @@ pub async fn update_and_get(uid: i32, language: Language, pool: &PgPool) -> Resu
     };
 
     database::achievement_scores::set(&db_score_achievement, pool).await?;
+    debug!(uid, language = %language, timestamp = %timestamp, "mihomo update_and_get complete");
 
     Ok(json)
 }