Skip to content

Commit c56058a

Browse files
committed
fix(storage-utils): raise exceptions instead of returning file info on error
Changed error handling in StorageUtils methods to raise exceptions instead of returning file path and name when an error occurs. This improves error propagation and debugging.
1 parent 4b0d12f commit c56058a

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

libs/naas-abi-core/naas_abi_core/utils/StorageUtils.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def save_text(
7171
return dir_path, file_name
7272
except Exception as e:
7373
logger.error(f"Error saving text to {dir_path}: {e}")
74-
return dir_path, file_name
74+
raise
7575

7676
def get_image(self, dir_path: str, file_name: str) -> bytes | None:
7777
"""
@@ -101,7 +101,7 @@ def save_image(
101101
return dir_path, file_name
102102
except Exception as e:
103103
logger.error(f"Error saving image to {dir_path}: {e}")
104-
return dir_path, file_name
104+
raise
105105

106106
def get_csv(
107107
self,
@@ -160,7 +160,7 @@ def save_csv(
160160
return dir_path, file_name
161161
except Exception as e:
162162
logger.error(f"Error saving CSV file to {dir_path}: {e}")
163-
return dir_path, file_name
163+
raise
164164

165165
def get_excel(
166166
self,
@@ -210,7 +210,7 @@ def save_excel(
210210
return dir_path, file_name
211211
except Exception as e:
212212
logger.error(f"Error saving Excel file to {dir_path}: {e}")
213-
return dir_path, file_name
213+
raise
214214

215215
def get_json(self, dir_path: str, file_name: str) -> Dict:
216216
"""
@@ -251,7 +251,7 @@ def save_json(
251251
return dir_path, file_name
252252
except Exception as e:
253253
logger.error(f"Error saving JSON data to {dir_path}: {e}")
254-
return dir_path, file_name
254+
raise
255255

256256
def get_yaml(self, dir_path: str, file_name: str) -> Dict:
257257
"""
@@ -298,7 +298,7 @@ def save_yaml(
298298
return dir_path, file_name
299299
except Exception as e:
300300
logger.error(f"Error saving YAML data to {dir_path}: {e}")
301-
return dir_path, file_name
301+
raise
302302

303303
def get_triples(
304304
self, dir_path: str, file_name: str, format: str = "turtle"
@@ -341,7 +341,7 @@ def save_triples(
341341
return dir_path, file_name
342342
except Exception as e:
343343
logger.error(f"Error saving triples to {dir_path}: {e}")
344-
return dir_path, file_name
344+
raise
345345

346346
def get_html(
347347
self, dir_path: str, file_name: str, encoding: str = "utf-8"
@@ -380,7 +380,7 @@ def save_html(
380380
return dir_path, file_name
381381
except Exception as e:
382382
logger.error(f"Error saving HTML to {dir_path}: {e}")
383-
return dir_path, file_name
383+
raise
384384

385385
def get_pdf(self, dir_path: str, file_name: str) -> bytes | None:
386386
"""
@@ -410,7 +410,7 @@ def save_pdf(
410410
return dir_path, file_name
411411
except Exception as e:
412412
logger.error(f"Error saving PDF to {dir_path}: {e}")
413-
return dir_path, file_name
413+
raise
414414

415415
def get_powerpoint_presentation(self, dir_path: str, file_name: str) -> BytesIO:
416416
"""
@@ -465,7 +465,7 @@ def save_powerpoint_presentation(
465465
return dir_path, file_name
466466
except Exception as e:
467467
logger.error(f"Error saving PowerPoint presentation to {dir_path}: {e}")
468-
return dir_path, file_name
468+
raise
469469

470470
def get_pickle(self, dir_path: str, file_name: str) -> Any | None:
471471
"""
@@ -503,4 +503,4 @@ def save_pickle(
503503
return dir_path, file_name
504504
except Exception as e:
505505
logger.error(f"Error saving pickle to {dir_path}: {e}")
506-
return dir_path, file_name
506+
raise

0 commit comments

Comments
 (0)