Skip to content

Commit 8acf5c5

Browse files
authored
chore: remove hardcoded v1 from args & fix imagePullPolicy ref (#244)
1 parent 52f38d9 commit 8acf5c5

4 files changed

Lines changed: 15 additions & 12 deletions

File tree

charts/incubator/hyperswitch-web/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ description: |-
1212
assets
1313
1414
type: application
15-
version: 0.2.13
15+
version: 0.2.14
1616
appVersion: "0.126.0"

charts/incubator/hyperswitch-web/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# hyperswitch-web
22

3-
![Version: 0.2.13](https://img.shields.io/badge/Version-0.2.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.126.0](https://img.shields.io/badge/AppVersion-0.126.0-informational?style=flat-square)
3+
![Version: 0.2.14](https://img.shields.io/badge/Version-0.2.14-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.126.0](https://img.shields.io/badge/AppVersion-0.126.0-informational?style=flat-square)
44

55
Helm chart for Hyperswitch SDK static Server. This chart allow end user to deploy standalone
66
[SDK](https://github.com/juspay/hyperswitch-web) with different way:
@@ -15,8 +15,6 @@ assets
1515

1616
| Key | Type | Default | Description |
1717
|-----|------|---------|-------------|
18-
| autoBuild.buildImage | string | `"juspaydotin/hyperswitch-web"` | docker image to use for the build |
19-
| autoBuild.buildImageRegistry | string | `"docker.juspay.io"` | docker image registry for the build |
2018
| autoBuild.buildParam.disableCSP | string | `"false"` | |
2119
| autoBuild.buildParam.envBackendUrl | string | `"https://hyperswitch"` | node build parameter, hyperswitch server host |
2220
| autoBuild.buildParam.envLogsUrl | string | `"https://hyperswitch-sdk-logs"` | node build parameter, hyperswitch SDK logs host |
@@ -25,11 +23,14 @@ assets
2523
| autoBuild.forceBuild | bool | `false` | force rebuild assets even these files exist |
2624
| autoBuild.gitCloneParam.gitRepo | string | `"https://github.com/juspay/hyperswitch-web"` | hyperswitch-web repository |
2725
| autoBuild.gitCloneParam.gitVersion | string | `"0.126.0"` | hyperswitch-web repository tag |
28-
| autoBuild.nginxConfig.buildImageRegistry | string | `"docker.io"` | docker image registry for the build |
26+
| autoBuild.image | string | `"juspaydotin/hyperswitch-web"` | docker image to use for the build |
27+
| autoBuild.imageRegistry | string | `"docker.juspay.io"` | docker image registry for the build |
2928
| autoBuild.nginxConfig.extraPath | string | `"v1"` | nginx static server extra path ( like https://<host>/0.15.8/v0 ) |
3029
| autoBuild.nginxConfig.image | string | `"nginx"` | nginx static server image |
30+
| autoBuild.nginxConfig.imageRegistry | string | `"docker.io"` | docker image registry for the build |
3131
| autoBuild.nginxConfig.pullPolicy | string | `"IfNotPresent"` | nginx static server pull policy |
3232
| autoBuild.nginxConfig.tag | string | `"1.25.3"` | nginx static server tag |
33+
| autoBuild.pullPolicy | string | `"IfNotPresent"` | docker image pull policy |
3334
| env | object | `{"enableLogging":"false","sdkEnv":"sandbox","sdkTagVersion":"","sdkVersion":"v1","sentryDsn":"","visaApiCertificatePem":"","visaApiKeyId":""}` | Environment variables for hyperswitch-web application |
3435
| env.enableLogging | string | `"false"` | Enable/disable logging |
3536
| env.sdkEnv | string | `"sandbox"` | hyperswitch-web environment (sandbox/prod) |

charts/incubator/hyperswitch-web/templates/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ spec:
3232
{{- toYaml .Values.podSecurityContext | nindent 8 }}
3333
initContainers:
3434
- name: build-and-copy
35-
{{- $registry := .Values.global.imageRegistry | default .Values.autoBuild.buildImageRegistry }}
36-
image: "{{ $registry }}/{{ .Values.autoBuild.buildImage }}:v{{ .Values.autoBuild.gitCloneParam.gitVersion | default .Chart.AppVersion }}"
35+
{{- $registry := .Values.global.imageRegistry | default .Values.autoBuild.imageRegistry }}
36+
image: "{{ $registry }}/{{ .Values.autoBuild.image }}:v{{ .Values.autoBuild.gitCloneParam.gitVersion | default .Chart.AppVersion }}"
3737
imagePullPolicy: {{ .Values.autoBuild.pullPolicy }}
3838
command: ["/bin/sh", "-c"]
3939
args:
@@ -43,7 +43,7 @@ spec:
4343
npm run build:{{ .Values.env.sdkEnv }}
4444
echo "Copying built files to nginx path..."
4545
mkdir -p /usr/share/nginx/html{{ include "nginx.sdk.path" . }}
46-
cp -r /usr/src/app/dist/{{ .Values.env.sdkEnv }}/v1/* /usr/share/nginx/html{{ include "nginx.sdk.path" . }}
46+
cp -r /usr/src/app/dist/{{ .Values.env.sdkEnv }}/{{ include "hyperswitch-sdk.subversion" . }}/* /usr/share/nginx/html{{ include "nginx.sdk.path" . }}
4747
echo "Build and copy completed successfully"
4848
ls -la /usr/share/nginx/html{{ include "nginx.sdk.path" . }}
4949
env:
@@ -78,7 +78,7 @@ spec:
7878
- name: {{ .Chart.Name }}-nginx
7979
securityContext:
8080
{{- toYaml .Values.securityContext | nindent 12 }}
81-
{{- $registry := .Values.global.imageRegistry | default .Values.autoBuild.nginxConfig.buildImageRegistry }}
81+
{{- $registry := .Values.global.imageRegistry | default .Values.autoBuild.nginxConfig.imageRegistry }}
8282
image: "{{ $registry }}/{{ .Values.autoBuild.nginxConfig.image }}:{{ .Values.autoBuild.nginxConfig.tag }}"
8383
imagePullPolicy: {{ .Values.autoBuild.nginxConfig.pullPolicy }}
8484
ports:

charts/incubator/hyperswitch-web/values.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@ autoBuild:
4949
# -- force rebuild assets even these files exist
5050
forceBuild: false
5151
# -- docker image registry for the build
52-
buildImageRegistry: docker.juspay.io
52+
imageRegistry: docker.juspay.io
5353
# -- docker image to use for the build
54-
buildImage: juspaydotin/hyperswitch-web
54+
image: juspaydotin/hyperswitch-web
55+
# -- docker image pull policy
56+
pullPolicy: IfNotPresent
5557
gitCloneParam:
5658
# -- hyperswitch-web repository
5759
gitRepo: https://github.com/juspay/hyperswitch-web
@@ -68,7 +70,7 @@ autoBuild:
6870
disableCSP: "false"
6971
nginxConfig:
7072
# -- docker image registry for the build
71-
buildImageRegistry: docker.io
73+
imageRegistry: docker.io
7274
# -- nginx static server extra path ( like https://<host>/0.15.8/v0 )
7375
extraPath: v1
7476
# -- nginx static server image

0 commit comments

Comments
 (0)