Skip to content

Commit 974766c

Browse files
committed
fix(development-system): align component workflow routing
Route every verified green increment through its selected delivery checkpoint before ticket-terminal review, then reserve the final delivery handoff for unchanged exact-identity readiness. Closes: 20260901-xige
1 parent 4cd4f03 commit 974766c

1 file changed

Lines changed: 15 additions & 8 deletions

File tree

  • plugins/development-system/components/development-discipline/skills/development-workflow

plugins/development-system/components/development-discipline/skills/development-workflow/SKILL.md

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ still routes to `final-review`, even when that review itself is read-only.
5858
| Answer or review only | The relevant domain, documentation, security, OpenAI, or browser capability | The requested answer or review is complete; do not enter implementation without a change request |
5959
| Diagnose unexpected behavior | `systematic-debugging` | Evidence identifies the cause; implementation is separately requested or already in scope |
6060
| Prepare a substantive change | `change-preflight`, then `delivery-workflow` to select delivery mode and increment cadence | Every required surface has an evidence-backed decision and the delivery policy is known before preservation actions |
61-
| Implement a feature, fix, removal, or refactor | `test-driven-development` | RED is used when applicable; the current increment is verified and its lightweight review is clean |
62-
| Verify a completion claim | `verification-before-completion` | Fresh evidence covers the exact claim |
63-
| Review the completed change | `final-review` | The review coordinator reports completion for the current diff |
64-
| Choose commit and publication mode | `delivery-workflow`, plus `rationale-commit-messages` when a commit is authorized | Repository-selected delivery evidence is current |
61+
| Implement a feature, fix, removal, or refactor | `test-driven-development`, then the selected `delivery-workflow` checkpoint | RED is used when applicable; the increment is tested, lightly reviewed, gated, and delivered |
62+
| Verify a completion claim | `verification-before-completion` | Fresh evidence covers the exact increment or terminal claim |
63+
| Review the delivered completed change | `final-review` | All increments are delivered and the coordinator reports completion for that exact identity |
64+
| Choose commit and publication mode | `delivery-workflow`, plus `rationale-commit-messages` when a commit is authorized | The increment checkpoint or post-review exact-identity readiness evidence is current |
6565
| Create or update a PR or MR | `delivery-workflow` for authorization and mode, then the available forge capability | The PR/MR exists at the intended exact head and its URL and state are recorded |
6666
| Respond to a pushed CI failure | `ci-failure-follow-up` | A causal repair or unchanged-revision rerun reaches terminal success |
6767
| Respond to review feedback | `receiving-code-review`, then the applicable implementation and verification specialists | Valid feedback is resolved or technically defended |
@@ -70,7 +70,11 @@ still routes to `final-review`, even when that review itself is read-only.
7070
For ordinary implementation, the usual sequence is repository inspection,
7171
`change-preflight`, early `delivery-workflow` selection, one
7272
`test-driven-development` applicability decision and one increment at a time,
73-
`verification-before-completion`, `final-review`, and `delivery-workflow`.
73+
`verification-before-completion`, and the selected `delivery-workflow`
74+
checkpoint for every increment. Only after every planned increment is delivered
75+
does `final-review` inspect that exact identity; its clean result then returns to
76+
`delivery-workflow` solely for exact-identity readiness, not to manufacture a
77+
new commit or checkpoint.
7478
`rationale-commit-messages` governs each authorized commit. The selected
7579
delivery workflow governs whether work is committed, pushed directly, or sent
7680
through a PR/MR, and whether exact-revision CI must reach a terminal result.
@@ -94,16 +98,19 @@ Keep these boundaries explicit in both action and advisory responses:
9498

9599
- Start with current user direction, repository instructions, and mutable state
96100
before describing any commit or push. For a substantive change, select
97-
`delivery-workflow` before the first preservation action. After
98-
`final-review`, recheck `delivery-workflow` for final delivery.
101+
`delivery-workflow` before the first preservation action. Deliver every green
102+
increment through that selected mode before terminal `final-review`. After a
103+
clean terminal review, recheck `delivery-workflow` only for readiness of the
104+
unchanged reviewed identity.
99105
- For answer or domain-review work that is not a completed-diff final review,
100106
skip `change-preflight`,
101107
`test-driven-development`, `verification-before-completion`, `final-review`,
102108
`delivery-workflow`, `babysit-pr`, commits, pushes, PR/MR creation, and ticket
103109
creation unless a separate change request activates them.
104110
- After diagnosis identifies the cause, inspect state again, then route through
105111
`change-preflight`, early `delivery-workflow`, `test-driven-development`,
106-
`verification-before-completion`, and `final-review` for an authorized fix.
112+
`verification-before-completion`, checkpoint delivery, and—only when all
113+
planned work is delivered—`final-review` for an authorized fix.
107114
- Before creating or updating a PR/MR, inspect current repository state again,
108115
confirm PR/MR mode and authorization, select an available forge capability,
109116
and bind creation plus the recorded URL and state to the exact reviewed head.

0 commit comments

Comments
 (0)