Enforce parentheses on method calls with arguments

Style/MethodCallWithArgsParentheses is off by default, so the codebase
had drifted: JWT.encode payload, nil, alg next to JWT.encode(payload,
nil, alg), with the paren-less form concentrated in the older specs.

The RSpec matcher DSL is exempted, so expect(x).to eq(y) keeps reading
the way it is meant to rather than becoming expect(x).to(eq(y)).

The diff is rubocop -a output apart from five arrays in
readme_examples_spec, where adding parens pushed the elements out to a
36 column hanging indent; those are collapsed onto one line instead.
Switching Layout/FirstArrayElementIndentation to consistent would have
been the other way to fix them, but that restyles 14 places to fix 5.

Author: anakinj

.rubocop.yml

@@ -25,3 +25,14 @@ Gemspec/DevelopmentDependencies:
 
 Naming/PredicateMethod:
   Enabled: false
+
+Style/MethodCallWithArgsParentheses:
+  Enabled: true
+  AllowedMethods:
+    - to
+    - not_to
+    - to_not
+    - describe
+    - context
+    - it
+    - specify

lib/jwt/base64.rb

@@ -20,7 +20,7 @@ def url_decode(str)
       rescue ArgumentError => e
         raise unless e.message == 'invalid base64'
 
-        raise Base64DecodeError, 'Invalid base64 encoding'
+        raise(Base64DecodeError, 'Invalid base64 encoding')
       end
     end
   end

lib/jwt/claims/audience.rb

@@ -19,7 +19,7 @@ def initialize(expected_audience:)
       # @return [nil]
       def verify!(context:, **_args)
         aud = context.payload['aud']
-        raise JWT::InvalidAudError, "Invalid audience. Expected #{expected_audience}, received #{aud || '<none>'}" if ([*aud] & [*expected_audience]).empty?
+        raise(JWT::InvalidAudError, "Invalid audience. Expected #{expected_audience}, received #{aud || '<none>'}") if ([*aud] & [*expected_audience]).empty?
       end
 
       private

lib/jwt/claims/expiration.rb

@@ -21,7 +21,7 @@ def verify!(context:, **_args)
         return unless context.payload.is_a?(Hash)
         return unless context.payload.key?('exp')
 
-        raise JWT::ExpiredSignature, 'Signature has expired' if context.payload['exp'].to_i <= (Time.now.to_i - leeway)
+        raise(JWT::ExpiredSignature, 'Signature has expired') if context.payload['exp'].to_i <= (Time.now.to_i - leeway)
       end
 
       private

lib/jwt/claims/issuer.rb

@@ -22,7 +22,7 @@ def verify!(context:, **_args)
         when *issuers
           nil
         else
-          raise JWT::InvalidIssuerError, "Invalid issuer. Expected #{issuers}, received #{iss || '<none>'}"
+          raise(JWT::InvalidIssuerError, "Invalid issuer. Expected #{issuers}, received #{iss || '<none>'}")
         end
       end
 

lib/jwt/claims/not_before.rb

@@ -21,7 +21,7 @@ def verify!(context:, **_args)
         return unless context.payload.is_a?(Hash)
         return unless context.payload.key?('nbf')
 
-        raise JWT::ImmatureSignature, 'Signature nbf has not been reached' if context.payload['nbf'].to_i > (Time.now.to_i + leeway)
+        raise(JWT::ImmatureSignature, 'Signature nbf has not been reached') if context.payload['nbf'].to_i > (Time.now.to_i + leeway)
       end
 
       private

lib/jwt/claims/numeric.rb

@@ -38,7 +38,7 @@ def validate_is_numeric(payload, claim)
 
         return if payload[claim].is_a?(::Numeric) || payload[claim.to_s].is_a?(::Numeric)
 
-        raise InvalidPayload, "#{claim} claim must be a Numeric value but it is a #{(payload[claim] || payload[claim.to_s]).class}"
+        raise(InvalidPayload, "#{claim} claim must be a Numeric value but it is a #{(payload[claim] || payload[claim.to_s]).class}")
       end
     end
   end

lib/jwt/claims/required.rb

@@ -21,7 +21,7 @@ def verify!(context:, **_args)
         required_claims.each do |required_claim|
           next if context.payload.is_a?(Hash) && context.payload.key?(required_claim)
 
-          raise JWT::MissingRequiredClaim, "Missing required claim #{required_claim}"
+          raise(JWT::MissingRequiredClaim, "Missing required claim #{required_claim}")
         end
       end
 

lib/jwt/claims/verifier.rb

@@ -54,7 +54,7 @@ def iterate_verifiers(*options)
         end
 
         def verify_one!(context, verifier, options)
-          verifier_builder = VERIFIERS.fetch(verifier) { raise ArgumentError, "#{verifier} not a valid claim verifier" }
+          verifier_builder = VERIFIERS.fetch(verifier) { raise(ArgumentError, "#{verifier} not a valid claim verifier") }
           verifier_builder.call(options || {}).verify!(context: context)
         end
       end

lib/jwt/configuration/container.rb

@@ -42,7 +42,7 @@ def reset!
       # @raise [ArgumentError] if the value is not one of the supported values.
       # @return [void]
       def deprecation_warnings=(value)
-        raise ArgumentError, "Invalid deprecation_warnings value #{value}. Supported values: #{DEPRECATION_WARNINGS_VALUES}" unless DEPRECATION_WARNINGS_VALUES.include?(value)
+        raise(ArgumentError, "Invalid deprecation_warnings value #{value}. Supported values: #{DEPRECATION_WARNINGS_VALUES}") unless DEPRECATION_WARNINGS_VALUES.include?(value)
 
         @deprecation_warnings = value
       end