Skip to content

Commit 4f0c6fb

Browse files
MosheMaorKalturaCopilotravitshalem
authored
fix(SUP-51302): fix _setSrc() returning wrong promise causing iOS pla… (#869)
…yback failure Agent-Logs-Url: https://github.com/kaltura/playkit-js/sessions/30e0b578-2e66-46c0-938b-a8074c2a4592 ### Description of the Changes Please add a detailed description of the change, whether it's an enhancement or a bugfix. If the PR is related to an open issue please link to it. ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ravitshalem <31099969+ravitshalem@users.noreply.github.com>
1 parent a7faea9 commit 4f0c6fb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/engines/html5/media-source/adapters/native-adapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,8 @@ export default class NativeAdapter extends BaseMediaSourceAdapter {
488488
}
489489
}
490490
requestFilterPromise = requestFilterPromise || Promise.resolve(pkRequest);
491-
requestFilterPromise
491+
this._hlsManifestHandler.reset();
492+
return requestFilterPromise
492493
.then(updatedRequest => {
493494
return this._hlsManifestHandler.fetchManifestData(updatedRequest.url).then(() => {
494495
if (this._config.useSourceTag) {
@@ -532,7 +533,6 @@ export default class NativeAdapter extends BaseMediaSourceAdapter {
532533
.catch(error => {
533534
this._trigger(Html5EventType.ERROR, new Error(Error.Severity.CRITICAL, Error.Category.NETWORK, Error.Code.REQUEST_FILTER_ERROR, error));
534535
});
535-
return requestFilterPromise;
536536
}
537537

538538
/**

0 commit comments

Comments
 (0)