Refactor bytecode verifier and runtime components

- Change `code` parameter type from `&Vec<Bytecode>` to `&[Bytecode]` in `verify_fallthrough` function in control flow verifier.
- Update documentation formatting in `script_signature.rs` for clarity.
- Modify `native_sub_string` to directly use `s_str.as_bytes()` instead of creating a slice from `s_ref`.
- Replace conditional logic with `saturating_sub` for calculating `before` in the interpreter.
- Adjust vector-related bytecode verification logic for better readability and efficiency in `loader.rs`.
- Simplify error logging by removing unnecessary reference in `expect_no_verification_errors`.
- Optimize module iteration in `runtime.rs` by removing unnecessary `into_iter()` calls.
- Remove redundant `.write(true)` from logging file options.
- Enhance control flow documentation for better understanding.
- Add bits per second calculation in `DurationFormatter` for throughput metrics.
- Implement default trait for `ProcessTime` struct for improved usability.

Author: jamesatomc

third_party/move/Cargo.toml

@@ -21,119 +21,134 @@ members = [
     # "move-execution/$CUT/crates/move-vm-runtime",
     "move-execution/v0/crates/move-stdlib-natives",
     "move-execution/v1/crates/move-stdlib-natives",
-    "move-execution/v2/crates/move-stdlib-natives", "tools/criterion-cpu-time",
+    "move-execution/v2/crates/move-stdlib-natives",
+    "tools/criterion-cpu-time",
     # "move-execution/$CUT/crates/move-stdlib-natives",
 ]
 
 # Dependencies that should be kept in sync through the whole workspace
 [workspace.dependencies]
-aes-gcm = "0.8.0"
-anyhow = "1.0.52"
-arbitrary = { version = "1.1.7", features = ["derive", "derive_arbitrary"] }
-async-trait = "0.1.42"
-bcs = "0.1.4"
+aes-gcm = "0.10.3"
+anyhow = "1.0.102"
+arbitrary = { version = "1.4.2", features = ["derive", "derive_arbitrary"] }
+async-trait = "0.1.89"
+bcs = "0.2.1"
 better_any = { version = "0.2.1", features = ["derive"] }
-bitvec = "0.19.4"
-byteorder = "1.4.3"
-bytes = "1.0.1"
-chrono = "0.4.19"
-clap = { version = "4", features = ["derive"] }
-codespan = "0.11.1"
-codespan-reporting = "0.11.1"
-colored = "2.0.0"
-criterion = "0.6.0"
+bitvec = "1.0.1"
+byteorder = "1.5.0"
+bytes = "1.11.1"
+chrono = "0.4.45"
+clap = { version = "4.6.1", features = ["derive"] }
+codespan = "0.13.1"
+codespan-reporting = "0.13.1"
+colored = "3.1.1"
+criterion = "0.8.2"
 criterion-cpu-time = { path = "tools/criterion-cpu-time" }
-crossbeam = "0.8"
-crossbeam-channel = "0.5.0"
-crossterm = "0.25.0"
-curve25519-dalek = { version = "0.1.0", package = "curve25519-dalek-fiat", default-features = false, features = ["std", "u64_backend"] }
-datatest-stable = "0.1.1"
+crossbeam = "0.8.4"
+crossbeam-channel = "0.5.15"
+crossterm = "0.29.0"
+curve25519-dalek = { version = "0.1.0", package = "curve25519-dalek-fiat", default-features = false, features = [
+    "std",
+    "u64_backend",
+] }
+datatest-stable = "0.3.3"
 derivative = "2.2.0"
 difference = "2.0.0"
-digest = "0.9.0"
+digest = "0.11.3"
 dir-diff = "0.3.2"
 dirs-next = "2.0.0"
-dunce = "1.0.2"
-ed25519-dalek = { version = "0.1.0", package = "ed25519-dalek-fiat", default-features = false, features = ["std", "serde", "u64_backend"] }
-ethnum = "1.0.4"
-fail = "0.4.0"
+dunce = "1.0.5"
+ed25519-dalek = { version = "0.1.0", package = "ed25519-dalek-fiat", default-features = false, features = [
+    "std",
+    "serde",
+    "u64_backend",
+] }
+ethnum = "1.5.3"
+fail = "0.5.1"
 file_diff = "1.0.0"
-futures = "0.3.12"
-getrandom = "0.2.9"
-heck = "0.3.2"
+futures = "0.3.32"
+getrandom = "0.4.2"
+heck = "0.5.0"
 hex = "0.4.3"
-hex-literal = "0.3.4"
-hkdf = "0.10.0"
+hex-literal = "1.1.0"
+hkdf = "0.13.0"
 im = "15.1.0"
-internment = { version = "0.5.0", features = [ "arc"] }
-itertools = "0.10.0"
-leb128 = "0.2.5"
-libfuzzer-sys = "0.4"
-log = { version = "0.4.14", features = ["serde"] }
-lsp-server = "0.5.1"
-lsp-types = "0.90.1"
+internment = { version = "0.8.6", features = ["arc"] }
+itertools = "0.14.0"
+leb128 = "0.2.6"
+libfuzzer-sys = "0.4.13"
+log = { version = "0.4.32", features = ["serde"] }
+lsp-server = "0.7.9"
+lsp-types = "0.97.0"
 memory-stats = "1.0.0"
-mirai-annotations = "1.10.1"
-named-lock = "0.2.0"
-num = "0.4.0"
-num-bigint = "0.4.0"
-num_cpus = "1.13.0"
-once_cell = "1.7.2"
-ouroboros = "0.17.2"
-parking_lot = "0.11.1"
-paste = "1.0.5"
-petgraph = "0.5.1"
-phf = { version = "0.11", features = ["macros"] }
-plotters = { version = "0.3.0", default_features = false, features = ["evcxr", "line_series", "histogram"]}
-pretty = "0.10.0"
-prettydiff = "0.4.0"
-primitive-types = { version = "0.10.1", features = ["impl-serde"]}
-proc-macro2 = "1.0.24"
-proptest = "1.0.0"
-proptest-derive = "0.3.0"
-quote = "1.0.9"
-rand = "0.8.0"
-rayon = "1.5.0"
-ref-cast = "1.0.6"
-regex = "1.5.5"
-ripemd160 = "0.9.1"
-serde = { version = "1.0.124", features = ["derive"] }
-serde-name = "0.1.1"
-serde-reflection = "0.3.2"
-serde_bytes = "0.11.5"
-serde_json = "1.0.64"
-serde_yaml = "0.8.26"
-sha2 = "0.9.3"
-sha3 = "0.9.1"
+mirai-annotations = "1.12.0"
+named-lock = "0.4.1"
+num = "0.4.3"
+num-bigint = "0.4.6"
+num_cpus = "1.17.0"
+once_cell = "1.21.4"
+ouroboros = "0.18.5"
+parking_lot = "0.12.5"
+paste = "1.0.15"
+petgraph = "0.8.3"
+phf = { version = "0.13.1", features = ["macros"] }
+plotters = { version = "0.3.7", default_features = false, features = [
+    "evcxr",
+    "line_series",
+    "histogram",
+] }
+pretty = "0.12.5"
+prettydiff = "0.9.0"
+primitive-types = { version = "0.14.0", features = ["impl-serde"] }
+proc-macro2 = "1.0.106"
+proptest = "1.11.0"
+proptest-derive = "0.8.0"
+quote = "1.0.45"
+rand = "0.10.1"
+rayon = "1.12.0"
+ref-cast = "1.0.25"
+regex = "1.12.4"
+ripemd = "0.2.0"
+serde = { version = "1.0.228", features = ["derive"] }
+serde-name = "0.3.0"
+serde-reflection = "0.6.0"
+serde_bytes = "0.11.19"
+serde_json = "1.0.150"
+serde_yaml = "=0.9.34"
+sha2 = "0.11.0"
+sha3 = "0.12.0"
 shell-words = "1.0.0"
-simplelog = "0.9.0"
-similar = "2.4.0"
-smallvec = "1.6.1"
-stacker = "0.1.15"
+simplelog = "0.12.2"
+similar = "=3.1.1"
+smallvec = "1.15.2"
+stacker = "0.1.24"
 static_assertions = "1.1.0"
-syn = { version = "1.0.64", features = ["derive"] }
-tempfile = "3.2.0"
-tera = "1.16.0"
-thiserror = "1.0.24"
+syn = { version = "2.0.117", features = ["derive"] }
+tempfile = "3.27.0"
+tera = "1.20.1"
+thiserror = "2.0.18"
 tiny-keccak = { version = "2.0.2", features = ["sha3"] }
-tokio = { version = "1.18.2", features = ["full"] }
-toml = "0.5.8"
-toml_edit =  { version = "0.14.3", features = ["easy"] }
-tracing = "0.1.26"
+tokio = { version = "1.52.3", features = ["full"] }
+toml = "1.1.2"
+toml_edit = { version = "0.25.12"}
+tracing = "0.1.44"
 tracing-subscriber = { version = "0.3.15", features = ["env-filter"] }
 treeline = "0.1.0"
 tui = "0.19.0"
-uint = "0.9.4"
+uint = "0.10.0"
 url = "2.2.2"
 variant_count = "1.1.0"
-vfs = "0.10.0"
-walkdir = "2.3.1"
-whoami = { version = "1.2.1" }
-x25519-dalek = { version = "0.1.0", package = "x25519-dalek-fiat", default-features = false, features = ["std", "u64_backend"] }
-z3tracer = "0.8.0"
+vfs = "0.13.0"
+walkdir = "2.5.0"
+whoami = { version = "2.1.2" }
+x25519-dalek = { version = "0.1.0", package = "x25519-dalek-fiat", default-features = false, features = [
+    "std",
+    "u64_backend",
+] }
+z3tracer = "0.11.2"
 
 bytecode-interpreter-crypto = { path = "crates/bytecode-interpreter-crypto" }
-enum-compat-util = { path = "crates/enum-compat-util"}
+enum-compat-util = { path = "crates/enum-compat-util" }
 invalid-mutations = { path = "crates/invalid-mutations" }
 module-generation = { path = "crates/module-generation" }
 move-abstract-stack = { path = "crates/move-abstract-stack" }
@@ -158,7 +173,7 @@ move-ir-to-bytecode-syntax = { path = "crates/move-ir-to-bytecode-syntax" }
 move-ir-types = { path = "crates/move-ir-types" }
 move-model = { path = "crates/move-model" }
 move-package = { path = "crates/move-package" }
-move-proc-macros = { path = "crates/move-proc-macros"}
+move-proc-macros = { path = "crates/move-proc-macros" }
 move-prover = { path = "crates/move-prover" }
 move-prover-test-utils = { path = "crates/move-prover-test-utils" }
 move-read-write-set-types = { path = "crates/move-read-write-set-types" }
@@ -174,7 +189,7 @@ move-vm-profiler = { path = "crates/move-vm-profiler" }
 move-vm-runtime = { path = "crates/move-vm-runtime" }
 move-vm-test-utils = { path = "crates/move-vm-test-utils" }
 move-vm-types = { path = "crates/move-vm-types" }
-prover_bytecode = { path = "crates/move-stackless-bytecode", package="move-stackless-bytecode" }
+prover_bytecode = { path = "crates/move-stackless-bytecode", package = "move-stackless-bytecode" }
 
 [profile.bench]
 debug = true
@@ -190,6 +205,6 @@ opt-level = 3
 # use release settings to reduce memory pressure in the linking step in CI
 [profile.ci]
 inherits = "test"
-debug = 0 # for saving disk space during linking
+debug = 0           # for saving disk space during linking
 incremental = false
 codegen-units = 16

third_party/move/clippy.toml

@@ -0,0 +1,4 @@
+too-many-arguments-threshold = 13
+type-complexity-threshold = 1000
+enum-variant-size-threshold = 1024
+large-error-threshold = 1024

third_party/move/crates/bytecode-interpreter-crypto/Cargo.toml

@@ -3,7 +3,7 @@ name = "bytecode-interpreter-crypto"
 version = "0.1.0"
 authors = ["Diem Association <opensource@diem.com>"]
 publish = false
-edition = "2021"
+edition = "2024"
 license = "Apache-2.0"
 
 [dependencies]

third_party/move/crates/bytecode-interpreter-crypto/src/lib.rs

@@ -12,10 +12,10 @@
 //! diem-framework) and be passed into the VM for execution. In this way we no
 //! longer need to worry about depending on diem-crypto.
 
-use anyhow::{bail, Result};
+use anyhow::{Result, bail};
 use ed25519_dalek::{
-    PublicKey as Ed25519PublicKey, Signature as Ed25519Signature,
-    PUBLIC_KEY_LENGTH as ED25519_PUBLIC_KEY_LENGTH, SIGNATURE_LENGTH as ED25519_SIGNATURE_LENGTH,
+    PUBLIC_KEY_LENGTH as ED25519_PUBLIC_KEY_LENGTH, PublicKey as Ed25519PublicKey,
+    SIGNATURE_LENGTH as ED25519_SIGNATURE_LENGTH, Signature as Ed25519Signature,
 };
 use sha2::{Digest, Sha256};
 use sha3::Sha3_256;

third_party/move/crates/bytecode-interpreter-testsuite/Cargo.toml

@@ -3,7 +3,7 @@ name = "bytecode-interpreter-testsuite"
 version = "0.1.0"
 authors = ["Diem Association <opensource@diem.com>"]
 publish = false
-edition = "2021"
+edition = "2024"
 license = "Apache-2.0"
 
 [dev-dependencies]

third_party/move/crates/bytecode-interpreter-testsuite/tests/concrete_check_testsuite.rs

@@ -10,7 +10,7 @@ use move_stdlib::move_stdlib_files;
 use move_unit_test::UnitTestingConfig;
 
 fn test_runner(path: &Path) -> datatest_stable::Result<()> {
-    env::set_var("NO_COLOR", "1");
+    unsafe { env::set_var("NO_COLOR", "1") };
 
     let source_files = vec![path.to_str().unwrap().to_owned()];
     let config = UnitTestingConfig {
@@ -37,4 +37,6 @@ fn test_runner(path: &Path) -> datatest_stable::Result<()> {
     Ok(())
 }
 
-datatest_stable::harness!(test_runner, "tests/concrete_check", r".*\.move$");
+datatest_stable::harness! {
+    { test = test_runner, root = "tests/concrete_check", pattern = r".*\.move$" },
+}

third_party/move/crates/bytecode-verifier-libfuzzer/Cargo.toml

@@ -4,7 +4,7 @@ version = "0.0.0"
 authors = ["Diem Association <opensource@diem.com>"]
 license = "Apache-2.0"
 publish = false
-edition = "2018"
+edition = "2024"
 
 [package.metadata]
 cargo-fuzz = true

third_party/move/crates/bytecode-verifier-libfuzzer/fuzz_targets/code_unit.rs

@@ -3,22 +3,21 @@
 
 #![no_main]
 use move_binary_format::file_format::{
-    empty_module, AbilitySet, CodeUnit, Constant, FieldDefinition, FunctionDefinition,
-    FunctionHandle, FunctionHandleIndex, IdentifierIndex, ModuleHandleIndex, Signature,
-    SignatureIndex,
-    SignatureToken::{Address, Bool, U128, U64},
+    AbilitySet, CodeUnit, Constant, FieldDefinition, FunctionDefinition, FunctionHandle,
+    FunctionHandleIndex, IdentifierIndex, ModuleHandleIndex, Signature, SignatureIndex,
+    SignatureToken::{Address, Bool, U64, U128},
     StructDefinition, StructFieldInformation, StructHandle, StructHandleIndex, TypeSignature,
-    Visibility,
+    Visibility, empty_module,
 };
 use move_core_types::{account_address::AccountAddress, identifier::Identifier};
 use std::str::FromStr;
 
 use libfuzzer_sys::fuzz_target;
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn main() -> i32 {
     libfuzzer_sys::initialize(std::ptr::null(), std::ptr::null());
-    return 0;
+    0
 }
 
 fuzz_target!(|code_unit: CodeUnit| {

third_party/move/crates/bytecode-verifier-libfuzzer/fuzz_targets/compiled_module.rs

@@ -5,10 +5,10 @@
 use libfuzzer_sys::fuzz_target;
 use move_binary_format::file_format::CompiledModule;
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn main() -> i32 {
     libfuzzer_sys::initialize(std::ptr::null(), std::ptr::null());
-    return 0;
+    0
 }
 
 fuzz_target!(|module: CompiledModule| {

third_party/move/crates/bytecode-verifier-libfuzzer/fuzz_targets/mixed.rs

@@ -3,12 +3,12 @@
 
 #![no_main]
 use move_binary_format::file_format::{
-    empty_module, AbilitySet, Bytecode, CodeUnit, Constant, FieldDefinition, FunctionDefinition,
-    FunctionHandle, FunctionHandleIndex, IdentifierIndex, ModuleHandleIndex, Signature,
-    SignatureIndex, SignatureToken,
+    AbilitySet, Bytecode, CodeUnit, Constant, FieldDefinition, FunctionDefinition, FunctionHandle,
+    FunctionHandleIndex, IdentifierIndex, ModuleHandleIndex, Signature, SignatureIndex,
+    SignatureToken,
     SignatureToken::{Address, Bool},
     StructDefinition, StructFieldInformation, StructHandle, StructHandleIndex, TypeSignature,
-    Visibility,
+    Visibility, empty_module,
 };
 use move_core_types::{account_address::AccountAddress, identifier::Identifier};
 use std::str::FromStr;
@@ -24,10 +24,10 @@ struct Mixed {
     return_type: Option<SignatureToken>,
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub extern "C" fn main() -> i32 {
     libfuzzer_sys::initialize(std::ptr::null(), std::ptr::null());
-    return 0;
+    0
 }
 
 fuzz_target!(|mix: Mixed| {