Enable and fix first-party compilation warnings.

Author: LTLA

CMakeLists.txt

@@ -71,6 +71,9 @@ target_compile_options(
     scran_wasm PUBLIC 
     -O3
     -pthread
+    -Wall
+    -Wpedantic
+    -Wextra
     -sMEMORY64
 )
 

src/model_gene_variances.cpp

@@ -15,7 +15,8 @@ class ModelGeneVariancesResults {
     scran_variances::ModelGeneVariancesBlockedResults<double> my_store_blocked;
 
 public:
-    ModelGeneVariancesResults(scran_variances::ModelGeneVariancesResults<double> store) : my_store_unblocked(std::move(store)), my_use_blocked(false) {}
+    ModelGeneVariancesResults(scran_variances::ModelGeneVariancesResults<double> store) : my_use_blocked(false), my_store_unblocked(std::move(store)) {}
+
     ModelGeneVariancesResults(scran_variances::ModelGeneVariancesBlockedResults<double> store) : my_store_blocked(std::move(store)) {}
 
 private:

src/quality_control_adt.cpp

@@ -58,7 +58,7 @@ class SuggestAdtQcFiltersResults {
     scran_qc::AdtQcBlockedFilters<double> my_store_blocked;
 
 public:
-    SuggestAdtQcFiltersResults(scran_qc::AdtQcFilters<double> store) : my_store_unblocked(std::move(store)), my_use_blocked(false) {}
+    SuggestAdtQcFiltersResults(scran_qc::AdtQcFilters<double> store) : my_use_blocked(false), my_store_unblocked(std::move(store)) {}
 
     SuggestAdtQcFiltersResults(scran_qc::AdtQcBlockedFilters<double> store) : my_store_blocked(std::move(store)) {}
 

src/quality_control_crispr.cpp

@@ -57,7 +57,7 @@ class SuggestCrisprQcFiltersResults {
     scran_qc::CrisprQcBlockedFilters<double> my_store_blocked;
 
 public:
-    SuggestCrisprQcFiltersResults(scran_qc::CrisprQcFilters<double> store) : my_store_unblocked(std::move(store)), my_use_blocked(false) {}
+    SuggestCrisprQcFiltersResults(scran_qc::CrisprQcFilters<double> store) : my_use_blocked(false), my_store_unblocked(std::move(store)) {}
 
     SuggestCrisprQcFiltersResults(scran_qc::CrisprQcBlockedFilters<double> store) : my_store_blocked(std::move(store)) {}
 

src/quality_control_rna.cpp

@@ -58,7 +58,7 @@ class SuggestRnaQcFiltersResults {
     scran_qc::RnaQcBlockedFilters<double> my_store_blocked;
 
 public:
-    SuggestRnaQcFiltersResults(scran_qc::RnaQcFilters<double> store) : my_store_unblocked(std::move(store)), my_use_blocked(false) {}
+    SuggestRnaQcFiltersResults(scran_qc::RnaQcFilters<double> store) : my_use_blocked(false), my_store_unblocked(std::move(store)) {}
 
     SuggestRnaQcFiltersResults(scran_qc::RnaQcBlockedFilters<double> store) : my_store_blocked(std::move(store)) {}
 

src/run_pca.cpp

@@ -17,11 +17,10 @@ class PcaResults {
     scran_pca::BlockedPcaResults<Eigen::MatrixXd, Eigen::VectorXd> my_store_blocked;
 
 public:
-    PcaResults(scran_pca::SimplePcaResults<Eigen::MatrixXd, Eigen::VectorXd> store) : my_store_unblocked(std::move(store)), my_use_blocked(false) {}
+    PcaResults(scran_pca::SimplePcaResults<Eigen::MatrixXd, Eigen::VectorXd> store) : my_use_blocked(false), my_store_unblocked(std::move(store)) {}
 
     PcaResults(scran_pca::BlockedPcaResults<Eigen::MatrixXd, Eigen::VectorXd> store) : my_store_blocked(std::move(store)) {}
 
-
 private:
     static emscripten::val format_matrix(const Eigen::MatrixXd& mat) {
         auto len = sanisizer::product_unsafe<std::size_t>(mat.rows(), mat.cols());
@@ -102,7 +101,6 @@ PcaResults run_pca(
     }
 
     auto ptr = mat.ptr();
-    const auto NC = ptr->ncol();
     const auto NR = ptr->nrow();
 
     if (use_subset) {