tests: misc: dtdoctor: cover cell errors end to end

Give the fixture devicetree a GPIO controller carrying real 'pin'/'flags' cells
and a consumer that uses them, then check a bad cell, index and name against the
build's real edt.pickle, and run the bad-cell shape through the wrapper with the
toolchain the application was built with.

The consumer's property is 'dtdoctor-gpios' while its names come from
'gpio-names', so the fixture also pins the specifier-space naming rule rather
than just asserting it in a unit test.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NS18GhZ19Qeb67QoRkCu7K

Author: claude

tests/misc/dtdoctor/app.overlay

@@ -12,6 +12,11 @@
  *
  * The two nodes also give the compatible two DT_INST() instances, which is
  * what the DT_INST()/DT_DRV_COMPAT diagnosis reports on.
+ *
+ * dtdoctor_gpio carries the cells ('pin' and 'flags') that the specifier
+ * diagnosis has to find, which live in the controller's binding rather than
+ * in the consumer's. Note that 'dtdoctor-gpios' entries are named through
+ * 'gpio-names': names are keyed by the specifier space, not by the property.
  */
 / {
 	chosen {
@@ -27,9 +32,17 @@
 		status = "disabled";
 	};
 
+	dtdoctor_gpio: dtdoctor-gpio-controller {
+		compatible = "vnd,dtdoctor-gpio";
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	dtdoctor_enabled: dtdoctor-enabled-device {
 		compatible = "vnd,dtdoctor-device";
 		dtdoctor-speed = <115200>;
+		dtdoctor-gpios = <&dtdoctor_gpio 13 1>;
+		gpio-names = "red";
 		status = "okay";
 	};
 };

tests/misc/dtdoctor/dts/bindings/vnd,dtdoctor-device.yaml

@@ -12,3 +12,8 @@ properties:
   dtdoctor-optional:
     type: int
     description: declared here but never set, and with no default
+  dtdoctor-gpios:
+    type: phandle-array
+    description: specifier space for the cell diagnoses
+  gpio-names:
+    type: string-array

tests/misc/dtdoctor/dts/bindings/vnd,dtdoctor-gpio.yaml

@@ -0,0 +1,18 @@
+# SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors
+# SPDX-License-Identifier: Apache-2.0
+
+description: Fake GPIO controller, used by the DT Doctor integration test
+
+compatible: "vnd,dtdoctor-gpio"
+
+gpio-cells:
+  - pin
+  - flags
+
+properties:
+  gpio-controller:
+    type: boolean
+    required: true
+  "#gpio-cells":
+    type: int
+    required: true

tests/misc/dtdoctor/verify_dtdoctor.py

@@ -96,13 +96,36 @@ def test_analyzer_reports_enabled_node_without_driver(edt, edt_pickle):
         device_symbol("DT_N_INST_0_vnd_no_such_compat"),
         "No node with compatible 'vnd_no_such_compat' exists",
     ),
+    (
+        "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_IDX_0_VAL_pn",
+        "has no 'pn' cell in entry 0 of the 'dtdoctor-gpios' property",
+    ),
+    (
+        "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_IDX_4_VAL_pin",
+        "has no entry 4 in the 'dtdoctor-gpios' property: there is only 1",
+    ),
+    (
+        "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_NAME_blue_VAL_pin",
+        "has no entry named 'blue' in the 'dtdoctor-gpios' property",
+    ),
 ]
 
 
 @pytest.mark.parametrize(
     'symbol, expected',
     TESTDATA_MACROS,
-    ids=['nodelabel', 'alias', 'chosen', 'property', 'unset-property', 'instance', 'compatible'],
+    ids=[
+        'nodelabel',
+        'alias',
+        'chosen',
+        'property',
+        'unset-property',
+        'instance',
+        'compatible',
+        'cell',
+        'cell-index',
+        'cell-name',
+    ],
 )
 def test_analyzer_reverse_engineers_macro(edt_pickle, symbol, expected):
     proc = run_analyzer(edt_pickle, symbol)
@@ -111,6 +134,26 @@ def test_analyzer_reverse_engineers_macro(edt_pickle, symbol, expected):
     assert expected in proc.stdout
 
 
+def test_analyzer_names_the_cell_controller(edt_pickle):
+    # The cells come from the controller's binding, not from the node the macro names,
+    # which is the indirection the diagnosis exists to spare the user
+    proc = run_analyzer(edt_pickle, "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_IDX_0_VAL_pn")
+    assert proc.returncode == 0
+    assert "dtdoctor_gpio: /dtdoctor-gpio-controller" in proc.stdout
+    assert " - pin" in proc.stdout
+    assert "vnd,dtdoctor-gpio.yaml" in proc.stdout
+
+
+def test_analyzer_uses_the_specifier_space_for_names(edt_pickle):
+    # 'dtdoctor-gpios' entries are named through 'gpio-names', not 'dtdoctor-gpio-names'
+    proc = run_analyzer(
+        edt_pickle, "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_NAME_blue_VAL_pin"
+    )
+    assert proc.returncode == 0
+    assert "Entry names come from its 'gpio-names' property:" in proc.stdout
+    assert " - red" in proc.stdout
+
+
 def test_analyzer_suggests_a_real_nodelabel(edt_pickle):
     # A near miss on a label that does exist has to come back as a suggestion
     proc = run_analyzer(edt_pickle, device_symbol("DT_N_NODELABEL_dtdoctor_enabld"))
@@ -155,13 +198,17 @@ def test_wrapper_diagnoses_compile_error(edt, edt_pickle, cc, tmp_path, template
         device_symbol("DT_N_INST_5_vnd_dtdoctor_device"),
         "so instance 5 does not exist",
     ),
+    (
+        "DT_N_NODELABEL_dtdoctor_enabled_P_dtdoctor_gpios_IDX_0_VAL_pn",
+        "has no 'pn' cell in entry 0",
+    ),
 ]
 
 
 @pytest.mark.parametrize(
     'symbol, expected',
     TESTDATA_WRAPPER_MACROS,
-    ids=['nodelabel', 'property', 'instance'],
+    ids=['nodelabel', 'property', 'instance', 'cell'],
 )
 def test_wrapper_diagnoses_unexpanded_macro(edt_pickle, cc, tmp_path, symbol, expected):
     # The whole point of these shapes is that they reach the compiler unexpanded, so the