data_structures dependency update

Author: ermvrs

Scarb.lock

@@ -19,9 +19,6 @@ dependencies = [
 [[package]]
 name = "alexandria_data_structures"
 version = "0.2.0"
-dependencies = [
- "alexandria_encoding",
-]
 
 [[package]]
 name = "alexandria_encoding"

packages/data_structures/Scarb.toml

@@ -8,8 +8,5 @@ edition = "2023_11"
 [tool]
 fmt.workspace = true
 
-[dependencies]
-alexandria_encoding = { path = "../encoding", version = "0.2.0" }
-
 [dev-dependencies]
 cairo_test.workspace = true

packages/data_structures/src/byte_appender.cairo

@@ -1,6 +1,7 @@
-use alexandria_encoding::reversible::reversing;
 use core::byte_array::ByteArrayTrait;
 use core::integer::u512;
+use core::num::traits::Zero;
+use core::ops::{MulAssign, AddAssign};
 use super::bit_array::{one_shift_left_bytes_felt252, one_shift_left_bytes_u128};
 
 /// Generic support trait for appending signed and unsigned integers onto byte storage.
@@ -284,3 +285,46 @@ impl ByteAppenderImpl<T, +Drop<T>, +ByteAppenderSupportTrait<T>> of ByteAppender
 
 impl ArrayU8ByteAppenderImpl = ByteAppenderImpl<Array<u8>>;
 impl ByteArrayByteAppenderImpl = ByteAppenderImpl<ByteArray>;
+
+
+#[inline]
+pub fn reversing<
+    T,
+    +Copy<T>,
+    +Zero<T>,
+    +TryInto<T, NonZero<T>>,
+    +DivRem<T>,
+    +Drop<T>,
+    +MulAssign<T, T>,
+    +Rem<T>,
+    +AddAssign<T, T>
+>(
+    word: T, size: usize, step: T
+) -> (T, T) {
+    let result = Zero::zero();
+    reversing_partial_result(word, result, size, step)
+}
+
+#[inline]
+pub fn reversing_partial_result<
+    T,
+    +Copy<T>,
+    +DivRem<T>,
+    +TryInto<T, NonZero<T>>,
+    +Drop<T>,
+    +MulAssign<T, T>,
+    +Rem<T>,
+    +AddAssign<T, T>
+>(
+    mut word: T, mut onto: T, size: usize, step: T
+) -> (T, T) {
+    let mut i: usize = 0;
+    while i != size {
+        let (new_word, remainder) = DivRem::div_rem(word, step.try_into().unwrap());
+        word = new_word;
+        onto *= step.into();
+        onto += remainder;
+        i += 1;
+    };
+    (onto, word)
+}

packages/encoding/src/reversible.cairo

@@ -23,6 +23,7 @@ pub trait ReversibleBits<T> {
     fn reverse_bits(self: @T) -> T;
 }
 
+// [Erim]: Duplicated function in data_structures::byte_appender. Use that one for package management
 #[inline]
 pub fn reversing<
     T,