Skip to content

Commit 59d9679

Browse files
committed
address comments
1 parent c7d9d51 commit 59d9679

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/layers/src/arc-layer/arc-layer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ export default class ArcLayer extends Layer {
314314
lat1: fieldPairs[1].pair.lat,
315315
lng1: fieldPairs[1].pair.lng
316316
},
317-
label: `${fieldPairs[0].defaultName} -> ${fieldPairs[1].defaultName} arc`
317+
label: `${fieldPairs[0].defaultName || 'point'} -> ${fieldPairs[1].defaultName || 'point'} arc`
318318
};
319319

320320
return {props: [props]};

src/layers/src/line-layer/line-layer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ export default class LineLayer extends ArcLayer {
260260
geoarrow0: {...defaultAltColumn},
261261
geoarrow1: {...defaultAltColumn}
262262
},
263-
label: `${fieldPairs[0].defaultName} -> ${fieldPairs[1].defaultName} line`,
263+
label: `${fieldPairs[0].defaultName || 'point'} -> ${fieldPairs[1].defaultName || 'point'} line`,
264264
isVisible: false
265265
};
266266

test/node/utils/kepler-table-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ test('KeplerTable -> findPointFieldPairs', t => {
278278
suffix: ['lat', 'lng']
279279
},
280280
{
281-
defaultName: 'point',
281+
defaultName: '',
282282
pair: {
283283
lat: {
284284
fieldIdx: 3,
@@ -343,7 +343,7 @@ test('KeplerTable -> findPointFieldPairs', t => {
343343
suffix: ['lat', 'long']
344344
},
345345
{
346-
defaultName: 'point',
346+
defaultName: '',
347347
pair: {
348348
lat: {
349349
fieldIdx: 3,

0 commit comments

Comments
 (0)