fixes

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

Author: ilyabo

src/components/src/hooks/use-legend-position.ts

@@ -172,22 +172,11 @@ export default function useLegendPosition({
     }
   }, [isSidePanelShown, onChangeSettings, sidePanelWidth]);
 
-  // Clamp position when map resizes to ensure legend stays within viewport
+  // Clamp contentHeight when map resizes to ensure legend stays within available space
   useEffect(() => {
     if (!mapWidth || !mapHeight || !legendContentRef.current) return;
-
-    const currentPos = posRef.current;
-
-    let needsUpdate = false;
-    const newPos = {...currentPos};
-    // Clamp contentHeight if it exceeds available space
     if (maxContentHeight && contentHeight > 0 && contentHeight > maxContentHeight) {
       onChangeSettings({contentHeight: maxContentHeight});
-      needsUpdate = true;
-    }
-
-    if (needsUpdate) {
-      onChangeSettings({position: newPos});
     }
   }, [mapWidth, mapHeight, contentHeight, onChangeSettings, maxContentHeight]);
 

test/browser/components/hooks/use-legend-position.spec.js

@@ -57,7 +57,7 @@ describe('useLegendPosition', () => {
     expect(positionStyles).toEqual({left: 100, top: 200});
   });
 
-  test('should calculate maxContentHeight from mapRootDimensions', () => {
+  test('should calculate maxContentHeight from mapWidth and mapHeight', () => {
     const {
       result: {
         current: {maxContentHeight}
@@ -69,15 +69,16 @@ describe('useLegendPosition', () => {
         settings: {},
         onChangeSettings: jest.fn(),
         theme: THEME,
-        mapRootDimensions: {width: 800, height: 600}
+        mapHeight: 600,
+        mapWidth: 800
       })
     );
     // maxContentHeight = height - MARGIN.top - MARGIN.bottom - MAP_CONTROL_HEADER_FULL_HEIGHT
     // = 600 - 10 - 30 - 34 = 526
     expect(maxContentHeight).toBe(526);
   });
 
-  test('should return undefined maxContentHeight when mapRootDimensions not provided', () => {
+  test('should return undefined maxContentHeight when mapWidth and mapHeight not provided', () => {
     const {
       result: {
         current: {maxContentHeight}
@@ -116,7 +117,8 @@ describe('useLegendPosition', () => {
         },
         onChangeSettings,
         theme: THEME,
-        mapRootDimensions: {width: 800, height: 600}
+        mapHeight: 600,
+        mapWidth: 800
       })
     );