Skip to content

Commit e59a1bd

Browse files
committed
nebula to deckglcommunity/editable layers
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
1 parent 0f91aa8 commit e59a1bd

13 files changed

Lines changed: 465 additions & 538 deletions

File tree

examples/demo-app/esbuild.config.mjs

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -124,35 +124,6 @@ const config = {
124124
]
125125
};
126126

127-
// Create compatibility plugin function
128-
const createLumaGlCompatPlugin = useKeplerNodeModules => ({
129-
name: 'luma-gl-compat',
130-
setup(build) {
131-
// Intercept imports from @nebula.gl/layers that import from @luma.gl/core
132-
build.onResolve({filter: /^@luma\.gl\/core$/}, args => {
133-
// Only redirect if the import is coming from @nebula.gl/layers
134-
if (args.importer && args.importer.includes('@nebula.gl/layers')) {
135-
// Always use our compatibility shim when importing from @nebula.gl/layers
136-
// The shim re-exports everything from @luma.gl/core plus Geometry from @luma.gl/engine
137-
if (useKeplerNodeModules) {
138-
return {
139-
path: resolve(__dirname, SRC_DIR, 'compat/luma-gl-compat.ts'),
140-
namespace: 'file'
141-
};
142-
} else {
143-
// When not using kepler node modules, we need to resolve to the shim in the root
144-
// LIB_DIR is relative to examples/demo-app, so resolve from config file directory
145-
return {
146-
path: resolve(__dirname, LIB_DIR, 'src/compat/luma-gl-compat.ts'),
147-
namespace: 'file'
148-
};
149-
}
150-
}
151-
// Return undefined to let esbuild handle the import normally for other cases
152-
return undefined;
153-
});
154-
}
155-
});
156127

157128
function addAliases(externals, args) {
158129
const resolveAlias = getThirdPartyLibraryAliases(true);
@@ -312,7 +283,6 @@ function openURL(url) {
312283
// Optionally generate a bundle analysis
313284
plugins: [
314285
...config.plugins,
315-
createLumaGlCompatPlugin(true),
316286
{
317287
name: 'bundle-analyzer',
318288
setup(build) {
@@ -344,7 +314,7 @@ function openURL(url) {
344314
sourcemap: true,
345315
// add alias to resolve libraries so there is only one copy of them
346316
...(useKeplerModules ? {alias: localAliases} : {alias: getThirdPartyLibraryAliases(false)}),
347-
plugins: [...config.plugins, createLumaGlCompatPlugin(useKeplerModules)],
317+
plugins: [...config.plugins],
348318
banner: {
349319
js: `new EventSource('/esbuild').addEventListener('change', () => location.reload());`
350320
}

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,11 @@
134134
"@babel/runtime": "^7.12.1",
135135
"@babel/traverse": "^7.12.1",
136136
"@cfaester/enzyme-adapter-react-18": "^0.7.0",
137+
"@deck.gl-community/editable-layers": "9.1.1",
138+
"@deck.gl-community/layers": "9.1.1",
137139
"@deck.gl/test-utils": "^9.2.0",
138140
"@loaders.gl/polyfills": "^4.3.2",
139141
"@luma.gl/test-utils": "^9.2.0",
140-
"@nebula.gl/layers": "1.0.2-alpha.1",
141142
"@open-wc/webpack-import-meta-loader": "0.4.7",
142143
"@probe.gl/env": "^3.5.0",
143144
"@probe.gl/test-utils": "^3.5.0",

src/compat/luma-gl-compat.ts

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/components/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
"umd"
3131
],
3232
"dependencies": {
33+
"@deck.gl-community/editable-layers": "9.1.1",
34+
"@deck.gl-community/layers": "9.1.1",
3335
"@deck.gl/core": "^9.2.0",
3436
"@deck.gl/react": "^9.2.0",
3537
"@deck.gl/widgets": "^9.2.0",
@@ -57,7 +59,6 @@
5759
"@loaders.gl/pmtiles": "^4.3.2",
5860
"@loaders.gl/wms": "4.3.2",
5961
"@mapbox/mapbox-sdk": "^0.15.3",
60-
"@nebula.gl/edit-modes": "1.0.2-alpha.1",
6162
"@tippyjs/react": "^4.2.0",
6263
"@types/classnames": "^2.3.1",
6364
"@types/d3-array": "^2.8.0",

src/components/src/editor/editor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
} from '@kepler.gl/constants';
1919
import {Layer, EditorLayerUtils} from '@kepler.gl/layers';
2020
import {Filter, FeatureSelectionContext, Feature} from '@kepler.gl/types';
21-
import {FeatureOf, Polygon} from '@nebula.gl/edit-modes';
21+
import {FeatureOf, Polygon} from '@deck.gl-community/editable-layers';
2222
import {Datasets} from '@kepler.gl/table';
2323

2424
import {RootContext} from '../context';

src/components/src/editor/feature-action-panel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import styled from 'styled-components';
1010

1111
import {Layer} from '@kepler.gl/layers';
1212
import {Filter} from '@kepler.gl/types';
13-
import {Feature} from '@nebula.gl/edit-modes';
13+
import {Feature} from '@deck.gl-community/editable-layers';
1414
import {Datasets} from '@kepler.gl/table';
1515
import {canApplyFeatureFilter} from '@kepler.gl/utils';
1616

src/layers/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
"umd"
3131
],
3232
"dependencies": {
33+
"@deck.gl-community/editable-layers": "9.1.1",
34+
"@deck.gl-community/layers": "9.1.1",
3335
"@deck.gl/core": "^9.2.0",
3436
"@deck.gl/extensions": "^9.2.0",
3537
"@deck.gl/geo-layers": "^9.2.0",
@@ -54,8 +56,6 @@
5456
"@loaders.gl/wkt": "^4.3.2",
5557
"@luma.gl/constants": "^9.2.0",
5658
"@mapbox/geojson-normalize": "0.0.1",
57-
"@nebula.gl/edit-modes": "1.0.2-alpha.1",
58-
"@nebula.gl/layers": "1.0.2-alpha.1",
5959
"@turf/bbox": "^6.0.1",
6060
"@turf/boolean-within": "^6.0.1",
6161
"@turf/center": "^6.0.1",

src/layers/src/editor-layer/editor-layer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
// SPDX-License-Identifier: MIT
22
// Copyright contributors to the kepler.gl project
33

4-
import {EditableGeoJsonLayer} from '@nebula.gl/layers';
5-
import {Layer as DeckLayer, LayerProps as DeckLayerProps} from '@deck.gl/core';
64
import {
5+
EditableGeoJsonLayer,
76
DrawPolygonMode,
87
TranslateMode,
98
CompositeMode,
109
DrawRectangleMode
11-
} from '@nebula.gl/edit-modes';
10+
} from '@deck.gl-community/editable-layers';
11+
import {Layer as DeckLayer, LayerProps as DeckLayerProps} from '@deck.gl/core';
1212
import {PathStyleExtension} from '@deck.gl/extensions';
1313

1414
import {EDITOR_LAYER_ID, EDITOR_MODES, EDITOR_LAYER_PICKING_RADIUS} from '@kepler.gl/constants';

src/layers/src/editor-layer/modify-mode-extended.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ import {
55
ModifyMode,
66
FeatureOf,
77
LineString,
8-
Point,
9-
Viewport as NebulaViewport
10-
} from '@nebula.gl/edit-modes';
8+
Point
9+
} from '@deck.gl-community/editable-layers';
1110
import {Viewport} from '@deck.gl/core';
1211

1312
import {EDITOR_LAYER_PICKING_RADIUS} from '@kepler.gl/constants';
@@ -24,7 +23,7 @@ export class ModifyModeExtended extends ModifyMode {
2423
inPoint: FeatureOf<Point>,
2524
viewport: Viewport | null | undefined
2625
) {
27-
const p = super.getNearestPoint(line, inPoint, viewport as NebulaViewport | null | undefined);
26+
const p = super.getNearestPoint(line, inPoint, viewport);
2827
if (p && viewport) {
2928
const p1 = viewport.project(p.geometry.coordinates);
3029
const p2 = viewport.project(inPoint.geometry.coordinates);

src/processors/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
"umd"
3131
],
3232
"dependencies": {
33+
"@deck.gl-community/editable-layers": "9.1.1",
34+
"@deck.gl-community/layers": "9.1.1",
3335
"@kepler.gl/common-utils": "3.2.5",
3436
"@kepler.gl/constants": "3.2.5",
3537
"@kepler.gl/schemas": "3.2.5",
@@ -46,7 +48,6 @@
4648
"@loaders.gl/schema": "^4.3.2",
4749
"@loaders.gl/wkt": "^4.3.2",
4850
"@mapbox/geojson-normalize": "0.0.1",
49-
"@nebula.gl/edit-modes": "1.0.2-alpha.1",
5051
"@turf/helpers": "^6.1.4",
5152
"apache-arrow": ">=15.0.0",
5253
"d3-dsv": "^2.0.0",

0 commit comments

Comments
 (0)