[fix] WMS layer fixes 1 - #3148
Merged
Merged
Conversation
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reinstates and refactors WMS layer support across configuration, core layers, deck.gl wrappers, icons, and UI forms.
- Repositions and defaults
enableWMSLayerin application config - Enhances
WMSLayerwith bounding-box metadata updates and adjusts transparency - Adds
ExtendedWMSLayerwrapper, exports WMS components, and updates the icon SVG
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/src/application-config.ts | Moved enableWMSLayer property and updated default ordering |
| src/layers/src/wms-layer/wms-layer.ts | Refactored imports, set transparent: true, added _getCurrentServiceLayer & updateLayerMeta |
| src/layers/src/wms-layer/wms-layer-icon.tsx | Replaced <svg> with <g> paths and updated defaultProps |
| src/layers/src/index.ts | Exported WMSLayerIcon |
| src/deckgl-layers/src/wms/wms-layer.ts | Introduced ExtendedWMSLayer wrapper |
| src/deckgl-layers/src/index.ts | Exported WMSLayer |
| src/constants/src/layers.ts | Modified EDITOR_AVAILABLE_LAYERS (removed WMS) |
| src/components/src/modals/tilesets-modals/tileset-wms-form.tsx | Added name fallback for title and included boundingBox |
| src/components/src/modals/tilesets-modals/load-tileset.tsx | Imported WMSLayerIcon from @kepler.gl/layers |
Comments suppressed due to low confidence (3)
src/layers/src/wms-layer/wms-layer.ts:160
- Add unit tests for
updateLayerMeta, covering cases with and withoutboundingBox, to verify bounds are updated correctly.
updateLayerMeta(dataset: KeplerDataset): void {
src/layers/src/wms-layer/wms-layer.ts:42
- Document the expected format of
wmsLayer.boundingBox(e.g.,[[minX, minY], [maxX, maxY]]) in theWMSLayerVisConfigtype.
boundingBox: number[][];
src/constants/src/layers.ts:567
- Removing
LAYER_TYPES.wmswill disable WMS in the editor palette; restore it if WMS layers should remain selectable.
LAYER_TYPES.geojson
ilyabo
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.