[fix] button spinner fix - #3150
Merged
Merged
Conversation
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
igorDykhta
marked this pull request as ready for review
July 4, 2025 22:26
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the spinner in the LoadDataFooter by injecting theme colors, updating its size, and correcting animation syntax.
- Inject
themeintoLoadDataFooterso the spinner usestheme.borderColorLT - Increase spinner size from 12 to 24 and set a transparent border
- Consolidate and correct the CSS animation declaration in
loading-spinner.tsx
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/src/modals/tilesets-modals/load-data-footer.tsx | Wrapped component with withTheme, added theme prop, updated spinner color and size |
| src/components/src/common/loading-spinner.tsx | Removed separate animation properties and combined into a single animation rule |
ilyabo
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.