fix: trigger a redraw from icon layer once the icons are loaded. - #3269
Merged
Conversation
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where icon layers don't automatically redraw when icons finish loading asynchronously. Previously, users had to manually trigger a redraw (e.g., by moving the mouse). The fix introduces a new onForceUpdate callback mechanism that allows the icon layer to request a map redraw once the icons are loaded.
- Adds
onForceUpdatecallback to layer callback types - Implements callback in icon layer to trigger redraw after icon loading
- Connects callback through map container to trigger map state updates
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/types/layers.d.ts | Adds onForceUpdate callback definitions to LayerCallbacks and BindedLayerCallbacks types |
| src/layers/src/icon-layer/icon-layer.ts | Stores the onForceUpdate callback in renderLayer and calls it in setSvgIcons after icons load to trigger map redraw |
| src/components/src/map-container.tsx | Implements _onForceUpdate method and registers it in layer callbacks to trigger map updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ilyabo
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior: the user has to move the mouse or perform another action to trigger a redraw.
With the fix: trigger a redraw from icon layer once the icons are loaded.