Commit 04c3ca6
committed
fix(site): docker run command was malformed when secret path enabled
The docker-deployment branch built a one-line `docker run` command but
constructed the secret-path fragment with a trailing `\<newline>`
(intended as a shell-line-continuation) and then `.trim()`-ed only the
newline before splicing it back into the same line. The trailing
backslash survived into the rendered command:
... -e MCP_SECRET_PATH=/private_xxx \ ghcr.io/...
Bash parses `\<space>` as an escaped space, joining the leading
whitespace onto the next token — so docker was invoked with an image
argument of " ghcr.io/homeassistant-ai/ha-mcp:latest" (note the leading
space), which fails with `invalid reference format`. Users who
enabled the secret path on the Docker deployment got a broken
copy-paste command.
Drop the trailing `\\\n` from secretPathEnv (no continuation needed
inline) and remove the matching .trim() at the splice site. The
emitted command is now:
docker run -d --name ha-mcp -p 8086:8086 -e ... -e ... -e MCP_SECRET_PATH=/private_xxx ghcr.io/...
Pre-existing bug in master (predates homeassistant-ai#1106). Boy Scout fix bundled
here since the surrounding deployment block is being heavily touched
by this PR.
Build verified clean (npm run build, 7 pages, 41s).1 parent 7f1e007 commit 04c3ca6
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1322 | 1322 | | |
1323 | 1323 | | |
1324 | 1324 | | |
1325 | | - | |
| 1325 | + | |
1326 | 1326 | | |
1327 | 1327 | | |
1328 | 1328 | | |
1329 | 1329 | | |
1330 | 1330 | | |
1331 | 1331 | | |
1332 | 1332 | | |
1333 | | - | |
| 1333 | + | |
1334 | 1334 | | |
1335 | 1335 | | |
1336 | 1336 | | |
| |||
0 commit comments