ci: add unit tests to PR pipeline and pre-commit hook (homeassistant-ai#620)

* ci: add unit tests to PR pipeline and pre-commit hook

Unit tests were not run in CI or locally, so failures went undetected.
Add a unit-tests job to the PR workflow and a pre-commit hook that runs
them on every commit. Also rewrite test_performance_parallelization to
assert on observable outcomes (correct results, resilience, parallelism)
instead of internal implementation details that broke when the fetch
strategy changed.

* ci: authenticate to GHCR for higher rate limits

Add docker/login-action to authenticate with GITHUB_TOKEN before
pulling the Home Assistant image. This avoids anonymous rate limits
on GHCR that caused CI failures on shared runners.

* ci: increase retry attempts and wait for GHCR rate limits on ARM

ARM runners share a congested GHCR rate limit pool. Increase from
3 attempts / 15s wait to 5 attempts / 30s wait to give more time
for the rate limit bucket to refill.

* ci: remove ineffective GHCR login step

Fork GITHUB_TOKEN has no elevated access to the home-assistant
package, so the login didn't help with rate limits. Rely on
retry logic instead.

* ci: only run unit test hook on code changes

Replace always_run with file pattern filter so the pre-commit
unit test hook skips non-code commits (docs, CI config, etc).

* ci: cache HA Docker image and fallback to Docker Hub

Replace retry-based pull with actions/cache for the HA image.
On cache miss, try GHCR first then fall back to Docker Hub.
The image is cached per-architecture so ARM and x64 each get
their own cached tar. This avoids repeated GHCR rate limit
failures on shared ARM runners.

* fix: keep HA image versions in sync via Renovate

Add workflow YAML files to Renovate's managerFilePatterns so
HA_IMAGE_GHCR env vars are bumped alongside test file versions.

- Expand Renovate regex manager to scan .github/workflows/*.yml
- Add # renovate: comments to HA_IMAGE_GHCR in pr.yml and e2e-tests.yml
- Derive HA_IMAGE_DOCKERHUB at runtime from HA_IMAGE_GHCR version
- Extract HA_IMAGE variable in conftest.py and test_env_manager.py
  for consistency with run_uat.py

Author: sergeykad

.github/workflows/e2e-tests.yml

@@ -20,6 +20,8 @@ permissions:
 env:
   PYTHON_VERSION: "3.13"
   UV_CACHE_DIR: /tmp/.uv-cache
+  # renovate: datasource=docker depName=ghcr.io/home-assistant/home-assistant
+  HA_IMAGE_GHCR: "ghcr.io/home-assistant/home-assistant:2026.1.3"
 
 jobs:
   # Comprehensive E2E validation for main branch
@@ -33,6 +35,8 @@ jobs:
 
     - name: Set up Docker Buildx
       uses: docker/setup-buildx-action@v3
+      with:
+        cache-binary: true
 
     - name: Install uv
       uses: astral-sh/setup-uv@v7
@@ -45,6 +49,37 @@ jobs:
     - name: Install dependencies
       run: uv sync --all-extras --dev
 
+    - name: Cache HA Docker image
+      id: cache-ha-image
+      uses: actions/cache@v4
+      with:
+        path: /tmp/ha-image.tar
+        key: ha-image-${{ env.HA_IMAGE_GHCR }}-${{ runner.arch }}
+
+    - name: Load cached HA image
+      if: steps.cache-ha-image.outputs.cache-hit == 'true'
+      run: docker load -i /tmp/ha-image.tar
+
+    - name: Pull HA image (GHCR → Docker Hub fallback)
+      if: steps.cache-ha-image.outputs.cache-hit != 'true'
+      run: |
+        HA_VERSION="${HA_IMAGE_GHCR##*:}"
+        HA_IMAGE_DOCKERHUB="homeassistant/home-assistant:${HA_VERSION}"
+        for registry in "$HA_IMAGE_GHCR" "$HA_IMAGE_DOCKERHUB"; do
+          echo "Trying $registry..."
+          if docker pull "$registry"; then
+            if [ "$registry" != "$HA_IMAGE_GHCR" ]; then
+              docker tag "$registry" "$HA_IMAGE_GHCR"
+            fi
+            docker save "$HA_IMAGE_GHCR" -o /tmp/ha-image.tar
+            echo "Pulled and cached from $registry"
+            exit 0
+          fi
+          echo "Failed to pull from $registry, trying next..."
+          sleep 15
+        done
+        echo "All registries failed" && exit 1
+
     - name: Run full E2E test suite
       run: |
         echo "🚀 Running full E2E test suite with 3 workers..."

.github/workflows/pr.yml

@@ -10,6 +10,8 @@ on:
 env:
   PYTHON_VERSION: "3.13"
   UV_CACHE_DIR: /tmp/.uv-cache
+  # renovate: datasource=docker depName=ghcr.io/home-assistant/home-assistant
+  HA_IMAGE_GHCR: "ghcr.io/home-assistant/home-assistant:2026.1.3"
 
 jobs:
   lint:
@@ -28,6 +30,23 @@ jobs:
     - name: Run ruff check
       run: uv run ruff check src/ tests/
 
+  # Fast unit tests (no Docker, no HA instance needed)
+  unit-tests:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/astral-sh/uv:0.9.30-python3.13-bookworm-slim
+    timeout-minutes: 5
+
+    steps:
+    - uses: actions/checkout@v6
+
+    - name: Install dependencies
+      run: uv sync --all-extras --dev
+
+    - name: Run unit tests
+      run: uv run pytest tests/src/unit/ -n auto --tb=short -v
+
   # Comprehensive E2E validation for all PRs
   e2e-validation:
     name: E2E Validation (${{ matrix.os }})
@@ -50,6 +69,8 @@ jobs:
 
     - name: Set up Docker Buildx
       uses: docker/setup-buildx-action@v3
+      with:
+        cache-binary: true
 
     - name: Install uv
       uses: astral-sh/setup-uv@v7
@@ -62,6 +83,37 @@ jobs:
     - name: Install dependencies
       run: uv sync --all-extras --dev
 
+    - name: Cache HA Docker image
+      id: cache-ha-image
+      uses: actions/cache@v4
+      with:
+        path: /tmp/ha-image.tar
+        key: ha-image-${{ env.HA_IMAGE_GHCR }}-${{ runner.arch }}
+
+    - name: Load cached HA image
+      if: steps.cache-ha-image.outputs.cache-hit == 'true'
+      run: docker load -i /tmp/ha-image.tar
+
+    - name: Pull HA image (GHCR → Docker Hub fallback)
+      if: steps.cache-ha-image.outputs.cache-hit != 'true'
+      run: |
+        HA_VERSION="${HA_IMAGE_GHCR##*:}"
+        HA_IMAGE_DOCKERHUB="homeassistant/home-assistant:${HA_VERSION}"
+        for registry in "$HA_IMAGE_GHCR" "$HA_IMAGE_DOCKERHUB"; do
+          echo "Trying $registry..."
+          if docker pull "$registry"; then
+            if [ "$registry" != "$HA_IMAGE_GHCR" ]; then
+              docker tag "$registry" "$HA_IMAGE_GHCR"
+            fi
+            docker save "$HA_IMAGE_GHCR" -o /tmp/ha-image.tar
+            echo "Pulled and cached from $registry"
+            exit 0
+          fi
+          echo "Failed to pull from $registry, trying next..."
+          sleep 15
+        done
+        echo "All registries failed" && exit 1
+
     - name: Run full E2E test suite
       run: |
         echo "🚀 Running full E2E test suite with ${{ matrix.pytest_workers }} workers..."
@@ -84,6 +136,8 @@ jobs:
 
     - name: Set up Docker Buildx
       uses: docker/setup-buildx-action@v3
+      with:
+        cache-binary: true
 
     - name: Install uv
       uses: astral-sh/setup-uv@v7

.pre-commit-config.yaml

@@ -4,3 +4,11 @@ repos:
     hooks:
       - id: ruff
         args: [--fix]
+  - repo: local
+    hooks:
+      - id: unit-tests
+        name: unit tests
+        entry: uv run pytest tests/src/unit/ -n auto -m "not slow" --tb=short -q
+        language: system
+        pass_filenames: false
+        files: ^(src/|tests/|pyproject\.toml)

renovate.json

@@ -16,7 +16,8 @@
     {
       "customType": "regex",
       "managerFilePatterns": [
-        "/tests/.*\\.py$/"
+        "/tests/.*\\.py$/",
+        "/.github/workflows/.*\\.yml$/"
       ],
       "matchStrings": [
         "# renovate: datasource=(?<datasource>\\S+) depName=(?<depName>\\S+)\\s+.*?\\S+:(?<currentValue>[\\d.]+)"

tests/src/e2e/conftest.py

@@ -165,7 +165,8 @@ def ha_container_with_fresh_config():
 
     # Create testcontainer with port configuration
     # renovate: datasource=docker depName=ghcr.io/home-assistant/home-assistant
-    container = DockerContainer("ghcr.io/home-assistant/home-assistant:2026.1.3")
+    HA_IMAGE = "ghcr.io/home-assistant/home-assistant:2026.1.3"
+    container = DockerContainer(HA_IMAGE)
 
     # Check for custom port via environment variable
     custom_port = os.environ.get("HA_TEST_PORT")

tests/src/unit/test_bulk_device_control.py

@@ -77,6 +77,7 @@ async def test_non_dict_operation_reports_error(self, device_control_tools):
         for detail in result["skipped_details"]:
             assert "not a dict" in detail["error"]
 
+    @pytest.mark.slow
     @pytest.mark.asyncio
     async def test_mixed_valid_and_invalid_operations(self, device_control_tools):
         """Mix of valid and invalid operations reports skipped ones.

tests/src/unit/test_config.py

@@ -4,8 +4,10 @@
 import subprocess
 import sys
 
+import pytest
 
 
+@pytest.mark.slow
 class TestConfigErrorHandling:
     """Test configuration error handling and user-friendly messages."""