Connection reset by peer

[mindplay-dk]

I'm seeing IO errors on the console whenever a peer drops a connection:

Error serving connection: hyper::Error(Io, Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })

I don't think this should appear?

Peers dropping connections is normal - for example, Chrome does this when starting an audio/video stream.

So I don't think this is unexpected, and likely shouldn't be treated as an error? Unless somebody wants to explicitly handle it as an error - perhaps via some sort of callback? For something like web sockets or other technical stuff, you might need this, I'm really not sure...?

[nehu3n]

Hi @mindplay-dk ! I think the best approach would be to integrate this as a KitoError.

I opened an issue describing the error-handling approach Kito will implement in the next version, it's open for comments: #36

Thanks!

[mindplay-dk]

I'm not sure this should be treated as an error?

As mentioned in #41 you might want to consider supporting at least some of the events that Node/Express/etc. post via the on and once standard event hooks in Node?

For one, issue #33 likely needs to on('connection'), if you want to be backwards compatible with Express, where I think the pattern is something like:

server.on('connection', (socket) => {
  socket.on('error', (err) => {
    if (err.code === 'ECONNRESET') {
      // Connection reset by peer
    }
  });
});

I'm honestly not fond of this type of API, and I guess you don't have a Node-compatible net.Socket instance for this? You might not even want it.

I'm not sure how widely used these facilities are, but do they get used, I think? Even for basic things like counting the number of active clients, you probably need events.

These events aren't errors in Node or Express though, and there's nothing exceptional about clients disconnecting - it's totally normal, and probably not something that would matter e.g. to middleware, since it's not even specifically tied to the request/response cycle, as far as I understand? To my understanding, e.g. due to HTTP "keep-alive" and such, clients may connect or disconnect independently of making HTTP requests, e.g. can preconnect without making a request, etc.