fix(apiserversource): fix backoff reset and dead test assertion

Backoff was reset on every successful LIST and Watch creation, so
LIST-ok -> Watch-fail could hammer the API server at 1 req/s forever
without ever reaching the 60s cap. Now resets only when a watch
survives >30s; short-lived drains incur a backoff step so normal
watch-close does not spin hot.

Test assertion errors.Is(err, err) was always true; replaced with
checks that error contains "mutually exclusive" and path
"metadata.annotations".

Author: Ankitsinghsisodya

pkg/adapter/apiserver/adapter.go

@@ -188,7 +188,6 @@ func (a *apiServerAdapter) watchResourceLoop(ctx context.Context, ri dynamic.Res
 			continue
 		}
 		rv := list.GetResourceVersion()
-		backoff = noCacheBackoff()
 
 		w, err := ri.Watch(ctx, metav1.ListOptions{
 			LabelSelector:   labelSelector,
@@ -209,8 +208,21 @@ func (a *apiServerAdapter) watchResourceLoop(ctx context.Context, ri dynamic.Res
 			}
 			continue
 		}
-		backoff = noCacheBackoff()
+
+		watchStart := time.Now()
 		a.drainWatchEvents(ctx, w, delegate)
+		if time.Since(watchStart) > 30*time.Second {
+			// Watch was long-lived; treat connection as stable and reset backoff.
+			backoff = noCacheBackoff()
+		} else {
+			t := time.NewTimer(backoff.Step())
+			select {
+			case <-ctx.Done():
+				t.Stop()
+				return
+			case <-t.C:
+			}
+		}
 	}
 }
 

pkg/apis/sources/v1/apiserver_validation_test.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"context"
 	"errors"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -294,8 +295,12 @@ func TestAPIServerDisableCacheAnnotationValidation(t *testing.T) {
 		if err == nil {
 			t.Fatal("expected validation error for conflicting annotations, got nil")
 		}
-		if !errors.Is(err, err) {
-			t.Errorf("unexpected error: %v", err)
+		errStr := err.Error()
+		if !strings.Contains(errStr, "mutually exclusive") {
+			t.Errorf("error missing 'mutually exclusive': %v", err)
+		}
+		if !strings.Contains(errStr, "metadata.annotations") {
+			t.Errorf("error missing field path 'metadata.annotations': %v", err)
 		}
 	})