Skip to content

🐛 fix start-minikube action to pass through memory input#576

Merged
ibolton336 merged 1 commit into
konveyor:mainfrom
ibolton336:fix/minikube-memory-passthrough
Jun 9, 2026
Merged

🐛 fix start-minikube action to pass through memory input#576
ibolton336 merged 1 commit into
konveyor:mainfrom
ibolton336:fix/minikube-memory-passthrough

Conversation

@ibolton336

@ibolton336 ibolton336 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

The start-minikube action accepts a memory input but was ignoring it — the medyagh/setup-minikube call hardcoded memory: 8000. This meant callers passing memory: "max" (like editor-extensions E2E workflows) got exactly 8000MB regardless of available runner memory.

Problem

With the full Konveyor stack (hub, postgres, kai-api, kai-db, llm-proxy, llemulator, operator, nginx ingress) all sharing a hardcoded 8GB, the system runs under significant memory pressure on GitHub Actions runners. This causes:

  • Hub API requests randomly timing out (10-30s+)
  • Flaky E2E tests that pass intermittently depending on GC/swap timing
  • Profile sync and token exchange requests hanging

Fix

One-line change: memory: 8000memory: ${{ inputs.memory }}

This respects the caller's intent. When memory is empty string (default), medyagh/setup-minikube uses its own default. When "max" is passed, minikube uses all available RAM.

Fixes #575

Summary by CodeRabbit

  • Chores
    • Updated CI/CD configuration to improve flexibility in build environment parameters.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ibolton336, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d850fc6a-1da9-43a2-8674-eb89e9f5a3e5

📥 Commits

Reviewing files that changed from the base of the PR and between 041ed29 and b4f829a.

📒 Files selected for processing (1)
  • .github/actions/start-minikube/action.yml
📝 Walkthrough

Walkthrough

The start-minikube GitHub Action is updated to forward the configurable memory input parameter to the medyagh/setup-minikube action, replacing a hardcoded 8000MB value and allowing callers to adjust minikube memory allocation as needed.

Changes

Minikube Memory Parameter Pass-through

Layer / File(s) Summary
Memory input forwarding
.github/actions/start-minikube/action.yml
The with.memory parameter passed to medyagh/setup-minikube is updated from hardcoded 8000 to the action's configurable ${{ inputs.memory }} input.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny found the memory was stuck,
At eight gigs bound by hardcoded luck,
Now inputs flow through like carrots divine,
Minikube's memory finally can shine! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the start-minikube action to pass through the memory input instead of hardcoding it.
Linked Issues check ✅ Passed The PR directly addresses the primary coding requirement from issue #575 by replacing the hardcoded memory value with the inputs.memory variable, allowing callers to specify memory allocation.
Out of Scope Changes check ✅ Passed The change is tightly scoped to the stated objective: only one line modified to pass through the memory input, with no unrelated alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The start-minikube action accepts a `memory` input but was ignoring it —
the medyagh/setup-minikube call hardcoded `memory: 8000`. This meant
callers passing `memory: "max"` (like editor-extensions E2E) got exactly
8000MB regardless of available runner memory.

With the full Konveyor stack (hub, postgres, kai, llm-proxy, llemulator,
operator, ingress) all sharing 8GB, the system runs under significant
memory pressure causing flaky hub timeouts in downstream E2E tests.

Fixes konveyor#575

Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336 ibolton336 force-pushed the fix/minikube-memory-passthrough branch from 041ed29 to b4f829a Compare June 9, 2026 17:16
@ibolton336 ibolton336 requested a review from fabianvf June 9, 2026 17:16

@fabianvf fabianvf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@ibolton336 ibolton336 merged commit 79fb9b7 into konveyor:main Jun 9, 2026
13 checks passed
ibolton336 added a commit to ibolton336/editor-extensions that referenced this pull request Jun 9, 2026
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/editor-extensions that referenced this pull request Jun 9, 2026
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/editor-extensions that referenced this pull request Jun 9, 2026
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/editor-extensions that referenced this pull request Jun 9, 2026
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336 added a commit to ibolton336/editor-extensions that referenced this pull request Jun 10, 2026
Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 start-minikube action ignores memory input — hardcodes 8000MB

2 participants