You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Update CONTRIBUTING.md
- Current CODEOWNER.md based rules for pr approvals.
This will be changed ot the maintainer and contributor groups based rules
once we agreed to apply them to all the repos.
- Rules for stale prs
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
* Apply suggestions from code review
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Assisted-by: GitHub Copilot: Claude Haiku 4.5
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+18-4Lines changed: 18 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,10 +47,24 @@ Process for code reviews. Before requesting human review, a PR must:
47
47
48
48
* All tests passing
49
49
* All linting passing
50
-
* Meeting project code quality requirements, including passing all configured static analysis / SonarCloud quality gates and not reducing automated test coverage for the affected components
51
-
* The comments from the first run of automatically generated comments (AI generated comments, SonarCloud comments, bot generated comments, etc.) of the PR are addressed (addressing further re-runs of AI are optional)
52
-
* If it is not possible to resolve an automatic comment, please add a sub-comment indicating why the automated comment cannot be resolved or ask for help in resolving the comment
53
-
* The PR description states whether AI was used to help create the PR; if so, it lists the AI tools used and the areas where they were used
50
+
* Meeting project code quality requirements, including passing all configured
51
+
static analysis / SonarCloud quality gates and not reducing automated test coverage for the
52
+
affected components
53
+
* The comments from the first run of automatically generated comments (AI generated comments,
54
+
SonarCloud comments, bot generated comments, etc.) of the PR are addressed (addressing further
55
+
re-runs of AI are optional)
56
+
* If it is not possible to resolve an automatic comment, please add a sub-comment indicating why
57
+
the automated comment cannot be resolved or ask for help in resolving the comment
58
+
* The PR description states whether AI was used to help create the PR; if so, it lists the AI tools
59
+
used and the areas where they were used
60
+
61
+
All PRs should be approved by at least two members listed in the [CODEOWNERS](./CODEOWNERS) file, have all checks passing, and have all discussions resolved before merge.
62
+
63
+
### Stale PRs
64
+
65
+
If there is no activity from the PR author for more than 2 weeks (for example, no commits or replies to review comments), the PR will be closed.
66
+
The PR can be re-opened at any time if there is willingness to continue the work after a break.
0 commit comments