Reverse logic on DoPRMutations to reduce indentation (#987)

Signed-off-by: liamfallon <liam.fallon@est.tech>

Author: liamfallon

pkg/task/generictaskhandler.go

@@ -130,41 +130,41 @@ func (th *genericTaskHandler) DoPRMutations(
 	defer span.End()
 
 	// Update package contents only if the package is in draft state
-	if oldObj.Spec.Lifecycle == porchapi.PackageRevisionLifecycleDraft {
-		apiResources, err := repoPR.GetResources(ctx)
-		if err != nil {
-			return fmt.Errorf("cannot get package resources: %w", err)
-		}
-		resources := repository.PackageResources{
-			Contents: apiResources.Spec.Resources,
-		}
+	if oldObj.Spec.Lifecycle != porchapi.PackageRevisionLifecycleDraft {
+		return nil
+	}
 
-		newKptfileContent, changed, err := PatchKptfile(ctx, repoPR, newObj)
-		if err != nil {
-			return err
-		}
-		if changed && newKptfileContent != "" && newKptfileContent != "{}\n" {
-			resources.Contents[kptfilev1.KptFileName] = newKptfileContent
-		}
+	apiResources, err := repoPR.GetResources(ctx)
+	if err != nil {
+		return fmt.Errorf("cannot get package resources: %w", err)
+	}
+	resources := repository.PackageResources{
+		Contents: apiResources.Spec.Resources,
+	}
 
-		// render
-		draftMeta := draft.GetMeta()
-		resources, _, err = th.renderMutation(draftMeta.GetNamespace()).apply(ctx, resources)
-		if err != nil {
-			klog.Error(err)
-			return renderError(err)
-		}
+	newKptfileContent, changed, err := PatchKptfile(ctx, repoPR, newObj)
+	if err != nil {
+		return err
+	}
+	if changed && newKptfileContent != "" && newKptfileContent != "{}\n" {
+		resources.Contents[kptfilev1.KptFileName] = newKptfileContent
+	}
 
-		prr := &porchapi.PackageRevisionResources{
-			Spec: porchapi.PackageRevisionResourcesSpec{
-				Resources: resources.Contents,
-			},
-		}
+	// render
+	draftMeta := draft.GetMeta()
+	resources, _, err = th.renderMutation(draftMeta.GetNamespace()).apply(ctx, resources)
+	if err != nil {
+		klog.Error(err)
+		return renderError(err)
+	}
 
-		return draft.UpdateResources(ctx, prr, &porchapi.Task{Type: porchapi.TaskTypeRender})
+	prr := &porchapi.PackageRevisionResources{
+		Spec: porchapi.PackageRevisionResourcesSpec{
+			Resources: resources.Contents,
+		},
 	}
 
-	return nil
+	return draft.UpdateResources(ctx, prr, &porchapi.Task{Type: porchapi.TaskTypeRender})
 }
 
 func (th *genericTaskHandler) DoPRResourceMutations(