Fix mutexes in cache entrypoint (#369)

Author: kushnaidu

pkg/cache/crcache/cache.go

@@ -56,9 +56,10 @@ func (c *Cache) OpenRepository(ctx context.Context, repositorySpec *configapi.Re
 	lock.Lock()
 	defer lock.Unlock()
 
-	c.mainLock.RLock()
+	c.mainLock.Lock()
+	defer c.mainLock.Unlock()
+
 	if repo, ok := c.repositories[key]; ok && repo != nil {
-		c.mainLock.RUnlock()
 		// Keep the spec updated in the cache.
 		repo.repoSpec = repositorySpec
 		// Check external repo connectivity
@@ -73,7 +74,6 @@ func (c *Cache) OpenRepository(ctx context.Context, repositorySpec *configapi.Re
 		}
 		return repo, nil
 	}
-	c.mainLock.RUnlock()
 
 	externalRepo, err := externalrepo.CreateRepositoryImpl(ctx, repositorySpec, c.options.ExternalRepoOptions)
 	if err != nil {
@@ -82,9 +82,7 @@ func (c *Cache) OpenRepository(ctx context.Context, repositorySpec *configapi.Re
 
 	cachedRepo := newRepository(key, repositorySpec, externalRepo, c.metadataStore, c.options)
 
-	c.mainLock.Lock()
 	c.repositories[key] = cachedRepo
-	c.mainLock.Unlock()
 
 	return cachedRepo, nil
 }

pkg/cache/dbcache/dbcache.go

@@ -52,9 +52,10 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		return nil, err
 	}
 
-	c.mainLock.RLock()
+	c.mainLock.Lock()
+	defer c.mainLock.Unlock()
+
 	if dbRepo, ok := c.repositories[repoKey]; ok {
-		c.mainLock.RUnlock()
 		// Keep the spec updated in the cache.
 		dbRepo.spec = repositorySpec
 		err := externalrepo.CheckRepositoryConnection(ctx, dbRepo.spec, c.options.ExternalRepoOptions)
@@ -65,7 +66,6 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		klog.V(2).Infof("dbCache::OpenRepository: verified repo connectivity %+v", repoKey)
 		return dbRepo, nil
 	}
-	c.mainLock.RUnlock()
 
 	dbRepo := &dbRepository{
 		repoKey:              repoKey,
@@ -82,9 +82,7 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		return nil, err
 	}
 
-	c.mainLock.Lock()
 	c.repositories[repoKey] = dbRepo
-	c.mainLock.Unlock()
 
 	dbRepo.repositorySync = newRepositorySync(dbRepo, c.options)