Remove addition of "package-context.yaml" to sub-packages in a PackageRevision (#364)

* Remove mutation on clne that adds package-context.yaml

Signed-off-by: liamfallon <liam.fallon@est.tech>

* Changed implementation to just add to root of package

Signed-off-by: liamfallon <liam.fallon@est.tech>

* Updated to address review comments

Signed-off-by: liamfallon <liam.fallon@est.tech>

---------

Signed-off-by: liamfallon <liam.fallon@est.tech>

Author: liamfallon

internal/kpt/builtins/pkg_context.go

@@ -75,7 +75,7 @@ func (pc *PackageContextGenerator) Process(resourceList *framework.ResourceList)
 
 	// This loop does the following:
 	// - Filters out package context resources from the input resources
-	// - Generates a package context resource for each kpt package (i.e Kptfile)
+	// - Generates a package context resource for the root kpt package (i.e Kptfile)
 	for _, resource := range resourceList.Items {
 		gvk := resid.GvkFromNode(resource)
 		if gvk.Equals(configMapGVK) && resource.GetName() == PkgContextName {
@@ -95,7 +95,11 @@ func (pc *PackageContextGenerator) Process(resourceList *framework.ResourceList)
 				}
 				return resourceList.Results
 			}
-			contextResources = append(contextResources, pkgContext)
+
+			// Only add package context to the root kpt package
+			if pkgContext != nil {
+				contextResources = append(contextResources, pkgContext)
+			}
 		}
 	}
 
@@ -121,6 +125,12 @@ func pkgContextResource(kptfile *yaml.RNode, packageConfig *PackageConfig) (*yam
 	if err != nil {
 		return nil, err
 	}
+
+	// We only want one "package-context.yaml" in each kpt package
+	if kptfilePath != kptfilev1.KptFileGVK().Kind {
+		return nil, nil
+	}
+
 	annotations := map[string]string{
 		kioutil.PathAnnotation: path.Join(path.Dir(kptfilePath), PkgContextFile),
 	}

internal/kpt/builtins/testdata/pkg-with-nesting/out.yaml

@@ -42,21 +42,8 @@ items:
       internal.config.kubernetes.io/path: 'package-context.yaml'
   data:
     name: order-service
-- apiVersion: v1
-  kind: ConfigMap
-  metadata:
-    name: kptfile.kpt.dev
-    annotations:
-      config.kubernetes.io/local-config: "true"
-      internal.config.kubernetes.io/path: 'subpkg/package-context.yaml'
-  data:
-    name: subpkg
 results:
 - message: generated package context
   severity: info
   file:
     path: package-context.yaml
-- message: generated package context
-  severity: info
-  file:
-    path: subpkg/package-context.yaml