Unify golangci-lint: replace Docker-based lint with go run pattern (#1046)

* Unify golangci-lint: replace Docker-based lint with go run pattern

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>

* Address review comments

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>

---------

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>

Author: aravindtga

.golangci.json

@@ -41,6 +41,10 @@
         {
           "linters": ["staticcheck"],
           "text": "SA1019.*client\\.Apply"
+        },
+        {
+          "linters": ["govet"],
+          "text": "inline: cannot inline"
         }
       ]
     },

make/go.mk

@@ -14,7 +14,7 @@
 
 # Core Go development tools
 
-GOLANG_CI_VER ?= 2.12.2
+GOLANGCI_LINT_VERSION ?= 2.12.2
 GOLANG_CI_ARGS ?= -v --fix --timeout=10m
 
 ##@ Go Development
@@ -33,10 +33,10 @@ fix: fix-api ## Run go fix against the codebase
 
 .PHONY: lint
 lint: lint-api ## Run Go linter against the codebase
-	@if command -v golangci-lint >/dev/null 2>&1 && [ "$$(golangci-lint version --short)" = "$(GOLANG_CI_VER)" ]; then \
+	@if command -v golangci-lint >/dev/null 2>&1 && [ "$$(golangci-lint version --short)" = "$(GOLANGCI_LINT_VERSION)" ]; then \
 		golangci-lint run ./... $(GOLANG_CI_ARGS); \
 	else \
-		go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v$(GOLANG_CI_VER) run ./... $(GOLANG_CI_ARGS); \
+		go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v$(GOLANGCI_LINT_VERSION) run ./... $(GOLANG_CI_ARGS); \
 	fi
 
 .PHONY: fix-all

pkg/registry/porch/watch.go

@@ -358,4 +358,4 @@ func (w *watcher) OnPackageRevisionChange(eventType watch.EventType, pr reposito
 // WatchList semantics require bookmarks to signal initial-events-end.
 func effectiveAllowWatchBookmarks(allowWatchBookmarks, sendInitialEvents bool) bool {
 	return allowWatchBookmarks || sendInitialEvents
-}
+}