Increase genericapiserver and webhook server timeouts (#305)

* Increase genericApi and webhook server timeouts

* Update pkg/apiserver/apiserver.go

Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

---------

Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>

Author: kushnaidu

pkg/apiserver/apiserver.go

@@ -189,6 +189,9 @@ func (c completedConfig) getCoreV1Client() (*corev1client.CoreV1Client, error) {
 
 // New returns a new instance of PorchServer from the given config.
 func (c completedConfig) New(ctx context.Context) (*PorchServer, error) {
+	// TODO: REMOVE AFTER ASYNC IMPLEMENTATION IS READY.
+	// Set the default request timeout just above hardcoded ctx timeout
+	c.GenericConfig.RequestTimeout = 291 * time.Second
 	genericServer, err := c.GenericConfig.New("porch-apiserver", genericapiserver.NewEmptyDelegate())
 	if err != nil {
 		return nil, err

pkg/apiserver/webhooks.go

@@ -73,6 +73,7 @@ type WebhookConfig struct {
 	Port             int32
 	CertStorageDir   string
 	CertManWebhook   bool
+	timeout          int32
 }
 
 // newWebhookConfig creates a new WebhookConfig object filled with values read from environment variables
@@ -282,7 +283,8 @@ func createValidatingWebhook(ctx context.Context, cfg *WebhookConfig, caCert []b
 	if err != nil {
 		return fmt.Errorf("failed to setup kubeClient: %v", err)
 	}
-
+	// Set max timeout value for ValidatingWebhooks
+	cfg.timeout = 30
 	var (
 		validationCfgName = "packagerev-deletion-validating-webhook"
 		fail              = admissionregistrationv1.Fail
@@ -309,6 +311,7 @@ func createValidatingWebhook(ctx context.Context, cfg *WebhookConfig, caCert []b
 			AdmissionReviewVersions: []string{"v1", "v1beta1"},
 			SideEffects:             &none,
 			FailurePolicy:           &fail,
+			TimeoutSeconds:          &cfg.timeout,
 		}},
 	}
 	switch cfg.Type {
@@ -424,9 +427,9 @@ func runWebhookServer(ctx context.Context, cfg *WebhookConfig) error {
 		Addr: fmt.Sprintf(":%d", cfg.Port),
 		TLSConfig: &tls.Config{
 			GetCertificate: getCertificate,
-			MinVersion: tls.VersionTLS12,
+			MinVersion:     tls.VersionTLS12,
 		},
-		ReadHeaderTimeout: 10 * time.Second,
+		ReadHeaderTimeout: 30 * time.Second,
 	}
 	go func() {
 		err = server.ListenAndServeTLS("", "")