Revert mutex changes db openRepository (#374)

Author: kushnaidu

pkg/cache/dbcache/dbcache.go

@@ -52,10 +52,10 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		return nil, err
 	}
 
-	c.mainLock.Lock()
-	defer c.mainLock.Unlock()
+	c.mainLock.RLock()
 
 	if dbRepo, ok := c.repositories[repoKey]; ok {
+		c.mainLock.RUnlock()
 		// Keep the spec updated in the cache.
 		dbRepo.spec = repositorySpec
 		err := externalrepo.CheckRepositoryConnection(ctx, dbRepo.spec, c.options.ExternalRepoOptions)
@@ -66,6 +66,7 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		klog.V(2).Infof("dbCache::OpenRepository: verified repo connectivity %+v", repoKey)
 		return dbRepo, nil
 	}
+	c.mainLock.RUnlock()
 
 	dbRepo := &dbRepository{
 		repoKey:              repoKey,
@@ -82,7 +83,9 @@ func (c *dbCache) OpenRepository(ctx context.Context, repositorySpec *configapi.
 		return nil, err
 	}
 
+	c.mainLock.Lock()
 	c.repositories[repoKey] = dbRepo
+	c.mainLock.Unlock()
 
 	dbRepo.repositorySync = newRepositorySync(dbRepo, c.options)
 

pkg/externalrepo/git/git.go

@@ -267,7 +267,7 @@ type gitRepository struct {
 	// through all the refs each time
 	deletionProposedCache map[BranchName]bool
 
-	mutex sync.RWMutex
+	mutex sync.Mutex
 
 	// caBundle to use for TLS communication towards git
 	caBundle []byte