Summary
DB_PUSH_DRAFTS_TO_GIT=true has no effect. The two run-in-kind-db-cache-push-drafts jobs in .github/workflows/porch-e2e-ci-jobs.yaml deploy porch-server with --db-push-drafts-to-git=false, so the push-drafts-to-git code path has never had any e2e coverage. The tests themselves are valid and passing, they have been exercising the default configuration.
For example you can view A CI Job here https://github.com/kptdev/porch/actions/runs/30275725966/job/90014103477#step:9:49
Both the (DB Cache) E2E & CLI tests run with run-in-kind-db-cache-push-drafts and if you search for DB_PUSH_DRAFTS_TO_GIT you can see its never enabled.
Cause
make/deploy.mk sets the variable per target:
run-in-kind-db-cache-push-drafts: DB_PUSH_DRAFTS_TO_GIT=true
but never declares it with export.
PLEASE NOTE if we fix this before fixing #1141 & #928 our E2E test pipeline WILL break ive tested locally.
Summary
DB_PUSH_DRAFTS_TO_GIT=truehas no effect. The tworun-in-kind-db-cache-push-draftsjobs in.github/workflows/porch-e2e-ci-jobs.yamldeploy porch-server with--db-push-drafts-to-git=false, so the push-drafts-to-git code path has never had any e2e coverage. The tests themselves are valid and passing, they have been exercising the default configuration.For example you can view A CI Job here https://github.com/kptdev/porch/actions/runs/30275725966/job/90014103477#step:9:49
Both the (DB Cache) E2E & CLI tests run with
run-in-kind-db-cache-push-draftsand if you search forDB_PUSH_DRAFTS_TO_GITyou can see its never enabled.Cause
make/deploy.mksets the variable per target:run-in-kind-db-cache-push-drafts: DB_PUSH_DRAFTS_TO_GIT=truebut never declares it with
export.PLEASE NOTE if we fix this before fixing #1141 & #928 our E2E test pipeline WILL break ive tested locally.