Remove overwriting the default HTTP transport by mozesl-nokia · Pull Request #1112 · kptdev/porch

mozesl-nokia · 2026-07-13T08:49:36Z

Remove overwriting the default HTTP transport

Description

What changed: Removed overwriting the default HTTP transport and the tag resolution from podevaluator.
Why it’s needed: Overwriting the default transport breaks regclient and is generally bad practice. The tag resolution is already done in the runtime before the evaluator is called.
How it works:

Related Issue(s)

None

Type of Change

Bug fix
Refactor

Checklist

Additional Notes (Optional)

Known issues: This way, we are not strictly tracking all http traffic going in and out of porch, but most metrics are already exposed by the apiserver framework.
Further improvements: Add E2E tests for tag resolution and TLS handling
Review notes:

AI Disclosure

I have used AI in the creation of this PR.

If so, please describe how:

The the refactor of the TLS handling in podevaluator was done by composer-2.5
The new unit tests for the TLS functions was done by grok-4.5

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

netlify · 2026-07-13T08:49:41Z

✅ Deploy Preview for kpt-porch ready!

Name	Link
🔨 Latest commit	`bb2d6cb`
🔍 Latest deploy log	https://app.netlify.com/projects/kpt-porch/deploys/6a7993e82cd5d80007a69ab9
😎 Deploy Preview	https://deploy-preview-1112--kpt-porch.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR removes global mutation of http.DefaultTransport (previously used for OpenTelemetry wrapping) and introduces a dedicated pkg/httpclient helper for constructing registry-focused HTTP transports/clients. It also refactors TLS handling for private registry pulls and removes tag-resolution logic from the pod evaluator path.

Changes:

Added pkg/httpclient with a snapshot-based base *http.Transport and helpers to create registry transports/clients with optional TLS config.
Removed OpenTelemetry wrapping of http.DefaultTransport in telemetry setup to avoid breaking downstream clients (e.g., regclient).
Refactored private-registry TLS CA discovery/transport creation in podmanager and removed pod-evaluator tag resolution + related tests.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/httpclient/registry.go	New shared HTTP transport/client helpers for registry outbound calls without mutating global defaults.
pkg/httpclient/registry_test.go	Adds unit tests for the new httpclient helpers.
internal/telemetry/otel.go	Removes global HTTP default transport/client wrapping during OTel setup.
go.mod	Reclassifies `sigs.k8s.io/cli-utils` as indirect after refactor.
func/internal/podmanager.go	Uses new registry transport helper and factors CA path discovery into a helper.
func/internal/podmanager_unit_test.go	Removes tests tied to the deleted in-file transport constructor.
func/internal/podevaluator.go	Refactors construction wiring and removes tag resolution prior to evaluation.
func/internal/podevaluator_unit_test.go	Updates evaluator unit tests to match removed tag-resolver wiring.
func/internal/podevaluator_tag_resolution_test.go	Deletes tag resolution unit tests (tag resolution no longer done here).
func/internal/executableevaluator_test.go	Minor test constant addition for shared test image name.

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> Assisted-by: Cursor:grok-4.5

sonarqubecloud · 2026-08-10T09:10:32Z

Quality Gate failed

Failed conditions
77.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

mozesl-nokia added 2 commits July 13, 2026 10:15

remove replacing default transport, restructure podeval construction

76c6dd5

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

remove unnecessary tag resolution code from podeval

125a33f

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

mozesl-nokia requested review from a team July 13, 2026 08:49

mozesl-nokia added the bug Something isn't working label Jul 13, 2026

mozesl-nokia requested a review from efiacor as a code owner July 13, 2026 08:49

mozesl-nokia added the go Pull requests that update go code label Jul 13, 2026

mozesl-nokia requested review from kispaljr and liamfallon as code owners July 13, 2026 08:49

dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 13, 2026

github-actions Bot requested a review from Copilot July 13, 2026 08:49

Copilot started reviewing on behalf of mozesl-nokia July 13, 2026 08:50 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread pkg/httpclient/registry_test.go Outdated

Comment thread func/internal/podmanager.go Outdated

liamfallon previously approved these changes Jul 13, 2026

View reviewed changes

dosubot Bot added the lgtm #ededed label Jul 13, 2026

mozesl-nokia added 3 commits July 13, 2026 13:04

address review comments

1f2ae64

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

refactor tlsCACertPath

92cc170

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

improve coverage

ed478c5

Assisted-by: Cursor:composer-2.5 Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

mozesl-nokia dismissed liamfallon’s stale review via ed478c5 July 13, 2026 11:36

mozesl-nokia requested review from Copilot and liamfallon July 13, 2026 11:36

Copilot started reviewing on behalf of mozesl-nokia July 13, 2026 11:37 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread func/internal/podmanager.go

Comment thread func/internal/podevaluator.go

mozesl-nokia added 2 commits July 13, 2026 14:10

revert removal of tag resolution (currently non-functional)

1b1ccaa

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

run tidy and fmt

846588b

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

liamfallon previously approved these changes Jul 14, 2026

View reviewed changes

liamfallon requested review from a team and nagygergo July 15, 2026 13:53

Merge main into default-http-transport

2b04dd2

mozesl-nokia dismissed liamfallon’s stale review via 2b04dd2 July 15, 2026 14:51

mozesl-nokia requested a review from liamfallon July 16, 2026 08:30

nagygergo reviewed Jul 16, 2026

View reviewed changes

Comment thread internal/telemetry/otel.go

mozesl-nokia added the do-not-merge/hold #ededed label Jul 16, 2026

mozesl-nokia added 3 commits August 3, 2026 10:46

Merge main into default-http-transport

f8c37c9

wrap kube apiserver and podmanager OCI requests

309d697

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

remove unnecessary registry func, fix lint

6b0a8bb

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

mozesl-nokia removed the do-not-merge/hold #ededed label Aug 5, 2026

nagygergo reviewed Aug 6, 2026

View reviewed changes

Comment thread pkg/httpclient/registry.go Outdated

mozesl-nokia added 3 commits August 10, 2026 10:07

Merge main into default-http-transport

03ddee4

remove pkg/httpclient, restructure transport construction in podmanager

1130ec8

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

move podmanager tls unit tests, add new ones

bb2d6cb

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> Assisted-by: Cursor:grok-4.5

mozesl-nokia mentioned this pull request Aug 13, 2026

Ensure all HTTP traffic is tracked with OTel #1151

Open

Navigation Menu

Uh oh!

Remove overwriting the default HTTP transport - #1112

Remove overwriting the default HTTP transport#1112
mozesl-nokia wants to merge 14 commits into
kptdev:mainfrom
nokia:default-http-transport

mozesl-nokia commented Jul 13, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mozesl-nokia commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remove overwriting the default HTTP transport

Description

Related Issue(s)

Type of Change

Checklist

Additional Notes (Optional)

AI Disclosure

Uh oh!

netlify Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kpt-porch ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 10, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mozesl-nokia commented Jul 13, 2026 •

edited

Loading

netlify Bot commented Jul 13, 2026 •

edited

Loading