test(driver): update path references for scripts/driver/ (#3)

The driver.sh moved from roles/driver/ to scripts/driver/ in
564372a; update the four test scripts and the mock-garden harness
that reference it. Simplify mock-garden.sh's copy logic now that the
source path is unambiguous (the old logic carried fallback branches
for the move-in-flight state).

Update .github/workflows/driver-tests.yml so its shellcheck stanza
lints the scripts/-side artifacts (driver, daemon wrappers, stub
watcher) and the bash-syntax pass walks scripts/ and skills/ rather
than roles/ and skills/.

Local run of tests/driver/run.sh: 4 suites pass, 0 fail.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: endolinbot

.github/workflows/driver-tests.yml

@@ -42,15 +42,22 @@ jobs:
           git config --global user.name "ci-bot"
           git config --global user.email "ci-bot@example.invalid"
 
-      - name: shellcheck (driver + cleaner + per-test scripts)
-        # Lint the in-PR bash artifacts. Scope is the driver, the cleaner
+      - name: shellcheck (driver + daemons + watcher stub + cleaner + per-test scripts)
+        # Lint the in-PR bash artifacts. Scope is the driver, the daemon
+        # management wrappers, the stub feed watcher, the cleaner
         # skeleton, the gardener-inbox error reporter, and the driver
         # tests harness. Pre-existing scripts outside this scope have
         # known issues unrelated to this PR; widening the lint surface
         # is a separate effort.
         run: |
           shellcheck -S warning \
-            roles/driver/driver.sh \
+            scripts/driver/driver.sh \
+            scripts/daemons/start.sh \
+            scripts/daemons/stop.sh \
+            scripts/daemons/status.sh \
+            scripts/daemons/logs.sh \
+            scripts/daemons/config.sh.example \
+            scripts/watcher/endo-but-for-bots/watcher.sh \
             skills/cleaner/cleaner.sh \
             skills/cleaner/test-cleaner.sh \
             skills/gardener-inbox-error-reporting/report-error.sh \
@@ -61,8 +68,8 @@ jobs:
             tests/driver/test_loop_capture_and_self_improve.sh \
             tests/driver/test_trap_fires_on_error.sh
 
-      - name: bash -n (syntax check, all role and skill main scripts)
-        # Syntactic check on every shell script under roles/ and skills/.
+      - name: bash -n (syntax check, all scripts/ and skill main scripts)
+        # Syntactic check on every shell script under scripts/ and skills/.
         # `bash -n` is purely lexical so it is safe to run on the broader
         # set, unlike shellcheck which surfaces warnings the surrounding
         # scripts have not addressed yet.
@@ -74,7 +81,7 @@ jobs:
               echo "::error file=$f::bash -n failed"
               fail=1
             fi
-          done < <(find roles skills -mindepth 2 -maxdepth 3 -type f -name '*.sh' | sort)
+          done < <(find scripts skills -mindepth 2 -maxdepth 4 -type f -name '*.sh' | sort)
           if [ "$fail" -ne 0 ]; then
             exit 1
           fi

tests/driver/lib/mock-garden.sh

@@ -27,20 +27,12 @@ mock_garden_setup() {
 
   mkdir -p "$MOCK_GARDEN_ROOT" "$MOCK_STUBS" "$MOCK_BIN" "$MOCK_LOGS"
 
-  # 1. Copy roles/driver/ and the skills the driver invokes into the
+  # 1. Copy scripts/driver/ and the skills the driver invokes into the
   #    mock garden. We do not copy the entire real garden; that would
   #    drag in the journal as a git submodule. The mock harness needs
   #    only the artifacts the driver references at runtime.
-  cp -r "$REAL_GARDEN_ROOT/roles/driver" "$MOCK_GARDEN_ROOT/" 2>/dev/null || \
-    cp -r "$REAL_GARDEN_ROOT/roles/driver" "$MOCK_GARDEN_ROOT/roles-driver-tmp"
-  # The mkdir+cp pattern handles the case where roles/driver did not
-  # yet exist (first-run); the test fails fast if so. We unify here:
-  mkdir -p "$MOCK_GARDEN_ROOT/roles"
-  if [ -d "$MOCK_GARDEN_ROOT/roles-driver-tmp" ]; then
-    mv "$MOCK_GARDEN_ROOT/roles-driver-tmp" "$MOCK_GARDEN_ROOT/roles/driver"
-  elif [ -d "$MOCK_GARDEN_ROOT/driver" ]; then
-    mv "$MOCK_GARDEN_ROOT/driver" "$MOCK_GARDEN_ROOT/roles/driver"
-  fi
+  mkdir -p "$MOCK_GARDEN_ROOT/scripts"
+  cp -r "$REAL_GARDEN_ROOT/scripts/driver" "$MOCK_GARDEN_ROOT/scripts/"
 
   # Copy the skills the driver invokes.
   mkdir -p "$MOCK_GARDEN_ROOT/skills"
@@ -127,7 +119,7 @@ mock_garden_clear_pr_json() {
 mock_garden_run_driver() {
   local lane=$1
   shift
-  bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" "$lane" "$@"
+  bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" "$lane" "$@"
 }
 
 mock_garden_teardown() {

tests/driver/test_design_only_happy_path.sh

@@ -61,7 +61,7 @@ chmod +x "$stub_un_draft_file"
 export UN_DRAFT_STUB="$stub_un_draft_file"
 
 run_driver() {
-  bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1
+  bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1
 }
 
 read_state_field() {

tests/driver/test_loop_capture_and_self_improve.sh

@@ -67,7 +67,7 @@ export SELF_IMPROVE_CLAUDE_STUB="$stub_self_improve"
 
 # --- run the driver -------------------------------------------------------
 set +e
-bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1 >/dev/null 2>&1
+bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1 >/dev/null 2>&1
 rc=$?
 set -e
 
@@ -124,7 +124,7 @@ section_count_before=$(grep -c '^## tick at' "$improvements_file" 2>/dev/null ||
 
 mock_garden_set_pr_json '{"state":"OPEN","isDraft":true,"reviews":[]}'
 set +e
-bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1 >/dev/null 2>&1
+bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1 >/dev/null 2>&1
 rc2=$?
 set -e
 
@@ -161,7 +161,7 @@ mock_garden_set_pr_json '{"state":"OPEN","isDraft":true,"reviews":[]}'
 : > "$MOCK_LOGS/claude.log"
 
 set +e
-bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1 >/dev/null 2>&1
+bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1 >/dev/null 2>&1
 rc3=$?
 set -e
 

tests/driver/test_skeleton.sh

@@ -30,15 +30,15 @@ echo "=== test_skeleton ==="
 mock_garden_setup
 
 set +e
-output=$(bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 2>&1)
+output=$(bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 2>&1)
 rc=$?
 set -e
 run_assert mock_garden_assert_eq "no-lane rc is 64" 64 "$rc"
 run_assert mock_garden_assert_contains "no-lane stderr mentions usage" "usage:" "$output"
 
 # --- 2. usage error: non-integer lane ------------------------------------
 set +e
-output=$(bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" notalane 2>&1)
+output=$(bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" notalane 2>&1)
 rc=$?
 set -e
 run_assert mock_garden_assert_eq "non-integer lane rc is 64" 64 "$rc"
@@ -62,7 +62,7 @@ chmod +x "$POST_JOB_STUB"
 
 # Run oneshot. Without DRIVER_PR set, the driver will try to post a
 # build-design-only job to advance from initial.
-DRIVER_ONESHOT=1 bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1 >/dev/null 2>&1
+DRIVER_ONESHOT=1 bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1 >/dev/null 2>&1
 rc=$?
 
 state_file="$MOCK_GARDEN_JOURNAL/drivers/mock-host/1.md"

tests/driver/test_trap_fires_on_error.sh

@@ -61,7 +61,7 @@ bootstrap.
 EOF
 
 set +e
-bash "$MOCK_GARDEN_ROOT/roles/driver/driver.sh" 1 >/dev/null 2>&1
+bash "$MOCK_GARDEN_ROOT/scripts/driver/driver.sh" 1 >/dev/null 2>&1
 rc=$?
 set -e