Skip to content

Commit d09826d

Browse files
committed
Improve test consistency
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
1 parent ce97fba commit d09826d

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

vertical-pod-autoscaler/pkg/updater/restriction/pods_restriction_factory_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -646,14 +646,12 @@ func TestEvictReplicatedByDaemonSet(t *testing.T) {
646646
numberReady int32
647647
}{
648648
{
649-
name: "All pods ready.",
649+
name: "Evict two pods (half of 5).",
650650
numberReady: livePods,
651651
},
652652
{
653-
// A DaemonSet whose pods are all unready (e.g. crash looping because the
654-
// applied recommendation is too low) must still be updatable, otherwise it
655-
// can never recover.
656-
name: "No pods ready.",
653+
// Tests that pods of a crash looping DaemonSet can still be evicted, otherwise it could never recover.
654+
name: "Evict two pods (half of 5) even if no pods are ready.",
657655
numberReady: 0,
658656
},
659657
}

0 commit comments

Comments
 (0)