Skip to content

Commit baf2c55

Browse files
committed
fix: address review feedback on i18n foundation
- en.toml: add pluralization (one/other) for kep_related_enhancements and kep_participating_sigs. - keps/single.html: pass count to i18n T function for plural-aware labels. - CONTRIBUTING.md: reframe 'Adding a New Language' for existing SIG Docs localization teams; add link to k8s.io localization guide. - OWNERS_ALIASES: replace sig-contribex-i18n-tech-leads with SIG Docs leads; remove sig-contribex-website-owners and sig-contribex-website-reviewers (split to separate PR per review feedback). - OWNERS: revert content/ filter addition (split to separate PR).
1 parent a658529 commit baf2c55

5 files changed

Lines changed: 17 additions & 14 deletions

File tree

CONTRIBUTING.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ To ensure translation accuracy and consistency across the Kubernetes project:
2626
- **Ownership**: Each language directory (e.g., `content/ko/`) should contain an `OWNERS` file that references the corresponding SIG Docs GitHub team (e.g., `@kubernetes/sig-docs-ko-owners`).
2727
- **Process**: Localization contributors should follow the [SIG Docs Localization guide](https://kubernetes.io/docs/contribute/localization/) for best practices, but all PRs should be opened against the `kubernetes/contributor-site` repository.
2828

29-
### Adding a New Language
29+
### Adding a New Language (For Existing SIG Docs Localization Teams)
30+
31+
This guide is for **established SIG Docs localization teams** that want to add their language to the Kubernetes Contributor Site (`kubernetes.dev`). If you are interested in starting a new localization for the first time, please see the [SIG Docs Localization guide](https://kubernetes.io/docs/contribute/localization/#start-a-new-localization) and work with the SIG Docs Leads to establish your team before proceeding.
32+
3033
To bootstrap support for a new language on the contributor site:
3134

3235
1. **Update `hugo.yaml`**:
@@ -48,7 +51,7 @@ To bootstrap support for a new language on the contributor site:
4851
Create the base directory for the new language (e.g., `content/ko/`) and copy the `_index.md` from `content/en/` to start.
4952

5053
3. **Set Up the `OWNERS` File**:
51-
Add an `OWNERS` file in the root of the new language directory (`content/<lang>/OWNERS`) to properly delegate reviews and approvals to the SIG Docs language team.
54+
Add an `OWNERS` file in the root of the new language directory (`content/<lang>/OWNERS`) referencing the corresponding SIG Docs GitHub team.
5255
```yaml
5356
# content/ko/OWNERS
5457
# This is the localization project for Korean.

OWNERS

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ filters:
1414
- TineoC
1515
- tokt
1616
- sig-contributor-experience-leads
17-
# files/directories related to static site generator and localization framework
18-
"^(assets|layouts|static|package-lock\\.json|package\\.json|netlify\\.toml|hugo\\.yaml|content/)":
17+
# files/directories related to static site generator
18+
"^(assets|layouts|static|package-lock\\.json|package\\.json|netlify\\.toml|hugo\\.yaml)$":
1919
reviewers:
2020
- SayakMukhopadhyay
21-
- sig-contribex-website-reviewers

OWNERS_ALIASES

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@ aliases:
2424
- Tengqm
2525
- seokho-son
2626
sig-contribex-i18n-tech-leads:
27-
- TineoC
28-
- lmktfy
29-
sig-contribex-website-owners:
30-
- TineoC
31-
sig-contribex-website-reviewers:
32-
- lmktfy
33-
- jberkus
27+
- dipesh-rawat
28+
- divya-mohan0209
29+
- katcosgrove
30+
- natalisucks
3431
- reylejano
32+
- salaxander
33+
- Tengqm
3534
sig-contribex-en-owners:
3635
- fsmunoz
3736
- TineoC

i18n/en/en.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ other = "et al."
215215
other = "Implementation History"
216216

217217
[kep_related_enhancements]
218+
one = "Related Enhancement"
218219
other = "Related Enhancements"
219220

220221
[kep_ownership]
@@ -224,6 +225,7 @@ other = "Ownership"
224225
other = "Owning SIG"
225226

226227
[kep_participating_sigs]
228+
one = "Participating SIG"
227229
other = "Participating SIGs"
228230

229231
[kep_primary_authors]

layouts/keps/single.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ <h1>KEP-{{ .Params.kepNumber }}: {{ .Title }}</h1>
7878

7979
{{ with .Params.seeAlso }}
8080
<div class="kep-related-refined pt-3 border-top mt-3">
81-
<div class="kep-banner-sublabel">{{ T "kep_related_enhancements" }}</div>
81+
<div class="kep-banner-sublabel">{{ T "kep_related_enhancements" (len .) }}</div>
8282
<ul class="kep-link-list">
8383
{{ range . }}
8484
<li>
@@ -114,7 +114,7 @@ <h1>KEP-{{ .Params.kepNumber }}: {{ .Title }}</h1>
114114

115115
{{ with .Params.participatingSigs }}
116116
<div class="kep-sig-section mb-4 pt-3 border-top">
117-
<div class="kep-banner-sublabel">{{ T "kep_participating_sigs" }}</div>
117+
<div class="kep-banner-sublabel">{{ T "kep_participating_sigs" (len .) }}</div>
118118
<div class="d-flex flex-wrap gap-2">
119119
{{ range $i, $sig := . }}
120120
{{- $sigSlug := strings.TrimPrefix "sig-" $sig -}}

0 commit comments

Comments
 (0)