Skip to content

Commit 8f72313

Browse files
committed
test: Honor --minikube-start-args in kic custom network tests
These starts built their own argv and never appended StartArgs(), so CI's --container-runtime never reached minikube start. After the default became containerd they would run containerd even on *-docker-* jobs. Append StartArgs() to the custom network, existing network, subnet, and static-ip starts.
1 parent dc3f2bd commit 8f72313

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

test/integration/kic_custom_network_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func TestKicCustomNetwork(t *testing.T) {
5353
defer Cleanup(t, profile, cancel)
5454

5555
startArgs := []string{"start", "-p", profile, fmt.Sprintf("--network=%s", test.networkName)}
56+
startArgs = append(startArgs, StartArgs()...)
5657
c := exec.CommandContext(ctx, Target(), startArgs...)
5758
rr, err := Run(t, c)
5859
if err != nil {
@@ -89,6 +90,7 @@ func TestKicExistingNetwork(t *testing.T) {
8990
verifyNetworkExists(ctx, t, networkName)
9091

9192
startArgs := []string{"start", "-p", profile, fmt.Sprintf("--network=%s", networkName)}
93+
startArgs = append(startArgs, StartArgs()...)
9294
c := exec.CommandContext(ctx, Target(), startArgs...)
9395
rr, err := Run(t, c)
9496
if err != nil {
@@ -108,6 +110,7 @@ func TestKicCustomSubnet(t *testing.T) {
108110

109111
subnet := "192.168.60.0/24"
110112
startArgs := []string{"start", "-p", profile, fmt.Sprintf("--subnet=%s", subnet)}
113+
startArgs = append(startArgs, StartArgs()...)
111114
c := exec.CommandContext(ctx, Target(), startArgs...)
112115
rr, err := Run(t, c)
113116
if err != nil {
@@ -128,6 +131,7 @@ func TestKicStaticIP(t *testing.T) {
128131

129132
staticIP := "192.168.200.200"
130133
startArgs := []string{"start", "-p", profile, fmt.Sprintf("--static-ip=%s", staticIP)}
134+
startArgs = append(startArgs, StartArgs()...)
131135
c := exec.CommandContext(ctx, Target(), startArgs...)
132136
rr, err := Run(t, c)
133137
if err != nil {

0 commit comments

Comments
 (0)