Dock results list in main window

[pintassilgo]

Before using Cuda, Notepad++ was my main editor and I miss that the Np++ "find in files" results are docked in main window, below the document, instead of in a separated window as it is in FiF.

I tried this fork of FiF and it has the feature of docking results in main window in a very similar way to Notepad++.

Can this be merged?

[Alexey-T]

I do not like the idea: FIF4 results window is very tall so it will looks bad when docked.
@kvichans If user gives the patch based on mentioned fork, is it OK?

[pintassilgo]

How it looks in Notepad++:

How it looks in the fork:

By the way, notice the fork also fixed #81.

What do you see bad about the idea? It's the same as using Cuda with console open, or any other bottom panel.

[Alexey-T]

Ah, then it is Ok. Can you add the option and give the patch?

[pintassilgo]

I can see the difference in code here ("Files changed" tab), but I'm not Python dev to properly understand and propose a modified patch.

[Alexey-T]

@kvichans Hi. Can you review that changes from linked repo (link above)?

[Alexey-T]

Maybe I will review the change, but give me some time..

[Alexey-T]

My test of FindInFiles_J fork:
@jackusay

1. not all = (button) / Results tree (values 1/ 2/ 3) option values work ok in new bottom panel. with value 1 or 3, dbl-click on bottom's editor - don't open corresponding file in UI-tabs.
2. even when corresponding file is opened, it opens at the begin. it must open at the match of the clicked line.

I cannot merge changes - because of this.
If @jackusay wants to improve it, pls also sync with last FIF4 changes. it will make my merge work easier! pls also remove logx() calls if possible. it will make diff smaller.

quote from site:
This branch is 62 commits ahead of, 8 commits behind kvichans/cuda_find_in_files4:master.