Skip to content

Commit 0827d9a

Browse files
committed
Fix tests
1 parent 04a44cd commit 0827d9a

2 files changed

Lines changed: 18 additions & 5 deletions

File tree

ffi/src/ffi_tracing.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//! FFI functions to allow engines to receive log, tracing, and metrics events from kernel.
22
//!
33
//! We use a single global tracing subscriber, registered the first time any of
4-
//! [`enable_event_tracing`], [`enable_log_line_tracing`], [`enable_formatted_log_line_tracing`], or
4+
//! [`enable_event_tracing`], [`enable_log_line_tracing`], [`enable_formatted_log_line_tracing`],
55
//! [`enable_metrics_reporting`], or [`enable_frame_reporting`] is called. The subscriber has
66
//! independent layers for log events, metric reports, and frame lifecycle events:
77
//!

kernel/src/metrics/frame_reporter.rs

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,25 @@ mod tests {
162162

163163
#[test]
164164
fn registers_interest_only_in_marked_spans() {
165-
capture(|| {
165+
let reporter = Arc::new(CapturingFrameReporter::default());
166+
let layer = FrameReporterLayer::new(reporter);
167+
168+
with_default(Registry::default(), || {
166169
let unmarked = trace_span!("unmarked-trace");
167170
let marked = trace_span!("marked-trace", enable_call_frame = Empty);
168-
169-
assert!(unmarked.is_disabled());
170-
assert!(!marked.is_disabled());
171+
let unmarked_metadata = unmarked.metadata().unwrap();
172+
let marked_metadata = marked.metadata().unwrap();
173+
174+
assert!(<FrameReporterLayer as Layer<Registry>>::register_callsite(
175+
&layer,
176+
unmarked_metadata
177+
)
178+
.is_never());
179+
assert!(<FrameReporterLayer as Layer<Registry>>::register_callsite(
180+
&layer,
181+
marked_metadata
182+
)
183+
.is_always());
171184
});
172185
}
173186

0 commit comments

Comments
 (0)