Cryptic error message for security scans misconfiguration

[Tomasz-Smelcerz-SAP]

Description

This is the error:

Warning: dry-run flag is set to true. The descriptor will NOT be pushed.
- Configuring security scanners config
Error: failed to configure security scanners: failed to validate security config images: no image with the correct manager version found in BDBA images '[europe-docker.pkg.dev/kyma-project/prod/](http://europe-docker.pkg.dev/kyma-project/prod/)<image-name>:1.0.7-experimental', invalid argument

Produced by modulectl when

• security: sec-scanners-config.yaml is provided
• the channel is: experimental
• the command was: --config-file=/agent/_work/1/main-repo/modules/kim-snatch/1.0.7-experimental/module-config.yaml --registry=https://europe-docker.pkg.dev/kyma-project/kyma-modules --registry-credentials=oauth2accesstoken:*** --output=/agent/_work/1/kyma-modules/kim-snatch/moduletemplate-kim-snatch-1.0.7-experimental.yaml --skip-version-validation --dry-run

Reasons

Attachments

[c-pius]

Okay, wrapped my head around it again :)

The thing we are trying to enforce is that the tag used for the manager image MUST equal the version of the module. Currently, we have such validation in two places:

• https://github.com/kyma-project/modulectl/blob/main/internal/service/verifier/image_version_verifier.go#L78
  • this one is there to stay
  • for this one can be controlled by the --skip-version-validation
• https://github.com/kyma-project/modulectl/blob/main/internal/service/contentprovider/securityconfig.go#L95
  • this one is supposed to be removed as we drop the entire security config
  • the --skip-version-validation was not backported to this one

The error was raised in the original case leading up to this issue because indeed the security config was incorrect. So I think we don't need to change the current implementation. We can think about improving the error message to make it clearer what the issue is.